Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-9131

use security group to count instances launched by jenkins

    • Icon: Improvement Improvement
    • Resolution: Unresolved
    • Icon: Minor Minor
    • ec2-plugin
    • None

      Currently, the ec2 counts all instances launched by the credentials it knows about against the instance cap. This makes sense in a braces and suspenders way, but can be a bit inconvenient. Once the fix for http://issues.jenkins-ci.org/browse/JENKINS-8617 lands, it will be possible to use the security group specified as a 'tag' for the instance and only count instances in the specified group against the tag.

          [JENKINS-9131] use security group to count instances launched by jenkins

          akostadinov added a comment -

          actually counting based on key is better IMO

          akostadinov added a comment - actually counting based on key is better IMO

          mwhudson added a comment -

          Ah, yes, that would probably make sense.

          mwhudson added a comment - Ah, yes, that would probably make sense.

          rob p added a comment -

          actually, i've got several jenkins instances which use the same key pair and currently clash due to counting the ami instances, and in the future (if this were implemented) would clash on key pair count. Counting by a known tag put upon the slave instance at launch time would be better, and the facility to add tags to the slaves is already there in the plugin - so it would just mean adding one more under-the-hood with a uuid for the master.

          at the moment my workaround is to build a copy of my slave instance ami, one per jenkins master - which kinda sucks.

          rob p added a comment - actually, i've got several jenkins instances which use the same key pair and currently clash due to counting the ami instances, and in the future (if this were implemented) would clash on key pair count. Counting by a known tag put upon the slave instance at launch time would be better, and the facility to add tags to the slaves is already there in the plugin - so it would just mean adding one more under-the-hood with a uuid for the master. at the moment my workaround is to build a copy of my slave instance ami, one per jenkins master - which kinda sucks.

          rob p added a comment -

          Here's anouther downside of using the ami id rather than using a known tag that i've just discovered. If you change the ami being pointed to (say, every time you rebuild the ami image for your slave workers) you'll get the instance cap for that ami in addition to all the existing slaves which use the older ami. The net result is (in my case) the slave count being higher than the actual instance cap set causes knock on problems elsewhere in the infrastructure.

          rob p added a comment - Here's anouther downside of using the ami id rather than using a known tag that i've just discovered. If you change the ami being pointed to (say, every time you rebuild the ami image for your slave workers) you'll get the instance cap for that ami in addition to all the existing slaves which use the older ami. The net result is (in my case) the slave count being higher than the actual instance cap set causes knock on problems elsewhere in the infrastructure.

            mwhudson mwhudson
            mwhudson mwhudson
            Votes:
            1 Vote for this issue
            Watchers:
            1 Start watching this issue

              Created:
              Updated: