Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-918

Xvnc plugin needs configurable base display number

    • Icon: Bug Bug
    • Resolution: Fixed
    • Icon: Major Major
    • plugin-proposals
    • None
    • Platform: All, OS: All

      The display number that the Xvnc plugin uses to start its displays at is :10;
      subsequent displays are at :11, :12, and so on. This is not currently configurable.

      At Amazon, our company-wide sshd_config sets its X forwarding ports to start at
      an offset of 10, which collides with the X ports used by Xvnc. We can't change
      this sshd_config, since that would affect thousands of computers.

      Making the Xvnc plugin have a configurable base display offset solves this
      problem- when I change the base display number to something else (say, 85) the
      sshd X forwarding ports and the Xvnc ports don't collide.

      I have submitted a patch that does this to dev@hudson.dev.java.net - it adds the
      configuration field to the plugin control panel UI, and changes the plugin and
      its display allocator to use the configured field. The default remains 10, if
      the user doesn't enter anything in the UI.

          [JENKINS-918] Xvnc plugin needs configurable base display number

          adamfeuer created issue -

          adamfeuer added a comment -

          Created an attachment (id=104)
          Proposed patch to allow configurable base display numbers for Xvnc plugin

          adamfeuer added a comment - Created an attachment (id=104) Proposed patch to allow configurable base display numbers for Xvnc plugin

          adamfeuer added a comment -

          I attached the patch, done against the CVS tip. Let me know if you need the
          patch in different format, or done differently, and I can re-do it.

          We're using the patched plugin in production on one project here at Amazon, it
          gets used to build and test projects daily.

          adamfeuer added a comment - I attached the patch, done against the CVS tip. Let me know if you need the patch in different format, or done differently, and I can re-do it. We're using the patched plugin in production on one project here at Amazon, it gets used to build and test projects daily.

          The patch seems to be in a non-standard format — my Unix patch command doesn't
          like the input. I suspect "cvs diff" would produce something better.

          (And I'm still hoping Jesse would chime in)

          Kohsuke Kawaguchi added a comment - The patch seems to be in a non-standard format — my Unix patch command doesn't like the input. I suspect "cvs diff" would produce something better. (And I'm still hoping Jesse would chime in)

          bradfritz added a comment -

          Created an attachment (id=106)
          convert "patch" to a unified diff

          bradfritz added a comment - Created an attachment (id=106) convert "patch" to a unified diff

          bradfritz added a comment -

          I had a few minutes to kill so I converted the "patch" to a
          unified diff ("-u" option to "diff" or "cvs diff") so it will work
          with the patch command.

          I tried to convert it as precisely as possible with one exception: I
          added a missing asterisk to the start of a javadoc comment for
          baseDisplayNumber in Xvnc.java. I didn't do any testing of the patch
          other than to make sure "mvn package" still works for the plugin.

          bradfritz added a comment - I had a few minutes to kill so I converted the "patch" to a unified diff ("-u" option to "diff" or "cvs diff") so it will work with the patch command. I tried to convert it as precisely as possible with one exception: I added a missing asterisk to the start of a javadoc comment for baseDisplayNumber in Xvnc.java. I didn't do any testing of the patch other than to make sure "mvn package" still works for the plugin.

          adamfeuer added a comment -

          added myself to cc

          adamfeuer added a comment - added myself to cc

          adamfeuer added a comment -

          Created an attachment (id=107)
          Xvnc plugin configurable display number - made using 'cvs diff -u'

          adamfeuer added a comment - Created an attachment (id=107) Xvnc plugin configurable display number - made using 'cvs diff -u'

          adamfeuer added a comment -

          I redid the patch using 'cvs diff -u' - would you be willing to see if this works?

          I'm sorry the first patch I made didn't work!

          -adam

          adamfeuer added a comment - I redid the patch using 'cvs diff -u' - would you be willing to see if this works? I'm sorry the first patch I made didn't work! -adam

          adamfeuer added a comment -

          Created an attachment (id=108)
          Xvnc plugin configurable display number - made using 'cvs diff -u'

          adamfeuer added a comment - Created an attachment (id=108) Xvnc plugin configurable display number - made using 'cvs diff -u'

            jglick Jesse Glick
            adamfeuer adamfeuer
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Created:
              Updated:
              Resolved: