Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-9597

Autocomplete box in text boxes is not selectable using the enter key

    • Icon: Bug Bug
    • Resolution: Unresolved
    • Icon: Trivial Trivial
    • core
    • Windows 7 64 bit
      Jenkins 1.403
      Opera 11.10
      Firefox 4.0

      Jenkins closes/saves the project configuration if the user presses RETURN in a text field. If the text field has a Jenkins provided auto-completion (or an auto-completion of a browsers like Firefox) then Jenkins also saves the configuration upon selecting a value in the auto-completion list. This is irritating since the user does not expect that a dialog will be closed due to a selection in a list. Either provide a new shortcut to close/save a dialog (as it is done in Jira using ALT-S) or provide a special handling for ENTER if there is a auto-completion in progress.

      Old Issue description:

      Under the build triggers block in the job configuration if you check off "Build after other projects are built" and start typing a project name, the auto complete box that offers possible suggestions for jobs you want to set as triggers does not respond to the enter key.

      For example I type test, it tells me available jobs are test-1 and test-2, I use the arrow key to scroll down to test-1 and press enter it will save and exit the configuration rather than select test-1 because the enter key is still tied to the save button.

      *Also I believe that Projects names is a grammatical error, and should instead be Project names.

          [JENKINS-9597] Autocomplete box in text boxes is not selectable using the enter key

          oseparovic created issue -

          Drew Repasky added a comment -

          This is probably not a bug – I confirmed the described behavior in Firefox 3.6.12 and 5.0, but I would guess that it is intentional.

          The Enter key in the "Configure Job" webform will trigger a form submit, and will result in any changes being saved (unless you are in a Textarea field such as Description). This is nice because you won't need to scroll or tab all the way down to the Save button to make a quick change to a job.

          The behavior you want can be accomplished by using the Tab key. Just start typing to get some suggestions from the YUI Autocomplete mechanism, then use the arrows to select one, then tab to move to the next field without saving.

          Drew Repasky added a comment - This is probably not a bug – I confirmed the described behavior in Firefox 3.6.12 and 5.0, but I would guess that it is intentional. The Enter key in the "Configure Job" webform will trigger a form submit, and will result in any changes being saved (unless you are in a Textarea field such as Description). This is nice because you won't need to scroll or tab all the way down to the Save button to make a quick change to a job. The behavior you want can be accomplished by using the Tab key. Just start typing to get some suggestions from the YUI Autocomplete mechanism, then use the arrows to select one, then tab to move to the next field without saving.

          Drew Repasky added a comment -

          This is probably not a bug – I confirmed the described behavior in Firefox 3.6.12 and 5.0, but I would guess that it is intentional.

          The Enter key in the "Configure Job" webform will trigger a form submit, and will result in any changes being saved (unless you are in a Textarea field such as Description). This is nice because you won't need to scroll or tab all the way down to the Save button to make a quick change to a job.

          The behavior you want can be accomplished by using the Tab key. Just start typing to get some suggestions from the YUI Autocomplete mechanism, then use the arrows to select one, then tab to move to the next field without saving.

          Drew Repasky added a comment - This is probably not a bug – I confirmed the described behavior in Firefox 3.6.12 and 5.0, but I would guess that it is intentional. The Enter key in the "Configure Job" webform will trigger a form submit, and will result in any changes being saved (unless you are in a Textarea field such as Description). This is nice because you won't need to scroll or tab all the way down to the Save button to make a quick change to a job. The behavior you want can be accomplished by using the Tab key. Just start typing to get some suggestions from the YUI Autocomplete mechanism, then use the arrows to select one, then tab to move to the next field without saving.
          Drew Repasky made changes -
          Fix Version/s New: current [ 10162 ]
          Assignee New: Drew Repasky [ drew ]
          Resolution New: Not A Defect [ 7 ]
          Status Original: Open [ 1 ] New: Resolved [ 5 ]

          Simon Hall added a comment -

          To me, this does actually seem like a bug - I keep on hitting this problem because it is so natural for me to hit Enter when choosing from a drop-down. For me, 'Enter' is not the best hotkey for saving. Of course many users are probably attached to that function now so what I'd suggest is that 'Enter' does not mean 'Save' if you are in the YUI Autocomplete mechanism. I can't imagine that would affect any users negatively.

          (I'm afraid I don't know what next step to take with this issue).

          Simon Hall added a comment - To me, this does actually seem like a bug - I keep on hitting this problem because it is so natural for me to hit Enter when choosing from a drop-down. For me, 'Enter' is not the best hotkey for saving. Of course many users are probably attached to that function now so what I'd suggest is that 'Enter' does not mean 'Save' if you are in the YUI Autocomplete mechanism. I can't imagine that would affect any users negatively. (I'm afraid I don't know what next step to take with this issue).

          Ulli Hafner added a comment -

          Reopening since this actually is a bug (or at least leads to a bad user experience). We should not change common UI patterns in Jenkins. If we need a shortcut to finish a screen then we should define a new one instead of reusing an existing key that has a different semantic.

          Ulli Hafner added a comment - Reopening since this actually is a bug (or at least leads to a bad user experience). We should not change common UI patterns in Jenkins. If we need a shortcut to finish a screen then we should define a new one instead of reusing an existing key that has a different semantic.
          Ulli Hafner made changes -
          Resolution Original: Not A Defect [ 7 ]
          Status Original: Resolved [ 5 ] New: Reopened [ 4 ]
          Ulli Hafner made changes -
          Summary Original: Autocomplete box under Projects names is not selectable using the enter key New: Autocomplete box in text boxes is not selectable using the enter key
          Ulli Hafner made changes -
          Description Original: Under the build triggers block in the job configuration if you check off "Build after other projects are built" and start typing a project name, the auto complete box that offers possible suggestions for jobs you want to set as triggers does not respond to the enter key.

          For example I type test, it tells me available jobs are test-1 and test-2, I use the arrow key to scroll down to test-1 and press enter it will save and exit the configuration rather than select test-1 because the enter key is still tied to the save button.

          *Also I believe that Projects names is a grammatical error, and should instead be Project names.
          New: Jenkins closes/saves the project configuration if the user presses RETURN in a text field. If the text field has a Jenkins provided auto-completion (or an auto-completion of a browsers like Firefox) then Jenkins also saves the configuration upon selecting a value in the auto-completion list. This is irritating since the user does not expect that a dialog will be closed due to a selection in a list. Either provide a new shortcut to close/save a dialog (as it is done in Jira using ALT-S) or provide a special handling for ENTER if there is a auto-completion in progress.

          Old Issue description:

          Under the build triggers block in the job configuration if you check off "Build after other projects are built" and start typing a project name, the auto complete box that offers possible suggestions for jobs you want to set as triggers does not respond to the enter key.

          For example I type test, it tells me available jobs are test-1 and test-2, I use the arrow key to scroll down to test-1 and press enter it will save and exit the configuration rather than select test-1 because the enter key is still tied to the save button.

          *Also I believe that Projects names is a grammatical error, and should instead be Project names.
          Drew Repasky made changes -
          Assignee Original: Drew Repasky [ drew ]

            Unassigned Unassigned
            oseparovic oseparovic
            Votes:
            5 Vote for this issue
            Watchers:
            8 Start watching this issue

              Created:
              Updated: