Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-9960

Plugin Dependencies not started before plugin in HudsonTestCase

    XMLWordPrintable

Details

    Description

      While plugins are started in the correct order when deployed normally (and via hpi:run), the upstream plugin is not started before the dependent plugin when run under HudsonTestCase.

      Steps to reproduce:

      git clone git://github.com/recampbell/jenkins-plugin-bugs.git
      cd jenkins-plugin-bugs/JENKINS-9960
      mvn clean install

      Attachments

        Activity

          Ascending order - Click to sort in descending order
          recampbell Ryan Campbell created issue -
          recampbell Ryan Campbell made changes -
          Field Original Value New Value
          URL https://github.com/recampbell/jenkins-plugin-bugs/tree/master/JENKINS-9960
          Description While plugins are started in the correct order when deployed normally (and via hpi:run), the upstream plugin is not started before the dependent plugin when run under HudsonTestCase.

          		 While plugins are started in the correct order when deployed normally (and via hpi:run), the upstream plugin is not started before the dependent plugin when run under HudsonTestCase.

          Steps to reproduce:

          git clone git://github.com/recampbell/jenkins-plugin-bugs.git
          cd jenkins-plugin-bugs/JENKINS-9960
          mvn clean install
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Kohsuke Kawaguchi
          Path:
          changelog.html
          core/src/main/java/hudson/PluginManager.java
          core/src/main/java/hudson/util/CyclicGraphDetector.java
          plugins/pom.xml
          pom.xml
          http://jenkins-ci.org/commit/jenkins/e03ba7dc6ba3753ed18d0de02133734ab171fb21
          Log:
          [FIXED JENKINS-9960]

          We weren't actually enforcing the initialization order at all, as
          sorting was based on the plugin name.

          Compare: https://github.com/jenkinsci/jenkins/compare/938ac77...e03ba7d

          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Kohsuke Kawaguchi Path: changelog.html core/src/main/java/hudson/PluginManager.java core/src/main/java/hudson/util/CyclicGraphDetector.java plugins/pom.xml pom.xml http://jenkins-ci.org/commit/jenkins/e03ba7dc6ba3753ed18d0de02133734ab171fb21 Log: [FIXED JENKINS-9960] We weren't actually enforcing the initialization order at all, as sorting was based on the plugin name. Compare: https://github.com/jenkinsci/jenkins/compare/938ac77...e03ba7d
          scm_issue_link SCM/JIRA link daemon made changes -
          Resolution Fixed [ 1 ]
          Status Open [ 1 ] Resolved [ 5 ]
          dogfood dogfood added a comment -

          Integrated in jenkins_main_trunk #871
          [FIXED JENKINS-9960]

          Kohsuke Kawaguchi : e03ba7dc6ba3753ed18d0de02133734ab171fb21
          Files :

          • core/src/main/java/hudson/PluginManager.java
          • changelog.html
          • core/src/main/java/hudson/util/CyclicGraphDetector.java
          • plugins/pom.xml
          • pom.xml
          dogfood dogfood added a comment - Integrated in jenkins_main_trunk #871 [FIXED JENKINS-9960] Kohsuke Kawaguchi : e03ba7dc6ba3753ed18d0de02133734ab171fb21 Files : core/src/main/java/hudson/PluginManager.java changelog.html core/src/main/java/hudson/util/CyclicGraphDetector.java plugins/pom.xml pom.xml
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Kohsuke Kawaguchi
          Path:
          changelog.html
          core/src/main/java/hudson/PluginManager.java
          core/src/main/java/hudson/util/CyclicGraphDetector.java
          plugins/pom.xml
          pom.xml
          http://jenkins-ci.org/commit/jenkins/e03ba7dc6ba3753ed18d0de02133734ab171fb21
          Log:
          [FIXED JENKINS-9960]

          We weren't actually enforcing the initialization order at all, as
          sorting was based on the plugin name.

          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Kohsuke Kawaguchi Path: changelog.html core/src/main/java/hudson/PluginManager.java core/src/main/java/hudson/util/CyclicGraphDetector.java plugins/pom.xml pom.xml http://jenkins-ci.org/commit/jenkins/e03ba7dc6ba3753ed18d0de02133734ab171fb21 Log: [FIXED JENKINS-9960] We weren't actually enforcing the initialization order at all, as sorting was based on the plugin name.
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Kohsuke Kawaguchi
          Path:
          changelog.html
          core/src/main/java/hudson/PluginManager.java
          core/src/main/java/hudson/util/CyclicGraphDetector.java
          plugins/pom.xml
          pom.xml
          http://jenkins-ci.org/commit/jenkins/e03ba7dc6ba3753ed18d0de02133734ab171fb21
          Log:
          [FIXED JENKINS-9960]

          We weren't actually enforcing the initialization order at all, as
          sorting was based on the plugin name.

          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Kohsuke Kawaguchi Path: changelog.html core/src/main/java/hudson/PluginManager.java core/src/main/java/hudson/util/CyclicGraphDetector.java plugins/pom.xml pom.xml http://jenkins-ci.org/commit/jenkins/e03ba7dc6ba3753ed18d0de02133734ab171fb21 Log: [FIXED JENKINS-9960] We weren't actually enforcing the initialization order at all, as sorting was based on the plugin name.
          rtyler R. Tyler Croy made changes -
          Workflow JNJira [ 140148 ] JNJira + In-Review [ 188870 ]

          People

            Unassigned Unassigned
            recampbell Ryan Campbell
            Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: