Details
-
Type:
Bug
-
Status: Done (View Workflow)
-
Priority:
Critical
-
Resolution: Fixed
-
Component/s: plugin-site
-
Labels:None
-
Similar Issues:
Description
https://wiki.jenkins.io/display/JENKINS/Blue+Ocean+Plugin now has tables for the changelog.
https://plugins.jenkins.io/blueocean doesn't show them.
Hypothesis: Over-eager removal of all tables when we really only want to remove the macro-provided statistics table that's typically on top.
Attachments
Issue Links
- is duplicated by
-
-
- Closed
-
- relates to
-
WEBSITE-356 plugins.jenkins.io not showing "{code}" blocks
-
- Done
-
- links to
Activity
Daniel Beck So I've narrowed some use cases that I want to get your opinion.
<span class="conf-macro output-inline" data-hasbody="true" data-macro-name="unmigrated-inline-wiki-markup"> <h4><a name="GitPlugin-PluginInformation"></a>Plugin Information</h4> </span> <span class="conf-macro output-inline" data-hasbody="true" data-macro-name="unmigrated-inline-wiki-markup"></span> <h4><a name="GitPlugin-PluginInformation"></a>Plugin Information</h4> <p> <spanclass="conf-macro output-inline"data-hasbody="true"data-macro-name="unmigrated-inline-wiki-markup"> <h4><a name="GitPlugin-PluginInformation"></a>Plugin Information</h4> </span> </p>
The new algorithm is simply checking for the h4 specifically with Project Information and removing it so the span isn't being used. The only other thing is the table with all of the plugin information. Sometimes it's inside of the span, sometimes not. Not sure if we know if every plugin has one of these tables. If so it might be reasonable to assume removing the first table with class "confluenceTable" will work.
Michael McCaskill
added a comment - Daniel Beck So I've narrowed some use cases that I want to get your opinion.
<span class="conf-macro output-inline" data-hasbody="true" data-macro-name="unmigrated-inline-wiki-markup">
<h4><a name="GitPlugin-PluginInformation"></a>Plugin Information</h4>
</span>
<span class="conf-macro output-inline" data-hasbody="true" data-macro-name="unmigrated-inline-wiki-markup"></span>
<h4><a name="GitPlugin-PluginInformation"></a>Plugin Information</h4>
<p>
<spanclass="conf-macro output-inline"data-hasbody="true"data-macro-name="unmigrated-inline-wiki-markup">
<h4><a name="GitPlugin-PluginInformation"></a>Plugin Information</h4>
</span>
</p>
The new algorithm is simply checking for the h4 specifically with Project Information and removing it so the span isn't being used. The only other thing is the table with all of the plugin information. Sometimes it's inside of the span, sometimes not. Not sure if we know if every plugin has one of these tables. If so it might be reasonable to assume removing the first table with class "confluenceTable" will work. Not sure if we know if every plugin has one of these tables.
Since the macro is optional, I expect there will be plugins without.
If so it might be reasonable to assume removing the first table with class "confluenceTable" will work.
Some plugin wiki pages have content above the macro table, so that wouldn't work.
I'll simplify the macro output first, then we'll take another stab at this.
Michael McCaskill PTAL https://github.com/jenkins-infra/backend-jenkins-plugin-info-plugin/pull/18 for what I hope future output looks like. It's just a table cell with mostly fixed content (plus warnings and adopt-a-plugin messages as today). No "Plugin Information" title anymore.
Another example: https://plugins.jenkins.io/vectorcast-execution