Code changed in jenkins
User: Adam Monsen
Path:
src/main/java/hudson/plugins/jabber/im/transport/JabberPublisher.java
http://jenkins-ci.org/commit/jabber-plugin/e88e473738dfe6f9ba77d2c3767736add12de9b8
Log:
[FIXED JENKINS-11443] E-mail address as Jabber ID config setting.
null was being returned by getConfiguredIMId() when
- user's jabber ID was not set
- user's email WAS set
- setting "E-mail address as Jabber ID" was enabled
It should have been returning the user's email address.
This patch fixes the configuration setting "E-mail address as Jabber ID"
when the conditions described above are met. The setting can be found
at /configure under "Advanced..." for the Jabber Notification plugin.
During testing I didn't receive any messages from the Jenkins Jabber
robot, but this was probably just a misconfiguration in my local testing
environment. The bot did reply to me when I directly IM'ed "!status" or
"!build test" or whatever, it just wouldn't send automatic
notifications. I was using two different users on jabber.org, one was my
real ID, another was made just to test this patch. I debugged using
Netbeans and (other than not receiving any automatic Jabber notification
IMs from Jenkins) the code appeared to work as expected after adding the
null check.
Attached patch also submitted as a pull request.
The issue "Type" should probably be "Bug"; sorry about that.