Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-11443

"E-mail address as Jabber ID" doesn't work when user email is set but jabber ID is not

    XMLWordPrintable

Details

    Description

      null is being returned by getConfiguredIMId() when

      • user's jabber ID is not set
      • user's email is set
      • "E-mail address as Jabber ID" is enabled

      It should return the user's email address.

      Attachments

        Activity

          amonsen Adam Monsen added a comment -

          Attached patch also submitted as a pull request.

          The issue "Type" should probably be "Bug"; sorry about that.

          amonsen Adam Monsen added a comment - Attached patch also submitted as a pull request . The issue "Type" should probably be "Bug"; sorry about that.

          Code changed in jenkins
          User: Adam Monsen
          Path:
          src/main/java/hudson/plugins/jabber/im/transport/JabberPublisher.java
          http://jenkins-ci.org/commit/jabber-plugin/e88e473738dfe6f9ba77d2c3767736add12de9b8
          Log:
          [FIXED JENKINS-11443] E-mail address as Jabber ID config setting.

          null was being returned by getConfiguredIMId() when

          • user's jabber ID was not set
          • user's email WAS set
          • setting "E-mail address as Jabber ID" was enabled

          It should have been returning the user's email address.

          This patch fixes the configuration setting "E-mail address as Jabber ID"
          when the conditions described above are met. The setting can be found
          at /configure under "Advanced..." for the Jabber Notification plugin.

          During testing I didn't receive any messages from the Jenkins Jabber
          robot, but this was probably just a misconfiguration in my local testing
          environment. The bot did reply to me when I directly IM'ed "!status" or
          "!build test" or whatever, it just wouldn't send automatic
          notifications. I was using two different users on jabber.org, one was my
          real ID, another was made just to test this patch. I debugged using
          Netbeans and (other than not receiving any automatic Jabber notification
          IMs from Jenkins) the code appeared to work as expected after adding the
          null check.

          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Adam Monsen Path: src/main/java/hudson/plugins/jabber/im/transport/JabberPublisher.java http://jenkins-ci.org/commit/jabber-plugin/e88e473738dfe6f9ba77d2c3767736add12de9b8 Log: [FIXED JENKINS-11443] E-mail address as Jabber ID config setting. null was being returned by getConfiguredIMId() when user's jabber ID was not set user's email WAS set setting "E-mail address as Jabber ID" was enabled It should have been returning the user's email address. This patch fixes the configuration setting "E-mail address as Jabber ID" when the conditions described above are met. The setting can be found at /configure under "Advanced..." for the Jabber Notification plugin. During testing I didn't receive any messages from the Jenkins Jabber robot, but this was probably just a misconfiguration in my local testing environment. The bot did reply to me when I directly IM'ed "!status" or "!build test" or whatever, it just wouldn't send automatic notifications. I was using two different users on jabber.org, one was my real ID, another was made just to test this patch. I debugged using Netbeans and (other than not receiving any automatic Jabber notification IMs from Jenkins) the code appeared to work as expected after adding the null check.

          Code changed in jenkins
          User: Christoph Kutzinski
          Path:
          src/main/java/hudson/plugins/jabber/im/transport/JabberPublisher.java
          http://jenkins-ci.org/commit/jabber-plugin/3e3f92917629feda400c790da1ecadf5228711dd
          Log:
          Merge pull request #5 from meonkeys/master

          [FIXED JENKINS-11443] - E-mail address as Jabber ID config setting.

          Compare: https://github.com/jenkinsci/jabber-plugin/compare/5958a1f...3e3f929

          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Christoph Kutzinski Path: src/main/java/hudson/plugins/jabber/im/transport/JabberPublisher.java http://jenkins-ci.org/commit/jabber-plugin/3e3f92917629feda400c790da1ecadf5228711dd Log: Merge pull request #5 from meonkeys/master [FIXED JENKINS-11443] - E-mail address as Jabber ID config setting. Compare: https://github.com/jenkinsci/jabber-plugin/compare/5958a1f...3e3f929
          dogfood dogfood added a comment -

          Integrated in plugins_jabber #109
          [FIXED JENKINS-11443] E-mail address as Jabber ID config setting.

          haircut :
          Files :

          • src/main/java/hudson/plugins/jabber/im/transport/JabberPublisher.java
          dogfood dogfood added a comment - Integrated in plugins_jabber #109 [FIXED JENKINS-11443] E-mail address as Jabber ID config setting. haircut : Files : src/main/java/hudson/plugins/jabber/im/transport/JabberPublisher.java

          People

            kutzi kutzi
            amonsen Adam Monsen
            Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: