Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-11569

FS trigger looking at way way way way way too much on a job configuration change (or jenkins startup)

    XMLWordPrintable

Details

    Description

      I changed the job config to exclude a sub-tree from fs triggers search while a strace -f 2>&1 | grep open was running on the jenkins process

      I saw that it was
      1. calling open|DIR on every file in the tree,
      2. calling open|DIR even on files I had told it not to look at.

      e.g.

      FS trigger checked
      path "/view/foo/vobs/bar"
      include "*/.c */.h"
      excludes "understand/** */obj/*"

      every time I save the configuration it attempts the open on the bizillion supposedly excluded files
      in understand/udb_html/* and those in /obj/.o when it should not have looked at a single file in those sub-trees.
      as well as hundreds of non-included files (*/.project, etc)

      I think that whatever fileset like thing is under the hood of fstrigger is mis-used or poorly implemented

      It should
      1. not look for sub-dirs in excluded patterns
      2. not assume everything is a dir to be searched inside of

      Its almost as if its applying the include filter first, then reducing the results after the fact instead of applying the exclude filter as it considers each filesystem entry in the path.

      Attachments

        Activity

          Can I set the issue to 'Fixed'?

          gbois Gregory Boissinot added a comment - Can I set the issue to 'Fixed'?

          I'd still recommend updating the help for one or of the path/includes/excludes to have better examples.

          moncreaff Greg Moncreaff added a comment - I'd still recommend updating the help for one or of the path/includes/excludes to have better examples.

          Code changed in jenkins
          User: Gregory Boissinot
          Path:
          src/main/resources/org/jenkinsci/plugins/fstrigger/triggers/FolderContentTrigger/config.properties
          http://jenkins-ci.org/commit/fstrigger-plugin/70a45ed6caba72c4a1faf05c89e5cb39b40444dc
          Log:
          Fixed JENKINS-11569

          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Gregory Boissinot Path: src/main/resources/org/jenkinsci/plugins/fstrigger/triggers/FolderContentTrigger/config.properties http://jenkins-ci.org/commit/fstrigger-plugin/70a45ed6caba72c4a1faf05c89e5cb39b40444dc Log: Fixed JENKINS-11569

          Could you check the fix?
          Thanks

          gbois Gregory Boissinot added a comment - Could you check the fix? Thanks

          The fix is included in FSTrigger 0.17

          gbois Gregory Boissinot added a comment - The fix is included in FSTrigger 0.17

          People

            gbois Gregory Boissinot
            moncreaff Greg Moncreaff
            Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: