Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-16979

"Discard old builds" broken in 1.503

    XMLWordPrintable

Details

    • Bug
    • Status: Resolved (View Workflow)
    • Blocker
    • Resolution: Fixed
    • core
    • None

    Description

      I just upgraded from Jenkins 1.502 to 1.503. "Discard old builds" has been broken.

      When I go to the "Manage Jenkins" page, I see "You have data stored in an older format and/or unreadable data.", and clicking on "Manage" shows "InstantiationError: jenkins.model.BuildDiscarder" for most of my jobs. All my jobs that previously had "discard old builds" specified don’t have it ticked any more.

      I presume this is related to this changelog entry: "Discard old build records" behavior is now pluggable, allowing plugins to define custom logic.

      If I edit a job and tick "Discard Old Builds", previous values are not there, and there's some spurious text on the page "//x", presumably something that was intended to be removed when this was released.

      Attachments

        Issue Links

          Activity

            mwebber Matthew Webber added a comment - - edited

            It's not broken in 1.506 for me.

            Note that the basic capability to discard old builds is part of Jenkins core, and that was broken in 1.503 and fixed in 1.504. This Jira ticket is about that.

            In addition to the core functionality, there is a "Discard Old Build" plugin. DO you have that installed? Is that where the problem is? If so, you need to open a new ticket.

            mwebber Matthew Webber added a comment - - edited It's not broken in 1.506 for me. Note that the basic capability to discard old builds is part of Jenkins core, and that was broken in 1.503 and fixed in 1.504. This Jira ticket is about that. In addition to the core functionality, there is a "Discard Old Build" plugin. DO you have that installed? Is that where the problem is? If so, you need to open a new ticket.
            jglick Jesse Glick added a comment -

            @bedge: right, file a ticket for that plugin if you need to.

            jglick Jesse Glick added a comment - @bedge: right, file a ticket for that plugin if you need to.
            bedge Bruce Edge added a comment - Done, thanks. https://issues.jenkins-ci.org/browse/JENKINS-17528

            Code changed in jenkins
            User: Jesse Glick
            Path:
            test/src/test/groovy/jenkins/model/BuildDiscarderTest.groovy
            test/src/test/java/jenkins/model/BuildDiscarderPropertyTest.java
            test/src/test/resources/jenkins/model/BuildDiscarderPropertyTest/logRotatorField/config.xml
            test/src/test/resources/jenkins/model/BuildDiscarderPropertyTest/logRotatorField/jobs/foo/config.xml
            test/src/test/resources/jenkins/model/BuildDiscarderTest/compatibility/config.xml
            test/src/test/resources/jenkins/model/BuildDiscarderTest/compatibility/jobs/foo/config.xml
            http://jenkins-ci.org/commit/jenkins/2200711bf3dcd96263b3a88001a49f5b7241c264
            Log:
            JENKINS-16979 Migrated test from Groovy to Java for ease of maintenance.

            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Jesse Glick Path: test/src/test/groovy/jenkins/model/BuildDiscarderTest.groovy test/src/test/java/jenkins/model/BuildDiscarderPropertyTest.java test/src/test/resources/jenkins/model/BuildDiscarderPropertyTest/logRotatorField/config.xml test/src/test/resources/jenkins/model/BuildDiscarderPropertyTest/logRotatorField/jobs/foo/config.xml test/src/test/resources/jenkins/model/BuildDiscarderTest/compatibility/config.xml test/src/test/resources/jenkins/model/BuildDiscarderTest/compatibility/jobs/foo/config.xml http://jenkins-ci.org/commit/jenkins/2200711bf3dcd96263b3a88001a49f5b7241c264 Log: JENKINS-16979 Migrated test from Groovy to Java for ease of maintenance.
            dogfood dogfood added a comment -

            Integrated in jenkins_main_trunk #4367
            JENKINS-16979 Migrated test from Groovy to Java for ease of maintenance. (Revision 2200711bf3dcd96263b3a88001a49f5b7241c264)

            Result = UNSTABLE
            jesse glick : 2200711bf3dcd96263b3a88001a49f5b7241c264
            Files :

            • test/src/test/java/jenkins/model/BuildDiscarderPropertyTest.java
            • test/src/test/resources/jenkins/model/BuildDiscarderPropertyTest/logRotatorField/jobs/foo/config.xml
            • test/src/test/resources/jenkins/model/BuildDiscarderTest/compatibility/config.xml
            • test/src/test/resources/jenkins/model/BuildDiscarderPropertyTest/logRotatorField/config.xml
            • test/src/test/resources/jenkins/model/BuildDiscarderTest/compatibility/jobs/foo/config.xml
            • test/src/test/groovy/jenkins/model/BuildDiscarderTest.groovy
            dogfood dogfood added a comment - Integrated in jenkins_main_trunk #4367 JENKINS-16979 Migrated test from Groovy to Java for ease of maintenance. (Revision 2200711bf3dcd96263b3a88001a49f5b7241c264) Result = UNSTABLE jesse glick : 2200711bf3dcd96263b3a88001a49f5b7241c264 Files : test/src/test/java/jenkins/model/BuildDiscarderPropertyTest.java test/src/test/resources/jenkins/model/BuildDiscarderPropertyTest/logRotatorField/jobs/foo/config.xml test/src/test/resources/jenkins/model/BuildDiscarderTest/compatibility/config.xml test/src/test/resources/jenkins/model/BuildDiscarderPropertyTest/logRotatorField/config.xml test/src/test/resources/jenkins/model/BuildDiscarderTest/compatibility/jobs/foo/config.xml test/src/test/groovy/jenkins/model/BuildDiscarderTest.groovy

            People

              kohsuke Kohsuke Kawaguchi
              mwebber Matthew Webber
              Votes:
              12 Vote for this issue
              Watchers:
              20 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: