-
Type:
Improvement
-
Resolution: Fixed
-
Priority:
Critical
-
Component/s: view-job-filters-plugin
-
None
parameter filter can only filter by StringParameterValue, BooleanParameterValue and FileParameterValue. So we can't filter by custom parameters.
I can't understand why can't we change ParameterFilter class getStringValue function to something like this:
protected String getStringValue(ParameterValue value) {
if (value instanceof StringParameterValue) {
return ((StringParameterValue) value).value;
} else if (value instanceof BooleanParameterValue) {
boolean bval = ((BooleanParameterValue) value).value;
return String.valueOf(bval);
} else if (value instanceof FileParameterValue) {
// not the full path - just the name
// this is the only public value available to us
String file = ((FileParameterValue) value).getOriginalFileName();
return file;
} else {
return value.toString();
}
}
mine difference is return value.toString(); not return null;
