Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-22710

Broken Debian upgrades because postinst doesn't check for present group/user

    XMLWordPrintable

Details

    Description

      Package upgrade from 1.559 to 1.560 on Debian systems fails with:

      dpkg: error processing jenkins (--configure):
      subprocess installed post-installation script returned error exit status 1

      due to the:

      addgroup --system --quiet jenkins

      call in postinst without checking whether corresponding group already exists.

      Problem introduced as of:

      commit 7216aab0d3f7215be7d71109936ad4b3aa0a583b
      Author: Peter Eisentraut <peter@eisentraut.org>
      Date: Sun Nov 3 08:12:17 2013 -0500
      debian: Use a configurable group for the Jenkins user
      Typical Debian practice is to have one equally-named group per system
      user. Make that for the jenkins user by default, but allow it to be
      overridden in /etc/default/jenkins, same as for the user name.

      This change also deleted the check for the existing Jenkins user (for whatever reason, but that's also broken).

      I'm working on a fix/PR right now.

      Attachments

        Activity

          danielbeck Daniel Beck added a comment -

          Sorry about that. As you can now see from the changelog (upcoming changes), this'll only be fixed in 1.562.

          danielbeck Daniel Beck added a comment - Sorry about that. As you can now see from the changelog (upcoming changes), this'll only be fixed in 1.562.
          madsnielsen Mads Nielsen added a comment -

          Still happening in 1.562:
          Ubutu 14.04 runnning in Virtualbox.

          dpkg: error processing package jenkins (--configure):
          subprocess installed post-installation script returned error exit status 1

          madsnielsen Mads Nielsen added a comment - Still happening in 1.562: Ubutu 14.04 runnning in Virtualbox. dpkg: error processing package jenkins (--configure): subprocess installed post-installation script returned error exit status 1

          Getting this with 1.563 in Ubuntu 14.04 LTS.

          aje Andrew Erickson added a comment - Getting this with 1.563 in Ubuntu 14.04 LTS.

          Getting this with 1.564 in Lubuntu 14.04 LTS.

          brendanh Brendan Holmes added a comment - Getting this with 1.564 in Lubuntu 14.04 LTS.

          Code changed in jenkins
          User: Michael Prokop
          Path:
          debian/jenkins.postinst
          http://jenkins-ci.org/commit/packaging/a1dad64020887cb53ab1ec6ca2d5077d4061786e
          Log:
          Debian postinst: check for present user/group before adding them

          In git commit 7216aab0d the check for present user was removed
          and therefore upgrading the Debian package on existing Jenkins
          installations fails. Also the newly added code for adding a
          configurable Jenkins group is missing a check for a possibly
          already present Jenkins group.

          Closes: JENKINS-22710

          Originally-From: jenkins-ci.org/commit/core/1b706c194a44a4b49b6d8260fc8ded0a3f9fca06

          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Michael Prokop Path: debian/jenkins.postinst http://jenkins-ci.org/commit/packaging/a1dad64020887cb53ab1ec6ca2d5077d4061786e Log: Debian postinst: check for present user/group before adding them In git commit 7216aab0d the check for present user was removed and therefore upgrading the Debian package on existing Jenkins installations fails. Also the newly added code for adding a configurable Jenkins group is missing a check for a possibly already present Jenkins group. Closes: JENKINS-22710 Originally-From: jenkins-ci.org/commit/core/1b706c194a44a4b49b6d8260fc8ded0a3f9fca06

          People

            Unassigned Unassigned
            mika Michael Prokop
            Votes:
            3 Vote for this issue
            Watchers:
            10 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: