Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-24261

Assembla browser breaks config page

    XMLWordPrintable

Details

    Description

      It seems that some commits or files were missing from the 2.2.4 release plugin,

      https://github.com/jenkinsci/git-plugin/tree/git-2.2.4/src/main/resources/hudson/plugins/git/browser

      is missing Assembla - but it is a valid browser.
      This is fixed in master:
      https://github.com/jenkinsci/git-plugin/tree/master/src/main/resources/hudson/plugins/git/browser/AssemblaWeb

      but I thought it was important enough to warrant a bug.

      b/hudson/listScmBrowsers.jelly:42:77: <st:include> No page found 'config.jelly' for class hudson.plugins.g
it.browser.AssemblaWeb$ASSEMBLAWEBDescriptor
      ...
      org.apache.commons.jelly.JellyTagException: jar:file:/opt/jenkins/jenkins-wars/a
../WEB-INF/lib/jenkins-core../li
b/hudson/listScmBrowsers.jelly:42:77: <st:include> No page found 'config.jelly' for class hudson.plugins.g
it.browser.AssemblaWeb$ASSEMBLAWEBDescriptor

      Attachments

        Activity

          markewaite Mark Waite added a comment -

          Thanks for the report. The pull request that introduced Assembla (this commit and this commit) missed a few files. I obviously didn't test it well enough (shame on me). The author corrected the mistake, but it was after the release of the 2.2.4 version of the plugin. It will be fixed in the 2.2.5 version of the plugin.

          The commit which fixed it has been on github for almost two weeks (on both the master branch and the 2.2.x branch).

          I'll release 2.2.5 within the next few days to fix that problem.

          markewaite Mark Waite added a comment - Thanks for the report. The pull request that introduced Assembla ( this commit and this commit ) missed a few files. I obviously didn't test it well enough (shame on me). The author corrected the mistake, but it was after the release of the 2.2.4 version of the plugin. It will be fixed in the 2.2.5 version of the plugin. The commit which fixed it has been on github for almost two weeks (on both the master branch and the 2.2.x branch). I'll release 2.2.5 within the next few days to fix that problem.
          markewaite Mark Waite added a comment -

          Fixed in git client plugin 2.2.5 released 15 Aug 2014

          markewaite Mark Waite added a comment - Fixed in git client plugin 2.2.5 released 15 Aug 2014
          michaelneale Michael Neale added a comment -

          Thanks Mark - yes I assumed it was tiny mistake. Given enough users we see all bugs like that if it is likely to happen again - could a reflection based test look for the occurrence of appropriately named resources along with the classes? (if it is unlikely to happen again, don't bother).

          michaelneale Michael Neale added a comment - Thanks Mark - yes I assumed it was tiny mistake. Given enough users we see all bugs like that if it is likely to happen again - could a reflection based test look for the occurrence of appropriately named resources along with the classes? (if it is unlikely to happen again, don't bother).
          markewaite Mark Waite added a comment -

          I hope to eventually write a test which iterates through each of the extensions to the plugin, uses that instead in a config round trip test, and confirms that the extension correctly survives a config round trip. The existing round trip test does not enable any extensions, so it missed this test.

          So much to test, so little time...

          markewaite Mark Waite added a comment - I hope to eventually write a test which iterates through each of the extensions to the plugin, uses that instead in a config round trip test, and confirms that the extension correctly survives a config round trip. The existing round trip test does not enable any extensions, so it missed this test. So much to test, so little time...

          People

            markewaite Mark Waite
            michaelneale Michael Neale
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: