Details
-
Improvement
-
Status: Closed (View Workflow)
-
Critical
-
Resolution: Fixed
-
None
Description
If using MultiScm plugin, every git repository must be named explicitly in the "Name" field for the repository configuration in the job.
The name must be job-wide unique.
If using the ordinary git plugin, without MultiScm pluging we allow un-named repositories, as these will be implicitly named by the git plugin.
Code changed in jenkins
User: Mads Nielsen
Path:
src/main/java/org/jenkinsci/plugins/pretestedintegration/AbstractSCMBridge.java
src/main/java/org/jenkinsci/plugins/pretestedintegration/IntegrationStrategy.java
src/main/java/org/jenkinsci/plugins/pretestedintegration/PretestedIntegrationAction.java
src/main/java/org/jenkinsci/plugins/pretestedintegration/PretestedIntegrationBuildWrapper.java
src/main/java/org/jenkinsci/plugins/pretestedintegration/exceptions/NextCommitFailureException.java
src/main/java/org/jenkinsci/plugins/pretestedintegration/exceptions/UnsupportedConfigurationException.java
src/main/java/org/jenkinsci/plugins/pretestedintegration/scm/git/AccumulatedCommitStrategy.java
src/main/java/org/jenkinsci/plugins/pretestedintegration/scm/git/GitBridge.java
src/main/java/org/jenkinsci/plugins/pretestedintegration/scm/git/SquashCommitStrategy.java
src/main/resources/org/jenkinsci/plugins/pretestedintegration/scm/git/GitBridge/help-branch.html
src/main/resources/org/jenkinsci/plugins/pretestedintegration/scm/git/GitBridge/help-repoName.html
src/test/java/org/jenkinsci/plugins/pretestedintegration/integration/scm/git/AccumulatedCommitStrategyIT.java
src/test/java/org/jenkinsci/plugins/pretestedintegration/integration/scm/git/DoNotAllowMasterBranchAsReadyBranch.java
src/test/java/org/jenkinsci/plugins/pretestedintegration/integration/scm/git/GeneralBehaviourIT.java
src/test/java/org/jenkinsci/plugins/pretestedintegration/integration/scm/git/JENKINS_24754_IT.java
src/test/java/org/jenkinsci/plugins/pretestedintegration/integration/scm/git/JENKINS_25546_IT.java
src/test/java/org/jenkinsci/plugins/pretestedintegration/integration/scm/git/MultipleScmIT.java
src/test/java/org/jenkinsci/plugins/pretestedintegration/integration/scm/git/SquashCommitStrategyIT.java
src/test/java/org/jenkinsci/plugins/pretestedintegration/integration/scm/git/TestUtilsFactory.java
src/test/java/org/jenkinsci/plugins/pretestedintegration/integration/scm/git/TwoBranchHeadsIT.java
src/test/java/org/jenkinsci/plugins/pretestedintegration/integration/scm/git/UniqueBranchGenerator.java
src/test/java/org/jenkinsci/plugins/pretestedintegration/unit/AbstractSCMBridgeTest.java
src/test/java/org/jenkinsci/plugins/pretestedintegration/unit/CommitTest.java
src/test/java/org/jenkinsci/plugins/pretestedintegration/unit/DummyCommit.java
src/test/java/org/jenkinsci/plugins/pretestedintegration/unit/DummyIntegrationStrategy.java
src/test/java/org/jenkinsci/plugins/pretestedintegration/unit/PretestedIntegrationActionTest.java
http://jenkins-ci.org/commit/pretested-integration-plugin/703a6ca9f17a2e02b268306ac7a69a936841ae8e
Log:
JENKINS-25886: Job config and build data selection:Refactoring and implemented job configuration check to ensure explicit
named remotes if using MultiScm plugin.
Refactoring and improvements:
if identical, ambiguity is avoided and reported as failure
configuration.