Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-2699

Add legacy SSL support and alternate nickname for group-chat

    XMLWordPrintable

Details

    • Patch
    • Status: Closed (View Workflow)
    • Major
    • Resolution: Fixed
    • jabber-plugin
    • None
    • Platform: All, OS: All

    Description

      See attached patch.. adds 2 new config items in the global settings.

      2 additional one-line changes in these diffs:

      • JabberPublisherDescriptor.java constructor: changed catch from IMException to
        Exception.. I was getting IllegalArgumentException due to null "host" setting,
        and this caused the whole jabber plugin to fail initialization and not show up
        in Hudson at all.
      • global.jelly: removed ${rootURL} from the "base" setting.. in my test
        environment I use server:port/hudson to access hudson (sun java system web
        server 7), but the help items in global settings were getting
        /hudson/hudson/plugin/jabber/*.html, so I removed ${rootURL} and those started
        working.

      The rest of the diffs are for the 2 new config settings. When legacySSL
      checkbox is checked then JabberIMConnection simply uses "new SSLXMPPConnection"
      instead of "new XMPPConnection".. the underlying Smack library already had this
      support for legacy SSL, just needed a way to make use of it.
      The other new setting is an optional alternate nickname to use in group chats..
      if blank, it defaults to the original behavior of using your jabber id.

      Thanks for this plugin, hope this patch will be useful!

      Attachments

        Activity

          mindless Alan Harder added a comment -

          Created an attachment (id=457)
          Jabber legacy-SSL/group-nick patch

          mindless Alan Harder added a comment - Created an attachment (id=457) Jabber legacy-SSL/group-nick patch
          mindless Alan Harder added a comment -

          attached patch is relative to: hudson/plugins/jabber/src/main

          mindless Alan Harder added a comment - attached patch is relative to: hudson/plugins/jabber/src/main
          vsellier vsellier added a comment -

          Thanks for the patch I will apply it for 0.7 version

          vsellier vsellier added a comment - Thanks for the patch I will apply it for 0.7 version
          vsellier vsellier added a comment -

          change status

          vsellier vsellier added a comment - change status
          mindless Alan Harder added a comment -

          Great, thanks!

          Here's one more tiny change:
          In the this.connection.login() call in JabberIMConnection.java, add a 3rd
          parameter to that call with value: "Hudson"
          This overrides the default value of "Smack" the smack library uses.. if your
          connection exposes presence then it is nice to see "Hudson" in the details. For
          example, in my Pidgin client when I look at my status I see:
          Status (Home): Available
          Status (Hudson): Do Not Disturb: I'm busy building your software...

          mindless Alan Harder added a comment - Great, thanks! Here's one more tiny change: In the this.connection.login() call in JabberIMConnection.java, add a 3rd parameter to that call with value: "Hudson" This overrides the default value of "Smack" the smack library uses.. if your connection exposes presence then it is nice to see "Hudson" in the details. For example, in my Pidgin client when I look at my status I see: Status (Home): Available Status (Hudson): Do Not Disturb: I'm busy building your software...
          vsellier vsellier added a comment -

          patchs are commited

          vsellier vsellier added a comment - patchs are commited

          People

            vsellier vsellier
            mindless Alan Harder
            Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: