Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-27938

Unable to expand collapsed SLIM tables

    XMLWordPrintable

Details

    • Bug
    • Status: Closed (View Workflow)
    • Minor
    • Resolution: Fixed
    • fitnesse-plugin
    • None
    • FitNesse plugin 1.12
      Jenkins 1.600

    Description

      New styling added in the latest FitNesse plugin makes SLIM tables appear as collapsed inside captured details, however there is no way to expand them.
      It seems like FitNesse plugin is missing some essential java-script to allow those tables behave same way they do in FitNesse. Another option is that java-script is included but unable to interact with elements inside Jenkins page.

      Attachments

        Activity

          markgargan Mark Gargan added a comment -

          In jenkins-fitnesse.js I think you just need to replace

          .on("touchstart click", "#fitnesse_results .collapsible > p.title, #fitnesse_results .scenario > td", function ()

          { $(this).parent().toggleClass('closed'); })
          .on("click", "#fitnesse_results .collapsible > p.title a", function (event) { // Do not open section when clicking on a link in the title, just follow the link. event.stopPropagation(); return true; })

          with the scenario handling from fitnesse.js

          .on("touchstart click", "#fitnesse_results .collapsible > p.title, #fitnesse_results .scenario > td", function () { $(this).parent().toggleClass('closed'); }

          )
          .on("click", "#fitnesse_results tr.scenario td, #fitnesse_results tr.exception td", function ()

          { $(this).parent().toggleClass('closed').nextUntil(":not(.exception-detail, .scenario-detail)").toggleClass("closed-detail"); }

          )
          .on("click", "#fitnesse_results .collapsible > p.title a", function (event)

          { // Do not open section when clicking on a link in the title, just follow the link. event.stopPropagation(); return true; }

          )

          markgargan Mark Gargan added a comment - In jenkins-fitnesse.js I think you just need to replace .on("touchstart click", "#fitnesse_results .collapsible > p.title, #fitnesse_results .scenario > td", function () { $(this).parent().toggleClass('closed'); }) .on("click", "#fitnesse_results .collapsible > p.title a", function (event) { // Do not open section when clicking on a link in the title, just follow the link. event.stopPropagation(); return true; }) with the scenario handling from fitnesse.js .on("touchstart click", "#fitnesse_results .collapsible > p.title, #fitnesse_results .scenario > td", function () { $(this).parent().toggleClass('closed'); } ) .on("click", "#fitnesse_results tr.scenario td, #fitnesse_results tr.exception td", function () { $(this).parent().toggleClass('closed').nextUntil(":not(.exception-detail, .scenario-detail)").toggleClass("closed-detail"); } ) .on("click", "#fitnesse_results .collapsible > p.title a", function (event) { // Do not open section when clicking on a link in the title, just follow the link. event.stopPropagation(); return true; } )

          Hi Serge,
          Could you please send me your HTML page, I will test the Mark's recommendation.
          Do you use FitNesse scenario ?
          Regards,
          Antoine

          antoine_aumjaud Antoine Aumjaud added a comment - Hi Serge, Could you please send me your HTML page, I will test the Mark's recommendation. Do you use FitNesse scenario ? Regards, Antoine
          sergebug Serge Zukov added a comment -

          You won't need my page to reproduce it: FitNesse.SuiteAcceptanceTests.SuiteSlimTests.ChainWithInstanceTest
          In captured test results "do something with" will not be expandable.
          Yes, you are right - the issue affects collapsed scenarios. Does not affect collapsed page sections.

          sergebug Serge Zukov added a comment - You won't need my page to reproduce it: FitNesse.SuiteAcceptanceTests.SuiteSlimTests.ChainWithInstanceTest In captured test results "do something with" will not be expandable. Yes, you are right - the issue affects collapsed scenarios. Does not affect collapsed page sections.

          Code changed in jenkins
          User: antoine-aumjaud
          Path:
          src/main/webapp/javascript/jenkins_fitnesse.js
          http://jenkins-ci.org/commit/fitnesse-plugin/9143adcbf5f30ad15fd558c1ba07c9b9c275bfad
          Log:
          JENKINS-27938 Fix JS: can't expand collapsed scenario

          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: antoine-aumjaud Path: src/main/webapp/javascript/jenkins_fitnesse.js http://jenkins-ci.org/commit/fitnesse-plugin/9143adcbf5f30ad15fd558c1ba07c9b9c275bfad Log: JENKINS-27938 Fix JS: can't expand collapsed scenario
          denniebouman Dennie Bouman added a comment -

          Great work Antoine!
          Unfortunately i am not able to test your fix, I get some kind of "unsupported OS" Error, while building it locally.
          Will there be an official release soon?

          Cheers,

          Dennie

          denniebouman Dennie Bouman added a comment - Great work Antoine! Unfortunately i am not able to test your fix, I get some kind of "unsupported OS" Error, while building it locally. Will there be an official release soon? Cheers, Dennie

          fixed in version 1.13

          antoine_aumjaud Antoine Aumjaud added a comment - fixed in version 1.13

          People

            antoine_aumjaud Antoine Aumjaud
            sergebug Serge Zukov
            Votes:
            3 Vote for this issue
            Watchers:
            6 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: