Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-30000

Refactor Texas Instruments Parser (Part one) (Praqma case 13215)

    XMLWordPrintable

    Details

    • Similar Issues:

      Description

      We'll move the TI parser to a subpackage just to keep the codebase clean.

      The first step is creating a copy of the parser in the subpackage, deprecating the old one and replacing the old one with the new one when the user updates the plugin.

      The second step is removing the old parser in a later release.

      This is the issue for the first step.

      Step 1: https://issues.jenkins-ci.org/browse/JENKINS-30000 / our case 13215
      Step 2: https://issues.jenkins-ci.org/browse/JENKINS-30001 / our case 13414

        Attachments

          Activity

          Hide
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Thierry Lacour
          Path:
          src/main/java/net/praqma/jenkins/memorymap/MemoryMapRecorder.java
          src/main/java/net/praqma/jenkins/memorymap/parser/TexasInstrumentsMemoryMapParser.java
          src/main/java/net/praqma/jenkins/memorymap/parser/ti/TexasInstrumentsMemoryMapParser.java
          http://jenkins-ci.org/commit/memory-map-plugin/c5f48d09479bf4041932bbe5120af0de061badd8
          Log:
          JENKINS-30000 (Refactor TI parser)

          Show
          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Thierry Lacour Path: src/main/java/net/praqma/jenkins/memorymap/MemoryMapRecorder.java src/main/java/net/praqma/jenkins/memorymap/parser/TexasInstrumentsMemoryMapParser.java src/main/java/net/praqma/jenkins/memorymap/parser/ti/TexasInstrumentsMemoryMapParser.java http://jenkins-ci.org/commit/memory-map-plugin/c5f48d09479bf4041932bbe5120af0de061badd8 Log: JENKINS-30000 (Refactor TI parser)
          Hide
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Thierry Lacour
          Path:
          .gitignore
          README.md
          check_for_changelog.rb
          pom.xml
          src/main/java/net/praqma/jenkins/memorymap/MemoryMapBuildAction.java
          src/main/java/net/praqma/jenkins/memorymap/MemoryMapDslExtension.java
          src/main/java/net/praqma/jenkins/memorymap/MemoryMapGraphDslContext.java
          src/main/java/net/praqma/jenkins/memorymap/MemoryMapJobDslContext.java
          src/main/java/net/praqma/jenkins/memorymap/MemoryMapParserDslContext.java
          src/main/java/net/praqma/jenkins/memorymap/MemoryMapProjectAction.java
          src/main/java/net/praqma/jenkins/memorymap/MemoryMapRecorder.java
          src/main/java/net/praqma/jenkins/memorymap/graph/MemoryMapGraphConfiguration.java
          src/main/java/net/praqma/jenkins/memorymap/graph/MemoryMapGraphConfigurationDescriptor.java
          src/main/java/net/praqma/jenkins/memorymap/parser/AbstractMemoryMapParser.java
          src/main/java/net/praqma/jenkins/memorymap/parser/GccMemoryMapParser.java
          src/main/java/net/praqma/jenkins/memorymap/parser/KeilMemoryMapParser.java
          src/main/java/net/praqma/jenkins/memorymap/parser/MemoryMapConfigFileParserDelegate.java
          src/main/java/net/praqma/jenkins/memorymap/parser/MemoryMapMapParserDelegate.java
          src/main/java/net/praqma/jenkins/memorymap/parser/MemoryMapParsable.java
          src/main/java/net/praqma/jenkins/memorymap/parser/MemoryMapParserDescriptor.java
          src/main/java/net/praqma/jenkins/memorymap/parser/TexasInstrumentsMemoryMapParser.java
          src/main/java/net/praqma/jenkins/memorymap/parser/gcc/GccMemoryMapParser.java
          src/main/java/net/praqma/jenkins/memorymap/parser/ti/TexasInstrumentsMemoryMapParser.java
          src/main/java/net/praqma/jenkins/memorymap/result/MemoryMapConfigMemory.java
          src/main/java/net/praqma/jenkins/memorymap/result/MemoryMapConfigMemoryItem.java
          src/main/java/net/praqma/jenkins/memorymap/result/MemoryMapGroup.java
          src/main/java/net/praqma/jenkins/memorymap/result/MemoryMapParsingResult.java
          src/main/java/net/praqma/jenkins/memorymap/util/FileFoundable.java
          src/main/java/net/praqma/jenkins/memorymap/util/HexUtils.java
          src/main/java/net/praqma/jenkins/memorymap/util/MemoryMapError.java
          src/main/java/net/praqma/jenkins/memorymap/util/MemoryMapFileNotFoundError.java
          src/main/java/net/praqma/jenkins/memorymap/util/MemoryMapMemorySelectionError.java
          src/main/resources/net/praqma/jenkins/memorymap/MemoryMapProjectAction/floatingBox.jelly
          src/main/resources/net/praqma/jenkins/memorymap/MemoryMapProjectAction/index.jelly
          src/main/resources/net/praqma/jenkins/memorymap/MemoryMapRecorder/config.jelly
          src/main/resources/net/praqma/jenkins/memorymap/MemoryMapRecorder/help-chosenParser.html
          src/main/resources/net/praqma/jenkins/memorymap/MemoryMapRecorder/help-graphConfiguration.html
          src/main/resources/net/praqma/jenkins/memorymap/MemoryMapRecorder/help-scale.html
          src/main/resources/net/praqma/jenkins/memorymap/MemoryMapRecorder/help-showBytesOnGraph.html
          src/main/resources/net/praqma/jenkins/memorymap/MemoryMapRecorder/help-wordSize.html
          src/main/resources/net/praqma/jenkins/memorymap/graph/MemoryMapGraphConfiguration/config.jelly
          src/main/resources/net/praqma/jenkins/memorymap/graph/MemoryMapGraphConfiguration/help-graphCaption.html
          src/main/resources/net/praqma/jenkins/memorymap/graph/MemoryMapGraphConfiguration/help-graphDataList.html
          src/main/resources/net/praqma/jenkins/memorymap/parser/AbstractMemoryMapParser/config.jelly
          src/main/resources/net/praqma/jenkins/memorymap/parser/AbstractMemoryMapParser/help-configurationFile.html
          src/main/resources/net/praqma/jenkins/memorymap/parser/AbstractMemoryMapParser/help-mapFile.html
          src/main/resources/net/praqma/jenkins/memorymap/parser/AbstractMemoryMapParser/help-parserUniqueName.html
          src/main/resources/net/praqma/jenkins/memorymap/parser/GccMemoryMapParser/config.jelly
          src/main/resources/net/praqma/jenkins/memorymap/parser/KeilMemoryMapParser/config.jelly
          src/main/resources/net/praqma/jenkins/memorymap/parser/TexasInstrumentsMemoryMapParser/config.jelly
          src/main/resources/net/praqma/jenkins/memorymap/parser/gcc/GccMemoryMapParser/config.jelly
          src/main/resources/net/praqma/jenkins/ti/28069_RAM_lnk.cmd
          src/main/resources/net/praqma/jenkins/ti/TexasInstrumentsMapFile.txt
          src/test/java/net/praqma/jenkins/integration/GccMemoryMapParserIT.java
          src/test/java/net/praqma/jenkins/integration/JENKINS_29052_IT.java
          src/test/java/net/praqma/jenkins/integration/MemoryMapBuildActionTest.java
          src/test/java/net/praqma/jenkins/integration/TestUtils.java
          src/test/java/net/praqma/jenkins/integration/TexasInstrumentsMemoryMapParserIT.java
          src/test/java/net/praqma/jenkins/ti/TexasInstrumentsMemoryMapParserTest.java
          src/test/java/net/praqma/jenkins/unit/HexUtilsTest.java
          src/test/java/net/praqma/jenkins/unit/MemomoryMapProjectActionSimpleTest.java
          src/test/java/net/praqma/jenkins/unit/MemoryMapBuildActionSimpleTest.java
          src/test/java/net/praqma/jenkins/unit/MemoryMapGccParserTest.java
          src/test/java/net/praqma/jenkins/unit/MemoryMapParserDelegateTest.java
          src/test/java/net/praqma/jenkins/unit/MemoryMapParsingResultTest.java
          src/test/java/net/praqma/jenkins/unit/MemoryMapProjectActionSimpleTest.java
          src/test/resources/net/praqma/jenkins/integration/gcc432.zip
          src/test/resources/net/praqma/jenkins/integration/gcc482.zip
          src/test/resources/net/praqma/jenkins/integration/ti.zip
          src/test/resources/net/praqma/jenkins/unit/prom.ld
          src/test/resources/net/praqma/jenkins/unit/prom.map
          http://jenkins-ci.org/commit/memory-map-plugin/144e8e793178593484e228f4a5d2010f3bac0e17
          Log:
          Squashed commit of the following:

          commit 80dc7ba0e677badc9fee3fbb29a554bb25758694
          Author: Thierry Lacour <thi@praqma.net>
          Date: Wed Sep 9 10:19:28 2015 +0200

          Cleaned up DSL

          commit 7b0caf3f787433babb97d267a3dce19c47c503ca
          Author: Thierry Lacour <thi@praqma.net>
          Date: Fri Aug 28 12:04:58 2015 +0200

          Made the DSL implementation follow conventions

          commit 3c5490f91c67eae537abb4400d5f3fdc7da74e1d
          Author: Thierry Lacour <thi@praqma.net>
          Date: Thu Aug 27 10:35:27 2015 +0200

          Added DSL support prototype

          commit c5f48d09479bf4041932bbe5120af0de061badd8
          Author: Thierry Lacour <thi@praqma.net>
          Date: Tue Aug 18 10:43:51 2015 +0200

          JENKINS-30000 (Refactor TI parser)

          commit 5eeaed1bacc77263f2d51f1c1b6d108a671c532b
          Author: Thierry Lacour <thi@praqma.net>
          Date: Mon Aug 17 11:48:21 2015 +0200

          Fixed JENKINS-29052

          commit 1647bd4daece1a993cd0d8d2e01a29b369f87e33
          Author: Mads Nielsen <man@praqma.net>
          Date: Mon Aug 10 14:00:34 2015 +0200

          JENKINS-29804 Add clearer error message when invalid memory length is parsed.

          commit abb0de1466a15948eabbd3b87cb14432f8569108
          Author: Jan Krag <jak@praqma.net>
          Date: Mon Aug 10 11:55:36 2015 +0200

          JENKINS-29804 Strip C-style block comments from memory config files before parsing

          commit c60193ed1abfbfccb0f53cddb8c759cee80d7b0e
          Author: Mads Nielsen <man@praqma.net>
          Date: Wed Aug 5 09:59:04 2015 +0200

          Removed the parser mixin

          I have removed the code for an expeeriment i made, which made it possible for users to define their own parser in a groovy script field, interpreted at runtime. It works...but i don't think anyone will use it. It accidently got mixed into the 2.0 release train. So this commit should revert that.

          It was a proposed solution for people who needed to calculate certain values, which could not be read directly from the map file.

          commit b0dca849727d61d5dc87d25d50a1dbdaec70ef9f
          Author: Thierry Lacour <thi@praqma.net>
          Date: Mon Aug 3 16:26:59 2015 +0200

          Renamed test to reference its case, JENKINS-29052

          commit dec11e40d7210baa20fa8b66dc7d07cf9149b94f
          Author: Thierry Lacour <thi@praqma.net>
          Date: Mon Aug 3 16:06:54 2015 +0200

          Added a test for graphless parsers causing build failures

          commit 9742d921a9232fa5ce6c86db60229b40a91c4783
          Author: thi <thi@praqma.net>
          Date: Tue Jul 7 13:36:55 2015 +0200

          JENKINS-19841

          New features:
          Added support for GCC 4.8.2/4.3.2

          Improvements:
          Developed test tools to make the writing of tests easier
          Improved and expanded upon existing tests through the use of mentioned test tools
          Tests using the mentioned test tools now run on slaves
          Made plugin configuration more flexible, e.g. allowing multiple parsers
          Improved the README, including some developer oriented documentation
          Minor formatting and refactoring in various classes

          commit 9fde3f20346dca64ebfeb217e6641342cf1dc0ae
          Author: Bue Petersen <bue@praqma.net>
          Date: Thu Jul 2 11:20:28 2015 +0200

          Bumped to version 2.1.0 - think there once was a 2.0 out somewhere.

          Show
          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Thierry Lacour Path: .gitignore README.md check_for_changelog.rb pom.xml src/main/java/net/praqma/jenkins/memorymap/MemoryMapBuildAction.java src/main/java/net/praqma/jenkins/memorymap/MemoryMapDslExtension.java src/main/java/net/praqma/jenkins/memorymap/MemoryMapGraphDslContext.java src/main/java/net/praqma/jenkins/memorymap/MemoryMapJobDslContext.java src/main/java/net/praqma/jenkins/memorymap/MemoryMapParserDslContext.java src/main/java/net/praqma/jenkins/memorymap/MemoryMapProjectAction.java src/main/java/net/praqma/jenkins/memorymap/MemoryMapRecorder.java src/main/java/net/praqma/jenkins/memorymap/graph/MemoryMapGraphConfiguration.java src/main/java/net/praqma/jenkins/memorymap/graph/MemoryMapGraphConfigurationDescriptor.java src/main/java/net/praqma/jenkins/memorymap/parser/AbstractMemoryMapParser.java src/main/java/net/praqma/jenkins/memorymap/parser/GccMemoryMapParser.java src/main/java/net/praqma/jenkins/memorymap/parser/KeilMemoryMapParser.java src/main/java/net/praqma/jenkins/memorymap/parser/MemoryMapConfigFileParserDelegate.java src/main/java/net/praqma/jenkins/memorymap/parser/MemoryMapMapParserDelegate.java src/main/java/net/praqma/jenkins/memorymap/parser/MemoryMapParsable.java src/main/java/net/praqma/jenkins/memorymap/parser/MemoryMapParserDescriptor.java src/main/java/net/praqma/jenkins/memorymap/parser/TexasInstrumentsMemoryMapParser.java src/main/java/net/praqma/jenkins/memorymap/parser/gcc/GccMemoryMapParser.java src/main/java/net/praqma/jenkins/memorymap/parser/ti/TexasInstrumentsMemoryMapParser.java src/main/java/net/praqma/jenkins/memorymap/result/MemoryMapConfigMemory.java src/main/java/net/praqma/jenkins/memorymap/result/MemoryMapConfigMemoryItem.java src/main/java/net/praqma/jenkins/memorymap/result/MemoryMapGroup.java src/main/java/net/praqma/jenkins/memorymap/result/MemoryMapParsingResult.java src/main/java/net/praqma/jenkins/memorymap/util/FileFoundable.java src/main/java/net/praqma/jenkins/memorymap/util/HexUtils.java src/main/java/net/praqma/jenkins/memorymap/util/MemoryMapError.java src/main/java/net/praqma/jenkins/memorymap/util/MemoryMapFileNotFoundError.java src/main/java/net/praqma/jenkins/memorymap/util/MemoryMapMemorySelectionError.java src/main/resources/net/praqma/jenkins/memorymap/MemoryMapProjectAction/floatingBox.jelly src/main/resources/net/praqma/jenkins/memorymap/MemoryMapProjectAction/index.jelly src/main/resources/net/praqma/jenkins/memorymap/MemoryMapRecorder/config.jelly src/main/resources/net/praqma/jenkins/memorymap/MemoryMapRecorder/help-chosenParser.html src/main/resources/net/praqma/jenkins/memorymap/MemoryMapRecorder/help-graphConfiguration.html src/main/resources/net/praqma/jenkins/memorymap/MemoryMapRecorder/help-scale.html src/main/resources/net/praqma/jenkins/memorymap/MemoryMapRecorder/help-showBytesOnGraph.html src/main/resources/net/praqma/jenkins/memorymap/MemoryMapRecorder/help-wordSize.html src/main/resources/net/praqma/jenkins/memorymap/graph/MemoryMapGraphConfiguration/config.jelly src/main/resources/net/praqma/jenkins/memorymap/graph/MemoryMapGraphConfiguration/help-graphCaption.html src/main/resources/net/praqma/jenkins/memorymap/graph/MemoryMapGraphConfiguration/help-graphDataList.html src/main/resources/net/praqma/jenkins/memorymap/parser/AbstractMemoryMapParser/config.jelly src/main/resources/net/praqma/jenkins/memorymap/parser/AbstractMemoryMapParser/help-configurationFile.html src/main/resources/net/praqma/jenkins/memorymap/parser/AbstractMemoryMapParser/help-mapFile.html src/main/resources/net/praqma/jenkins/memorymap/parser/AbstractMemoryMapParser/help-parserUniqueName.html src/main/resources/net/praqma/jenkins/memorymap/parser/GccMemoryMapParser/config.jelly src/main/resources/net/praqma/jenkins/memorymap/parser/KeilMemoryMapParser/config.jelly src/main/resources/net/praqma/jenkins/memorymap/parser/TexasInstrumentsMemoryMapParser/config.jelly src/main/resources/net/praqma/jenkins/memorymap/parser/gcc/GccMemoryMapParser/config.jelly src/main/resources/net/praqma/jenkins/ti/28069_RAM_lnk.cmd src/main/resources/net/praqma/jenkins/ti/TexasInstrumentsMapFile.txt src/test/java/net/praqma/jenkins/integration/GccMemoryMapParserIT.java src/test/java/net/praqma/jenkins/integration/JENKINS_29052_IT.java src/test/java/net/praqma/jenkins/integration/MemoryMapBuildActionTest.java src/test/java/net/praqma/jenkins/integration/TestUtils.java src/test/java/net/praqma/jenkins/integration/TexasInstrumentsMemoryMapParserIT.java src/test/java/net/praqma/jenkins/ti/TexasInstrumentsMemoryMapParserTest.java src/test/java/net/praqma/jenkins/unit/HexUtilsTest.java src/test/java/net/praqma/jenkins/unit/MemomoryMapProjectActionSimpleTest.java src/test/java/net/praqma/jenkins/unit/MemoryMapBuildActionSimpleTest.java src/test/java/net/praqma/jenkins/unit/MemoryMapGccParserTest.java src/test/java/net/praqma/jenkins/unit/MemoryMapParserDelegateTest.java src/test/java/net/praqma/jenkins/unit/MemoryMapParsingResultTest.java src/test/java/net/praqma/jenkins/unit/MemoryMapProjectActionSimpleTest.java src/test/resources/net/praqma/jenkins/integration/gcc432.zip src/test/resources/net/praqma/jenkins/integration/gcc482.zip src/test/resources/net/praqma/jenkins/integration/ti.zip src/test/resources/net/praqma/jenkins/unit/prom.ld src/test/resources/net/praqma/jenkins/unit/prom.map http://jenkins-ci.org/commit/memory-map-plugin/144e8e793178593484e228f4a5d2010f3bac0e17 Log: Squashed commit of the following: commit 80dc7ba0e677badc9fee3fbb29a554bb25758694 Author: Thierry Lacour <thi@praqma.net> Date: Wed Sep 9 10:19:28 2015 +0200 Cleaned up DSL commit 7b0caf3f787433babb97d267a3dce19c47c503ca Author: Thierry Lacour <thi@praqma.net> Date: Fri Aug 28 12:04:58 2015 +0200 Made the DSL implementation follow conventions commit 3c5490f91c67eae537abb4400d5f3fdc7da74e1d Author: Thierry Lacour <thi@praqma.net> Date: Thu Aug 27 10:35:27 2015 +0200 Added DSL support prototype commit c5f48d09479bf4041932bbe5120af0de061badd8 Author: Thierry Lacour <thi@praqma.net> Date: Tue Aug 18 10:43:51 2015 +0200 JENKINS-30000 (Refactor TI parser) commit 5eeaed1bacc77263f2d51f1c1b6d108a671c532b Author: Thierry Lacour <thi@praqma.net> Date: Mon Aug 17 11:48:21 2015 +0200 Fixed JENKINS-29052 commit 1647bd4daece1a993cd0d8d2e01a29b369f87e33 Author: Mads Nielsen <man@praqma.net> Date: Mon Aug 10 14:00:34 2015 +0200 JENKINS-29804 Add clearer error message when invalid memory length is parsed. commit abb0de1466a15948eabbd3b87cb14432f8569108 Author: Jan Krag <jak@praqma.net> Date: Mon Aug 10 11:55:36 2015 +0200 JENKINS-29804 Strip C-style block comments from memory config files before parsing commit c60193ed1abfbfccb0f53cddb8c759cee80d7b0e Author: Mads Nielsen <man@praqma.net> Date: Wed Aug 5 09:59:04 2015 +0200 Removed the parser mixin I have removed the code for an expeeriment i made, which made it possible for users to define their own parser in a groovy script field, interpreted at runtime. It works...but i don't think anyone will use it. It accidently got mixed into the 2.0 release train. So this commit should revert that. It was a proposed solution for people who needed to calculate certain values, which could not be read directly from the map file. commit b0dca849727d61d5dc87d25d50a1dbdaec70ef9f Author: Thierry Lacour <thi@praqma.net> Date: Mon Aug 3 16:26:59 2015 +0200 Renamed test to reference its case, JENKINS-29052 commit dec11e40d7210baa20fa8b66dc7d07cf9149b94f Author: Thierry Lacour <thi@praqma.net> Date: Mon Aug 3 16:06:54 2015 +0200 Added a test for graphless parsers causing build failures commit 9742d921a9232fa5ce6c86db60229b40a91c4783 Author: thi <thi@praqma.net> Date: Tue Jul 7 13:36:55 2015 +0200 JENKINS-19841 New features: Added support for GCC 4.8.2/4.3.2 Improvements: Developed test tools to make the writing of tests easier Improved and expanded upon existing tests through the use of mentioned test tools Tests using the mentioned test tools now run on slaves Made plugin configuration more flexible, e.g. allowing multiple parsers Improved the README, including some developer oriented documentation Minor formatting and refactoring in various classes commit 9fde3f20346dca64ebfeb217e6641342cf1dc0ae Author: Bue Petersen <bue@praqma.net> Date: Thu Jul 2 11:20:28 2015 +0200 Bumped to version 2.1.0 - think there once was a 2.0 out somewhere.
          Hide
          thi Thierry Lacour added a comment -

          Resolved in v2.1.0

          Show
          thi Thierry Lacour added a comment - Resolved in v2.1.0

            People

            Assignee:
            praqma Praqma Support
            Reporter:
            thi Thierry Lacour
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved: