Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-30801

Re-triggering a failed build copies the Actions from previous builds

    XMLWordPrintable

Details

    Description

      Steps to reproduce:

      1. Create a build pipeline with at least two stages, the second of which adds Actions to a build. For example, the git-plugin will attach a hudson.plugins.git.GitTagAction to the build to say what revision was built.
      2. Run the pipeline
      3. Re-run the second stage of the pipeline

      Expect:

      1. One actions in the summary page of the build from the git plugin

      Observe:

      1. Two actions! The previous builds action and the current builds (see attached screenshot)

      Marking as major because this results in breaking the TestNG publisher plugin - it relies on actions being persisted in builds to show reports and trend data. When actions are copied, the data is corrupted, and trends are overridden. This could potentially break other plugins in the pipeline as well.

      Attachments

        Issue Links

          is duplicated by

          Bug - A problem which impairs or prevents the functions of the product. JENKINS-32885 Build Pipeline Plugin doesn't link the jobs to it's corresponding build number after successful re-build.

          • Blocker - Blocks development and/or testing work, production could not run.
          • Resolved

          Bug - A problem which impairs or prevents the functions of the product. JENKINS-19870 Status of the existing pipeline job is not updated after a failure or aborted build. Downstream job trigger is not enabled after the build succeeds

          • Major - Major loss of function.
          • Resolved

          Bug - A problem which impairs or prevents the functions of the product. JENKINS-26596 On restarting broken build in pipeline, dashboard should update accordingly

          • Major - Major loss of function.
          • Resolved
          is related to

          Bug - A problem which impairs or prevents the functions of the product. JENKINS-22210 On restarting broken build in pipeline, dashboard should update accordingly

          • Major - Major loss of function.
          • Closed

          Bug - A problem which impairs or prevents the functions of the product. JENKINS-24883 Artifacts not found on re-runs of manual jobs in pipeline

          • Blocker - Blocks development and/or testing work, production could not run.
          • Closed
          links to

          Web Link PR

          Activity

            Ascending order - Click to sort in descending order
            View 4 older comments
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Dan Alvizu
            Path:
            src/main/java/au/com/centrumsystems/hudson/plugin/buildpipeline/BuildPipelineView.java
            src/test/java/au/com/centrumsystems/hudson/plugin/buildpipeline/BuildPipelineViewTest.java
            http://jenkins-ci.org/commit/build-pipeline-plugin/13fa2c972bbd156460e5515b3e23b1445cd907bb
            Log:
            JENKINS-30801 Copy over ParametersAction as well

            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Dan Alvizu Path: src/main/java/au/com/centrumsystems/hudson/plugin/buildpipeline/BuildPipelineView.java src/test/java/au/com/centrumsystems/hudson/plugin/buildpipeline/BuildPipelineViewTest.java http://jenkins-ci.org/commit/build-pipeline-plugin/13fa2c972bbd156460e5515b3e23b1445cd907bb Log: JENKINS-30801 Copy over ParametersAction as well
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Dan Alvizu
            Path:
            src/main/java/au/com/centrumsystems/hudson/plugin/buildpipeline/BuildPipelineView.java
            src/test/java/au/com/centrumsystems/hudson/plugin/buildpipeline/trigger/BuildPipelineTriggerTest.java
            http://jenkins-ci.org/commit/build-pipeline-plugin/702b877b7ef9f8b1aa64247b4ad8c215bf76d344
            Log:
            [FIXED JENKINS-30801] Fix missing UpstreamCause

            UpstreamCause was being removed if it contained a UserIdCause.
            We really only want to remove the UserIdCause itself, and preserve
            the rest of the CauseAction to save upstream / downstream
            relationships.

            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Dan Alvizu Path: src/main/java/au/com/centrumsystems/hudson/plugin/buildpipeline/BuildPipelineView.java src/test/java/au/com/centrumsystems/hudson/plugin/buildpipeline/trigger/BuildPipelineTriggerTest.java http://jenkins-ci.org/commit/build-pipeline-plugin/702b877b7ef9f8b1aa64247b4ad8c215bf76d344 Log: [FIXED JENKINS-30801] Fix missing UpstreamCause UpstreamCause was being removed if it contained a UserIdCause. We really only want to remove the UserIdCause itself, and preserve the rest of the CauseAction to save upstream / downstream relationships.
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Dan Alvizu
            Path:
            src/main/java/au/com/centrumsystems/hudson/plugin/buildpipeline/BuildPipelineView.java
            http://jenkins-ci.org/commit/build-pipeline-plugin/439eeab2f7060fd542b47c95da1303ec01946ad0
            Log:
            JENKINS-30801 checkstyle fixes

            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Dan Alvizu Path: src/main/java/au/com/centrumsystems/hudson/plugin/buildpipeline/BuildPipelineView.java http://jenkins-ci.org/commit/build-pipeline-plugin/439eeab2f7060fd542b47c95da1303ec01946ad0 Log: JENKINS-30801 checkstyle fixes
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Dan Alvizu
            Path:
            src/main/java/au/com/centrumsystems/hudson/plugin/buildpipeline/BuildPipelineView.java
            src/test/java/au/com/centrumsystems/hudson/plugin/buildpipeline/BuildPipelineViewTest.java
            http://jenkins-ci.org/commit/build-pipeline-plugin/fb49ded545db776497cd0692d0032cad40ff3fab
            Log:
            JENKINS-30801 fix ConcurrentModificationException, add test

            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Dan Alvizu Path: src/main/java/au/com/centrumsystems/hudson/plugin/buildpipeline/BuildPipelineView.java src/test/java/au/com/centrumsystems/hudson/plugin/buildpipeline/BuildPipelineViewTest.java http://jenkins-ci.org/commit/build-pipeline-plugin/fb49ded545db776497cd0692d0032cad40ff3fab Log: JENKINS-30801 fix ConcurrentModificationException, add test
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Dan Alvizu
            Path:
            .gitignore
            pom.xml
            src/main/java/au/com/centrumsystems/hudson/plugin/buildpipeline/BuildPipelineView.java
            src/main/webapp/js/build-pipeline.js
            src/test/java/au/com/centrumsystems/hudson/plugin/buildpipeline/BuildPipelineViewTest.java
            src/test/java/au/com/centrumsystems/hudson/plugin/buildpipeline/trigger/BuildPipelineTriggerTest.java
            http://jenkins-ci.org/commit/build-pipeline-plugin/c05598dfef7dc2258e111e64de2a470e1df6d98f
            Log:
            Merge pull request #89 from dalvizu/JENKINS-30801-2

            [Fixed JENKINS-30801]

            Compare: https://github.com/jenkinsci/build-pipeline-plugin/compare/11ce036fb7fa...c05598dfef7d

            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Dan Alvizu Path: .gitignore pom.xml src/main/java/au/com/centrumsystems/hudson/plugin/buildpipeline/BuildPipelineView.java src/main/webapp/js/build-pipeline.js src/test/java/au/com/centrumsystems/hudson/plugin/buildpipeline/BuildPipelineViewTest.java src/test/java/au/com/centrumsystems/hudson/plugin/buildpipeline/trigger/BuildPipelineTriggerTest.java http://jenkins-ci.org/commit/build-pipeline-plugin/c05598dfef7dc2258e111e64de2a470e1df6d98f Log: Merge pull request #89 from dalvizu/ JENKINS-30801 -2 [Fixed JENKINS-30801] Compare: https://github.com/jenkinsci/build-pipeline-plugin/compare/11ce036fb7fa...c05598dfef7d

            People

              dalvizu Dan Alvizu
              dalvizu Dan Alvizu
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: