Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-3095

If job name is change, clearcase plugin doesn't remove view

    XMLWordPrintable

Details

    • Bug
    • Status: Closed (View Workflow)
    • Major
    • Resolution: Fixed
    • clearcase-plugin
    • None
    • Platform: All, OS: All

    Description

      We have a job that is built on a linux slave using the clearcase adapter. When
      we change the name of the job, the original view remains in the slave workspace
      preventing the job from running because the view name has to be globally unique.
      The clearcase plugin should remove the view when the job changes name.

      Attachments

        Issue Links

          Activity

            Code changed in hudson
            User: : sunfire
            Path:
            trunk/hudson/plugins/clearcase/src/test/java/hudson/plugins/clearcase/AbstractClearCaseScmTest.java
            http://fisheye4.cenqua.com/changelog/hudson/?cs=15765
            Log:
            JENKINS-3095

            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in hudson User: : sunfire Path: trunk/hudson/plugins/clearcase/src/test/java/hudson/plugins/clearcase/AbstractClearCaseScmTest.java http://fisheye4.cenqua.com/changelog/hudson/?cs=15765 Log: JENKINS-3095
            abayer Andrew Bayer added a comment -

            Reopening.

            abayer Andrew Bayer added a comment - Reopening.
            abayer Andrew Bayer added a comment -

            The logic specific to the job name changing does work - the onRenamed listener
            gets called, and proceeds to call the onDeleted listener (which calls rmview).
            But the rmview fails, for two reasons: first, it was being called with a
            workspace two directories up from where it should have been, and second,
            onRenamed/onDeleted don't get called until after the physical
            deletion/renaming of the job and hence the view storage on disk, so rmview won't
            work regardless.

            I've got a working fix for the first problem, but the second problem will
            require changes to Hudson core. Working on that.

            abayer Andrew Bayer added a comment - The logic specific to the job name changing does work - the onRenamed listener gets called, and proceeds to call the onDeleted listener (which calls rmview). But the rmview fails, for two reasons: first, it was being called with a workspace two directories up from where it should have been, and second, onRenamed/onDeleted don't get called until after the physical deletion/renaming of the job and hence the view storage on disk, so rmview won't work regardless. I've got a working fix for the first problem, but the second problem will require changes to Hudson core. Working on that.

            Code changed in hudson
            User: : abayer
            Path:
            trunk/hudson/plugins/clearcase/src/main/java/hudson/plugins/clearcase/AbstractClearCaseScm.java
            trunk/hudson/plugins/clearcase/src/main/java/hudson/plugins/clearcase/ClearCaseSCM.java
            trunk/hudson/plugins/clearcase/src/main/java/hudson/plugins/clearcase/ClearCaseUcmSCM.java
            trunk/hudson/plugins/clearcase/src/main/java/hudson/plugins/clearcase/ClearTool.java
            trunk/hudson/plugins/clearcase/src/main/java/hudson/plugins/clearcase/ClearToolDynamic.java
            trunk/hudson/plugins/clearcase/src/main/java/hudson/plugins/clearcase/ClearToolDynamicUCM.java
            trunk/hudson/plugins/clearcase/src/main/java/hudson/plugins/clearcase/ClearToolExec.java
            trunk/hudson/plugins/clearcase/src/main/java/hudson/plugins/clearcase/ClearToolSnapshot.java
            trunk/hudson/plugins/clearcase/src/main/resources/hudson/plugins/clearcase/ClearCaseSCM/config.jelly
            trunk/hudson/plugins/clearcase/src/main/resources/hudson/plugins/clearcase/ClearCaseUcmSCM/config.jelly
            trunk/hudson/plugins/clearcase/src/test/java/hudson/plugins/clearcase/ClearToolExecTest.java
            http://fisheye4.cenqua.com/changelog/hudson/?cs=18096
            Log:
            [JENKINS-3095, JENKINS-3508] ClearCase plugin now properly handles job renaming and deletion - the view storage is still deleted before the plugin knows anything about it, but it's now just removing the view tag when it does get called, since the view storage is gone. Also, fixed an annoying problem with "Remove view on rename" not sticking in the configuration.

            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in hudson User: : abayer Path: trunk/hudson/plugins/clearcase/src/main/java/hudson/plugins/clearcase/AbstractClearCaseScm.java trunk/hudson/plugins/clearcase/src/main/java/hudson/plugins/clearcase/ClearCaseSCM.java trunk/hudson/plugins/clearcase/src/main/java/hudson/plugins/clearcase/ClearCaseUcmSCM.java trunk/hudson/plugins/clearcase/src/main/java/hudson/plugins/clearcase/ClearTool.java trunk/hudson/plugins/clearcase/src/main/java/hudson/plugins/clearcase/ClearToolDynamic.java trunk/hudson/plugins/clearcase/src/main/java/hudson/plugins/clearcase/ClearToolDynamicUCM.java trunk/hudson/plugins/clearcase/src/main/java/hudson/plugins/clearcase/ClearToolExec.java trunk/hudson/plugins/clearcase/src/main/java/hudson/plugins/clearcase/ClearToolSnapshot.java trunk/hudson/plugins/clearcase/src/main/resources/hudson/plugins/clearcase/ClearCaseSCM/config.jelly trunk/hudson/plugins/clearcase/src/main/resources/hudson/plugins/clearcase/ClearCaseUcmSCM/config.jelly trunk/hudson/plugins/clearcase/src/test/java/hudson/plugins/clearcase/ClearToolExecTest.java http://fisheye4.cenqua.com/changelog/hudson/?cs=18096 Log: [JENKINS-3095, JENKINS-3508] ClearCase plugin now properly handles job renaming and deletion - the view storage is still deleted before the plugin knows anything about it, but it's now just removing the view tag when it does get called, since the view storage is gone. Also, fixed an annoying problem with "Remove view on rename" not sticking in the configuration.
            abayer Andrew Bayer added a comment -

            Fixed, will be in 0.9.

            abayer Andrew Bayer added a comment - Fixed, will be in 0.9.

            People

              abayer Andrew Bayer
              petehayes Peter Hayes
              Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: