Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-30981

Absolute paths required for custom JS/CSS files

    XMLWordPrintable

Details

    Description

      Extracted from JENKINS-30836:

      The path for custom CSS/JS files is confusing as the absolute file path is required (/home/jenkins/jobs/build/workspace/trunk/file.js) there. In contrast, the JGiven result json files path is relative (/trunk/jgiven-reports)

      In all other plugins I know, the paths are always relative, so the best solution is to also use relative paths for custom CSS/JS. Maybe it would also nice to support http links.

      Attachments

        Activity

          Code changed in jenkins
          User: Stefan Wolf
          Path:
          src/main/java/org/jenkinsci/plugins/jgiven/JgivenReportGenerator.java
          src/main/resources/org/jenkinsci/plugins/jgiven/JgivenReportGenerator/HtmlReportConfig/help-customCssFile.html
          src/main/resources/org/jenkinsci/plugins/jgiven/JgivenReportGenerator/HtmlReportConfig/help-customCssFile_de.html
          src/main/resources/org/jenkinsci/plugins/jgiven/JgivenReportGenerator/HtmlReportConfig/help-customJsFile.html
          src/main/resources/org/jenkinsci/plugins/jgiven/JgivenReportGenerator/HtmlReportConfig/help-customJsFile_de.html
          http://jenkins-ci.org/commit/jgiven-plugin/901ec03e0e2adb3f93a8d16cb3068646063bfd25
          Log:
          [FIXED JENKINS-30981] Custom files are now taken from workspace

          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Stefan Wolf Path: src/main/java/org/jenkinsci/plugins/jgiven/JgivenReportGenerator.java src/main/resources/org/jenkinsci/plugins/jgiven/JgivenReportGenerator/HtmlReportConfig/help-customCssFile.html src/main/resources/org/jenkinsci/plugins/jgiven/JgivenReportGenerator/HtmlReportConfig/help-customCssFile_de.html src/main/resources/org/jenkinsci/plugins/jgiven/JgivenReportGenerator/HtmlReportConfig/help-customJsFile.html src/main/resources/org/jenkinsci/plugins/jgiven/JgivenReportGenerator/HtmlReportConfig/help-customJsFile_de.html http://jenkins-ci.org/commit/jgiven-plugin/901ec03e0e2adb3f93a8d16cb3068646063bfd25 Log: [FIXED JENKINS-30981] Custom files are now taken from workspace

          Code changed in jenkins
          User: Stefan Wolf
          Path:
          src/main/java/org/jenkinsci/plugins/jgiven/JgivenReportGenerator.java
          src/main/resources/org/jenkinsci/plugins/jgiven/JgivenReportGenerator/HtmlReportConfig/help-customCssFile.html
          src/main/resources/org/jenkinsci/plugins/jgiven/JgivenReportGenerator/HtmlReportConfig/help-customCssFile_de.html
          src/main/resources/org/jenkinsci/plugins/jgiven/JgivenReportGenerator/HtmlReportConfig/help-customJsFile.html
          src/main/resources/org/jenkinsci/plugins/jgiven/JgivenReportGenerator/HtmlReportConfig/help-customJsFile_de.html
          http://jenkins-ci.org/commit/jgiven-plugin/414932c7f7e1f5baa041803a58915bfa36d274fc
          Log:
          Merge pull request #3 from jenkinsci/from-workspace

          [FIXED JENKINS-30981] Custom files are now taken from workspace

          Compare: https://github.com/jenkinsci/jgiven-plugin/compare/62d623a903b6...414932c7f7e1

          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Stefan Wolf Path: src/main/java/org/jenkinsci/plugins/jgiven/JgivenReportGenerator.java src/main/resources/org/jenkinsci/plugins/jgiven/JgivenReportGenerator/HtmlReportConfig/help-customCssFile.html src/main/resources/org/jenkinsci/plugins/jgiven/JgivenReportGenerator/HtmlReportConfig/help-customCssFile_de.html src/main/resources/org/jenkinsci/plugins/jgiven/JgivenReportGenerator/HtmlReportConfig/help-customJsFile.html src/main/resources/org/jenkinsci/plugins/jgiven/JgivenReportGenerator/HtmlReportConfig/help-customJsFile_de.html http://jenkins-ci.org/commit/jgiven-plugin/414932c7f7e1f5baa041803a58915bfa36d274fc Log: Merge pull request #3 from jenkinsci/from-workspace [FIXED JENKINS-30981] Custom files are now taken from workspace Compare: https://github.com/jenkinsci/jgiven-plugin/compare/62d623a903b6...414932c7f7e1

          I've just tested the relative paths, it seems they don't work yet - see attached screenshots.

          nikowitt Niko Wittenbeck added a comment - I've just tested the relative paths, it seems they don't work yet - see attached screenshots.
          wolfs Stefan Wolf added a comment -

          I forgot to adjust the validation. If you ignore the validation error and save the relative path, does it work?

          wolfs Stefan Wolf added a comment - I forgot to adjust the validation. If you ignore the validation error and save the relative path, does it work?

          Yes, it seems to work, you are right.

          nikowitt Niko Wittenbeck added a comment - Yes, it seems to work, you are right.

          People

            wolfs Stefan Wolf
            nikowitt Niko Wittenbeck
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: