Bad quote management in commands

XMLWordPrintable

    • Type: Bug
    • Resolution: Fixed
    • Priority: Major
    • Component/s: jabber-plugin
    • None
    • Environment:
      Platform: All, OS: All

      trunk/hudson/plugins/jabber/src/main/java/hudson/plugins/jabber/tools/MessageHelper.java

      49 int firstQuote = commandLine.indexOf(QUOTE);
      (...)
      60 parameters
      61 .add(commandLine.substring(firstQuote + 1, endQuoted));

      firstQuote+1 is wrong if the quote is the last char.

      java.lang.StringIndexOutOfBoundsException: String index out of range: -16
      at java.lang.String.substring(String.java:1949)
      at
      hudson.plugins.jabber.tools.MessageHelper.extractParameters(MessageHelper.java:60)
      at
      hudson.plugins.jabber.tools.MessageHelper.extractCommandLine(MessageHelper.java:39)
      at hudson.plugins.jabber.im.transport.bot.Bot.processPacket(Bot.java:106)
      at
      org.jivesoftware.smack.PacketReader$ListenerWrapper.notifyListener(PacketReader.java:822)
      at org.jivesoftware.smack.PacketReader.processListeners(PacketReader.java:260)
      at org.jivesoftware.smack.PacketReader.access$100(PacketReader.java:43)
      at org.jivesoftware.smack.PacketReader$2.run(PacketReader.java:72)

            Assignee:
            kutzi
            Reporter:
            bsibaud
            Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

              Created:
              Updated:
              Resolved: