Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-32696

healthcheck API endpoint causes a new run of health checks instead of reusing previous values

    XMLWordPrintable

Details

    Description

      Hitting /metrics/currentUser/healthcheck causes a new execution of the health checks instead of reusing previously calculated values in the periodic task, which could be expensive, depending on the health checks

      Attachments

        Activity

          csanchez Carlos Sanchez added a comment - https://github.com/jenkinsci/metrics-plugin/pull/19

          Based on PR comments this works as expected although there are some changes of a DoD if the health checks get executed too fast and take some time to run

          csanchez Carlos Sanchez added a comment - Based on PR comments this works as expected although there are some changes of a DoD if the health checks get executed too fast and take some time to run

          Code changed in jenkins
          User: Carlos Sanchez
          Path:
          src/main/java/jenkins/metrics/api/Metrics.java
          src/main/java/jenkins/metrics/api/MetricsRootAction.java
          http://jenkins-ci.org/commit/metrics-plugin/200a053ed4aae8723269e1da87ea2b4fd1ceb225
          Log:
          JENKINS-32696 Healthcheck API endpoint causes a new run of health checks

          Instead of reusing previous values

          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Carlos Sanchez Path: src/main/java/jenkins/metrics/api/Metrics.java src/main/java/jenkins/metrics/api/MetricsRootAction.java http://jenkins-ci.org/commit/metrics-plugin/200a053ed4aae8723269e1da87ea2b4fd1ceb225 Log: JENKINS-32696 Healthcheck API endpoint causes a new run of health checks Instead of reusing previous values

          Code changed in jenkins
          User: Carlos Sanchez
          Path:
          src/main/java/jenkins/metrics/api/Metrics.java
          src/main/java/jenkins/metrics/api/MetricsRootAction.java
          http://jenkins-ci.org/commit/metrics-plugin/b06dbe2643313267c52f768c6da34abce2066913
          Log:
          JENKINS-32696 Healthcheck API endpoint causes a new run of health checks

          Instead of reusing previous values

          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Carlos Sanchez Path: src/main/java/jenkins/metrics/api/Metrics.java src/main/java/jenkins/metrics/api/MetricsRootAction.java http://jenkins-ci.org/commit/metrics-plugin/b06dbe2643313267c52f768c6da34abce2066913 Log: JENKINS-32696 Healthcheck API endpoint causes a new run of health checks Instead of reusing previous values

          Code changed in jenkins
          User: Stephen Connolly
          Path:
          src/main/java/jenkins/metrics/api/Metrics.java
          src/main/java/jenkins/metrics/api/MetricsRootAction.java
          http://jenkins-ci.org/commit/metrics-plugin/b4ae1f4bf988521d211abbfdd02e47d9dfc16278
          Log:
          Merge pull request #20 from jenkinsci/cached-results

          JENKINS-32696 Healthcheck API endpoint causes a new run of health checks

          Compare: https://github.com/jenkinsci/metrics-plugin/compare/ef2d2f9df376...b4ae1f4bf988

          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Stephen Connolly Path: src/main/java/jenkins/metrics/api/Metrics.java src/main/java/jenkins/metrics/api/MetricsRootAction.java http://jenkins-ci.org/commit/metrics-plugin/b4ae1f4bf988521d211abbfdd02e47d9dfc16278 Log: Merge pull request #20 from jenkinsci/cached-results JENKINS-32696 Healthcheck API endpoint causes a new run of health checks Compare: https://github.com/jenkinsci/metrics-plugin/compare/ef2d2f9df376...b4ae1f4bf988

          People

            Unassigned Unassigned
            csanchez Carlos Sanchez
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: