Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-33103

AccuRev Stream color is reset without a clear purpose

    XMLWordPrintable

Details

    Description

      Currently the AccuRev Jenkins CI plug-in always resets the color of the stream.
      This is not something we requested, nor something we can disable.
      This is unwanted behavior.
      I would like to see an option to disable this.

      If I look at hudson.plugins.accurev.delegates.AbstractModeDelegate it seems that this is only called in checkout( ... ).
      I do not really know why this is done in the first place.
      In my opinion it does not add anything and it can be removed.
      It would only start to make sense if the plug-in also has the option the change the color when the build fails, but I did not find this in the code.

      Attachments

        Activity

          This option, should it be global for the accurev server or for each job?

          I do believe the option should start out as false, that way users would have to enable it.

          casz Joseph Petersen (old) added a comment - This option, should it be global for the accurev server or for each job? I do believe the option should start out as false, that way users would have to enable it.
          arnom Arno Moonen added a comment -

          I think the answer is both.
          So on a global level you probably want to set the default and on a job level you'd probably want to override it.

          But still, resetting the color does not make sense to me, if you do not provide a way to set the color based on the result of the build for example.

          The client I'm currently working for that uses AccuRev has its own coloring scheme to indicate how a stream should be used (what its purpose is).

          arnom Arno Moonen added a comment - I think the answer is both. So on a global level you probably want to set the default and on a job level you'd probably want to override it. But still, resetting the color does not make sense to me, if you do not provide a way to set the color based on the result of the build for example. The client I'm currently working for that uses AccuRev has its own coloring scheme to indicate how a stream should be used (what its purpose is).

          Code changed in jenkins
          User: Joseph
          Path:
          .gitignore
          src/main/java/hudson/plugins/accurev/AccurevLauncher.java
          src/main/java/hudson/plugins/accurev/AccurevSCM.java
          src/main/java/hudson/plugins/accurev/DetermineRemoteHostname.java
          src/main/java/hudson/plugins/accurev/cmd/ChangeLogCmd.java
          src/main/java/hudson/plugins/accurev/cmd/PopulateCmd.java
          src/main/java/hudson/plugins/accurev/cmd/Update.java
          src/main/java/hudson/plugins/accurev/delegates/AbstractModeDelegate.java
          src/main/java/hudson/plugins/accurev/parsers/xml/ParseHistory.java
          src/main/resources/hudson/plugins/accurev/AccurevSCM/global.jelly
          src/main/webapp/help/use-color.html
          http://jenkins-ci.org/commit/accurev-plugin/54cb79967006982752154c27f49e435154d85e9b
          Log:
          NullPointer fixes. better hostname handling. Toggle streamColor. (#27)

          • ignore .DS_Store file

          Cannot prevent bad DNS/Hostname config.

          cannot prevent bad DNS/Hostname.

          • [JENKINS-33103, JENKINS-38148] added toggle for color reset.
          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Joseph Path: .gitignore src/main/java/hudson/plugins/accurev/AccurevLauncher.java src/main/java/hudson/plugins/accurev/AccurevSCM.java src/main/java/hudson/plugins/accurev/DetermineRemoteHostname.java src/main/java/hudson/plugins/accurev/cmd/ChangeLogCmd.java src/main/java/hudson/plugins/accurev/cmd/PopulateCmd.java src/main/java/hudson/plugins/accurev/cmd/Update.java src/main/java/hudson/plugins/accurev/delegates/AbstractModeDelegate.java src/main/java/hudson/plugins/accurev/parsers/xml/ParseHistory.java src/main/resources/hudson/plugins/accurev/AccurevSCM/global.jelly src/main/webapp/help/use-color.html http://jenkins-ci.org/commit/accurev-plugin/54cb79967006982752154c27f49e435154d85e9b Log: NullPointer fixes. better hostname handling. Toggle streamColor. (#27) ignore .DS_Store file JENKINS-38148 Handle some null pointers. Cannot prevent bad DNS/Hostname config. JENKINS-38201 Partial fix cannot prevent bad DNS/Hostname. [JENKINS-33103, JENKINS-38148] added toggle for color reset. JENKINS-38201 Better error message

          Marked as fixed, because you can now disable the color reset.

          casz Joseph Petersen (old) added a comment - Marked as fixed, because you can now disable the color reset.

          People

            jetersen Joseph Petersen
            arnom Arno Moonen
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: