Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-35130

Delete and Move credentials do not work with providers that do not have modifiable domains

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed (View Workflow)
    • Priority: Minor
    • Resolution: Fixed
    • Component/s: credentials-plugin
    • Labels:
      None
    • Environment:
      credentials plugin 2.0-2.0.6
    • Similar Issues:

      Description

      This check: https://github.com/jenkinsci/credentials-plugin/blob/credentials-2.0.6/src/main/java/com/cloudbees/plugins/credentials/CredentialsStoreAction.java#L1011 was a copy and paste of the check in DomainWrapper.doDoDelete() but does not make sense for credentials stored in a existing domain.

      It may be the case that the set of domains is fixed by the provider but it is acceptable to remove credentials within the domain and to move credentials between the existing domains

        Attachments

          Activity

          Hide
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Stephen Connolly
          Path:
          src/main/java/com/cloudbees/plugins/credentials/CredentialsStoreAction.java
          http://jenkins-ci.org/commit/credentials-plugin/28d6d450f65682f65200c55a9589669f1dfe5400
          Log:
          [FIXED JENKINS-35130] Delete and Move credentials do not work with providers that do not have modifiable domains

          Show
          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Stephen Connolly Path: src/main/java/com/cloudbees/plugins/credentials/CredentialsStoreAction.java http://jenkins-ci.org/commit/credentials-plugin/28d6d450f65682f65200c55a9589669f1dfe5400 Log: [FIXED JENKINS-35130] Delete and Move credentials do not work with providers that do not have modifiable domains
          Hide
          jglick Jesse Glick added a comment -

          JIRA link daemon triggers on non-master branches. Use forked PRs to avoid this problem.

          Show
          jglick Jesse Glick added a comment - JIRA link daemon triggers on non- master branches. Use forked PRs to avoid this problem.
          Hide
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Stephen Connolly
          Path:
          src/main/java/com/cloudbees/plugins/credentials/CredentialsStoreAction.java
          http://jenkins-ci.org/commit/credentials-plugin/be60a05220169ce08fa1386757c84a1ec5793096
          Log:
          Merge pull request #51 from jenkinsci/jenkins-35130

          [FIXED JENKINS-35130] Delete and Move credentials do not work with providers that do not have modifiable domains

          Compare: https://github.com/jenkinsci/credentials-plugin/compare/4b409d890a46...be60a0522016

          Show
          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Stephen Connolly Path: src/main/java/com/cloudbees/plugins/credentials/CredentialsStoreAction.java http://jenkins-ci.org/commit/credentials-plugin/be60a05220169ce08fa1386757c84a1ec5793096 Log: Merge pull request #51 from jenkinsci/jenkins-35130 [FIXED JENKINS-35130] Delete and Move credentials do not work with providers that do not have modifiable domains Compare: https://github.com/jenkinsci/credentials-plugin/compare/4b409d890a46...be60a0522016

            People

            Assignee:
            stephenconnolly Stephen Connolly
            Reporter:
            stephenconnolly Stephen Connolly
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved: