Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-35210

P4 plugin does not pass build review parameters to job after SECURITY-170 fix

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed (View Workflow)
    • Priority: Major
    • Resolution: Fixed
    • Component/s: p4-plugin
    • Labels:
    • Environment:
      - Jenkins 2.7
      - P4 Plugin 1.3.9
      - Linux Ubuntu 14.04 LTS 64 bit (updated to latest updates 30-05-2016)
      - Firefox 46.0.1
      - OpenJDK Runtime Environment 1.7.0_101-b00 (64 bit)
    • Similar Issues:

      Description

      After the fixes made in Jenkins for SECURITY-170, the parameters generated when running a 'build review' are no longer passed.
      The parameters not passed are: json, review, change, status, pass, fail, label, Submit

      The prevents the build scripts detecting it is a review build and thus cannot act in the appropriate manner.
      See https://wiki.jenkins-ci.org/display/JENKINS/Plugins+affected+by+fix+for+SECURITY-170 for more information about the Jenkins security fix and how to handle it.

        Attachments

          Activity

          Hide
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Antonio Muñiz
          Path:
          src/main/java/org/jenkinsci/plugins/p4/review/ReviewAction.java
          src/main/java/org/jenkinsci/plugins/p4/review/SafeParametersAction.java
          src/test/java/org/jenkinsci/plugins/p4/client/ConnectionTest.java
          http://jenkins-ci.org/commit/p4-plugin/72cde84d3d53eebf5504ab9a163f83e1364aeb5a
          Log:
          JENKINS-35210 Fix for SECURITY-170

          Show
          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Antonio Muñiz Path: src/main/java/org/jenkinsci/plugins/p4/review/ReviewAction.java src/main/java/org/jenkinsci/plugins/p4/review/SafeParametersAction.java src/test/java/org/jenkinsci/plugins/p4/client/ConnectionTest.java http://jenkins-ci.org/commit/p4-plugin/72cde84d3d53eebf5504ab9a163f83e1364aeb5a Log: JENKINS-35210 Fix for SECURITY-170
          Hide
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Antonio Muñiz
          Path:
          src/main/java/org/jenkinsci/plugins/p4/trigger/P4Trigger.java
          src/test/java/org/jenkinsci/plugins/p4/client/ConnectionTest.java
          http://jenkins-ci.org/commit/p4-plugin/178a3a6f68087c96b8ee88abda63e1ef502d8097
          Log:
          Merge branch 'master' into JENKINS-35210

          Show
          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Antonio Muñiz Path: src/main/java/org/jenkinsci/plugins/p4/trigger/P4Trigger.java src/test/java/org/jenkinsci/plugins/p4/client/ConnectionTest.java http://jenkins-ci.org/commit/p4-plugin/178a3a6f68087c96b8ee88abda63e1ef502d8097 Log: Merge branch 'master' into JENKINS-35210
          Hide
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Paul Allen
          Path:
          src/main/java/org/jenkinsci/plugins/p4/review/ReviewAction.java
          src/main/java/org/jenkinsci/plugins/p4/review/SafeParametersAction.java
          src/test/java/org/jenkinsci/plugins/p4/client/ConnectionTest.java
          http://jenkins-ci.org/commit/p4-plugin/df32b4ec5814db70acf5cf5e61f3b73fcb36ba14
          Log:
          Merge pull request #25 from amuniz/JENKINS-35210

          JENKINS-35210 Fix for SECURITY-170

          Compare: https://github.com/jenkinsci/p4-plugin/compare/e9a370b5ec85...df32b4ec5814

          Show
          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Paul Allen Path: src/main/java/org/jenkinsci/plugins/p4/review/ReviewAction.java src/main/java/org/jenkinsci/plugins/p4/review/SafeParametersAction.java src/test/java/org/jenkinsci/plugins/p4/client/ConnectionTest.java http://jenkins-ci.org/commit/p4-plugin/df32b4ec5814db70acf5cf5e61f3b73fcb36ba14 Log: Merge pull request #25 from amuniz/ JENKINS-35210 JENKINS-35210 Fix for SECURITY-170 Compare: https://github.com/jenkinsci/p4-plugin/compare/e9a370b5ec85...df32b4ec5814
          Hide
          p4paul Paul Allen added a comment -

          Released.

          Show
          p4paul Paul Allen added a comment - Released.

            People

            Assignee:
            amuniz Antonio Muñiz
            Reporter:
            jbogers Jeroen Bogers
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved: