Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-36831

Regression breakage in version number after upgrade

    XMLWordPrintable

Details

    Description

      Hi – Upgrading to the versionnumber plugin version 1.7 seems to have broken the next build number. Reverting to 1.6 fixes the issue.

      I'm using job dsl to configure by jobs. Here is the relevant configuration:

      wrappers {
      versionNumberBuilder {
      environmentVariableName('VERSION')
      environmentPrefixVariable('')
      versionNumberString(cfg.semverPrefix + '.${BUILDS_ALL_TIME}')
      skipFailedBuilds(true)
      useAsBuildDisplayName(true)
      projectStartDate('1969-12-31 05:00:00.0 UTC')
      buildsToday('')
      buildsThisWeek('')
      buildsThisMonth('')
      buildsThisYear('')
      buildsAllTime('')
      }
      }

      The issue is that the build number is not incrementing after successful builds. What is strange is that running a manual build will bump the version. In my case, builds are typically triggered by a push from our Bitbucket. When triggered by the push, the version number does not increment. When triggered from a manual build via the Jenkins UI, the number does increment.

      I'm not sure what other information I can provide, but I'm happy to help out if there are questions.

      Thanks,
      Tim

      Attachments

        Issue Links

          Activity

            billjackson Bill Jackson added a comment -

            My experience with this issue (I think it's this issue) is that the number increments for failures, but retains for successes when the "Don't increment builds today / this month / this year / all time after a failed build." option is enabled.

            billjackson Bill Jackson added a comment - My experience with this issue (I think it's this issue) is that the number increments for failures, but retains for successes when the "Don't increment builds today / this month / this year / all time after a failed build." option is enabled.

            Code changed in jenkins
            User: Deniz Bahadir
            Path:
            src/main/java/org/jvnet/hudson/tools/versionnumber/VersionNumberCommon.java
            http://jenkins-ci.org/commit/versionnumber-plugin/aa224390a913b6a95c65c4d1a57babd18c492bf6
            Log:
            JENKINS-36831 Fixed regression.

            The meaning of the "skipFailedBuilds" flag was accidentally flipped.

            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Deniz Bahadir Path: src/main/java/org/jvnet/hudson/tools/versionnumber/VersionNumberCommon.java http://jenkins-ci.org/commit/versionnumber-plugin/aa224390a913b6a95c65c4d1a57babd18c492bf6 Log: JENKINS-36831 Fixed regression. The meaning of the "skipFailedBuilds" flag was accidentally flipped.
            bahadir Deniz Bahadir added a comment -

            This should be fixed in version 1.7.2.

            bahadir Deniz Bahadir added a comment - This should be fixed in version 1.7.2.
            billjackson Bill Jackson added a comment -

            Fix confirmed. Thank you!

            billjackson Bill Jackson added a comment - Fix confirmed. Thank you!

            People

              bahadir Deniz Bahadir
              timdowney Tim Downey
              Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: