Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-37801

ViewCredentialsActionTest#smokes and CredentialsStoreActionTest are failing

XMLWordPrintable

    • Icon: Task Task
    • Resolution: Done
    • Icon: Minor Minor
    • credentials-plugin
    • None

      What incorrect behavior happened?

      ViewCredentialsActionTest is failing against the stable-2.7 branch

      Expected: Expected number of attributes '0' but was '1' - comparing <userFacingAction...> at /userFacingAction[1] to <userFacingAction...> at /userFacingAction[1]:
<userFacingAction>
  <domains>
    <_>
      <description>Credentials that should be available irrespective of domain specification to requirements matching.</description>
      <displayName>Global credentials (unrestricted)</displayName>
      <fullDisplayName>System » Global credentials (unrestricted)</fullDisplayName>
      <fullName>system/_</fullName>
      <global>true</global>
      <urlName>_</urlName>
    </_>
  </domains>
</userFacingAction>
     but: result was: 
<userFacingAction _class="com.cloudbees.plugins.credentials.SystemCredentialsProvider$UserFacingAction">
  <domains>
    <_ _class="com.cloudbees.plugins.credentials.CredentialsStoreAction$DomainWrapper">
      <description>Credentials that should be available irrespective of domain specification to requirements matching.</description>
      <displayName>Global credentials (unrestricted)</displayName>
      <fullDisplayName>System » Global credentials (unrestricted)</fullDisplayName>
      <fullName>system/_</fullName>
      <global>true</global>
      <urlName>_</urlName>
    </_>
  </domains>
</userFacingAction>

      ViewCredentialsActionTest failing against stable-2.7

      Expected: is "<rootActionImpl><stores><system><domains><_><description>Credentials that should be available irrespective of domain specification to requirements matching.</description><displayName>Global credentials (unrestricted)</displayName><fullDisplayName>System » Global credentials (unrestricted)</fullDisplayName><fullName>system/_</fullName><global>true</global><urlName>_</urlName></_></domains></system></stores></rootActionImpl>"
     but: was "<rootActionImpl _class='com.cloudbees.plugins.credentials.ViewCredentialsAction$RootActionImpl'><stores><system _class='com.cloudbees.plugins.credentials.SystemCredentialsProvider$UserFacingAction'><domains><_ _class='com.cloudbees.plugins.credentials.CredentialsStoreAction$DomainWrapper'><description>Credentials that should be available irrespective of domain specification to requirements matching.</description><displayName>Global credentials (unrestricted)</displayName><fullDisplayName>System » Global credentials (unrestricted)</fullDisplayName><fullName>system/_</fullName><global>true</global><urlName>_</urlName></_></domains></system></stores></rootActionImpl>"

      The problem seems not to be a real bug but some minor xml changes in new Jenkins version that broke the test. Some _class attributes added that IMHO can be safely ignored by this test

      Environment

      • O.S.: Linux
      • Jenkins version: stable-2.7

      What was the expected outcome?

      All credentials test passes

      Step by step to reproduce it

      mvn clean install -Djava.level=8
mvn test -Djava.level=8 -Djenkins.version=2.7.2

            rarabaolaza Raul Arabaolaza
            rarabaolaza Raul Arabaolaza
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Created:
              Updated:
              Resolved: