Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-38465

ECR plugin isn't compatible with credentials managed by folder plugin

    XMLWordPrintable

Details

    Description

      If you define your credentials at a folder level the ECR plugin cannot access to them.

      Looking at https://github.com/jenkinsci/amazon-ecr-plugin/blob/master/src/main/java/com/cloudbees/jenkins/plugins/amazonecr/AmazonECSRegistryCredential.java#L76, ecr plugin only look for credentials from Jenkins.instance context, not within current folder.

      Attachments

        Issue Links

          links to

          Web Link CloudBees Internal OSS-1470

          Web Link PR

          Activity

            Ascending order - Click to sort in descending order
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Ivan Fernandez Calvo
            Path:
            src/main/java/com/cloudbees/jenkins/plugins/amazonecr/AmazonECSRegistryCredential.java
            src/main/java/com/cloudbees/jenkins/plugins/amazonecr/AmazonECSRegistryCredentialsProvider.java
            http://jenkins-ci.org/commit/amazon-ecr-plugin/7572ce2975f9c5a8ebc8a2509fd980dd6a979dd9
            Log:
            JENKINS-38465 it now search credentials also into folders

            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Ivan Fernandez Calvo Path: src/main/java/com/cloudbees/jenkins/plugins/amazonecr/AmazonECSRegistryCredential.java src/main/java/com/cloudbees/jenkins/plugins/amazonecr/AmazonECSRegistryCredentialsProvider.java http://jenkins-ci.org/commit/amazon-ecr-plugin/7572ce2975f9c5a8ebc8a2509fd980dd6a979dd9 Log: JENKINS-38465 it now search credentials also into folders
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Ivan Fernandez Calvo
            Path:
            src/main/java/com/cloudbees/jenkins/plugins/amazonecr/AmazonECSRegistryCredential.java
            src/main/java/com/cloudbees/jenkins/plugins/amazonecr/AmazonECSRegistryCredentialsProvider.java
            http://jenkins-ci.org/commit/amazon-ecr-plugin/6eee172bd9cdc2351bed9cc32228cf8ebbeaa63a
            Log:
            Merge pull request #7 from kuisathaverat/JENKINS-38465

            [FIX JENKINS-38465] it now search credentials also into folders

            Compare: https://github.com/jenkinsci/amazon-ecr-plugin/compare/1e9f9237825d...6eee172bd9cd

            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Ivan Fernandez Calvo Path: src/main/java/com/cloudbees/jenkins/plugins/amazonecr/AmazonECSRegistryCredential.java src/main/java/com/cloudbees/jenkins/plugins/amazonecr/AmazonECSRegistryCredentialsProvider.java http://jenkins-ci.org/commit/amazon-ecr-plugin/6eee172bd9cdc2351bed9cc32228cf8ebbeaa63a Log: Merge pull request #7 from kuisathaverat/ JENKINS-38465 [FIX JENKINS-38465] it now search credentials also into folders Compare: https://github.com/jenkinsci/amazon-ecr-plugin/compare/1e9f9237825d...6eee172bd9cd

            People

              ifernandezcalvo Ivan Fernandez Calvo
              aheritier Arnaud Héritier
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: