Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-38604

Filter class directories

    XMLWordPrintable

Details

    • Improvement
    • Status: Fixed but Unreleased (View Workflow)
    • Major
    • Resolution: Fixed
    • jacoco-plugin
    • None
    • Jenkins 2.7.3 with JaCoCo plugin 2.0.1

    Description

      When using the post build step to publish JaCoCo coverage the plugin takes all files in the **/classes directory.
      Having jar files with large resource files leads to xxxGB of wasted space on the Jenkins server, because this is stored for every build job.

      The plugin should only publish *.class files to the jobs\xxx\builds\123\jacoco\classes directory.

      Attachments

        Activity

          mheinzerling Martin Heinzerling added a comment - - edited

          In addition to that, only *,java should be copied to sources.

           

          centic, is there any scenario where we need jars in the classes path. Do we need to make this configurable?

          mheinzerling Martin Heinzerling added a comment - - edited In addition to that, only *,java should be copied to sources.   centic , is there any scenario where we need jars in the classes path. Do we need to make this configurable?

          Code changed in jenkins
          User: Martin Heinzerling
          Path:
          src/main/java/hudson/plugins/jacoco/JacocoPublisher.java
          src/main/java/hudson/plugins/jacoco/JacocoReportDir.java
          src/test/java/hudson/plugins/jacoco/JacocoPublisherTest.java
          http://jenkins-ci.org/commit/jacoco-plugin/d771e0b15933516917208f30dd54bad81b1c290d
          Log:
          JENKINS-38604: limit copying of files to types *.java and *.class, improve logging

          Compare: https://github.com/jenkinsci/jacoco-plugin/compare/370c2774bb71^...d771e0b15933

          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Martin Heinzerling Path: src/main/java/hudson/plugins/jacoco/JacocoPublisher.java src/main/java/hudson/plugins/jacoco/JacocoReportDir.java src/test/java/hudson/plugins/jacoco/JacocoPublisherTest.java http://jenkins-ci.org/commit/jacoco-plugin/d771e0b15933516917208f30dd54bad81b1c290d Log: JENKINS-38604 : limit copying of files to types *.java and *.class, improve logging Compare: https://github.com/jenkinsci/jacoco-plugin/compare/370c2774bb71 ^...d771e0b15933

          centic, please review.

          mheinzerling Martin Heinzerling added a comment - centic , please review.
          centic centic added a comment -

          Looks good to merge to master!

          centic centic added a comment - Looks good to merge to master!

          Integrated into master.

          mheinzerling Martin Heinzerling added a comment - Integrated into master.
          john_slater John Slater added a comment -

          This change has prevented .groovy files from being copied over. The coverage report was previously displayed for groovy files before this change.

          john_slater John Slater added a comment - This change has prevented .groovy files from being copied over. The coverage report was previously displayed for groovy files before this change.
          centic centic added a comment -

          See JENKINS-56918 for adjusting the inclusion pattern some more.

          centic centic added a comment - See JENKINS-56918 for adjusting the inclusion pattern some more.

          People

            mheinzerling Martin Heinzerling
            reitzmichnicht Michael Düsterhus
            Votes:
            0 Vote for this issue
            Watchers:
            6 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: