Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-3967

Non code-changes (issue-changes) triggers Build

    XMLWordPrintable

Details

    • Bug
    • Status: Closed (View Workflow)
    • Major
    • Resolution: Fixed
    • accurev-plugin
    • None
    • Platform: All, OS: All

    Description

      The current version (0.6.7) of checkStreamForChanges that the polling-mechanism
      uses in AccurevSCM.java triggers on changes in transactions of the "dispatch"
      kind, in other words, issue-related changes and not code or "filesystem" related
      changes (and the result is unnecessary builds).

      This is due to that the accurev hist command that is used to query AccuRev for
      changes is unable to exclude transactions of the dispatch-kind and is only able to
      include transactions of a special kind.

      Attachments

        Issue Links

          Activity

            jafvert jafvert added a comment -

            I hope this solves our problem, the valid transaction type config in jelly makes
            it easier for us to choose the "right" transaction types.

            Also note that I've excluded the dispatch transaction type from the default-list
            in the global.jelly

            Im currently working on a patch for issue 4108 applying the valid transaction type
            filter there too.

            jafvert jafvert added a comment - I hope this solves our problem, the valid transaction type config in jelly makes it easier for us to choose the "right" transaction types. Also note that I've excluded the dispatch transaction type from the default-list in the global.jelly Im currently working on a patch for issue 4108 applying the valid transaction type filter there too.
            statlor Scott Tatum added a comment -

            Excellent thanks! Lots of changes.. I'll review everything when I get home this
            evening, and see if I can't get it merged tonight.

            I see you created 4108 - when you did, did it default to stephenconnolly for the
            assignee? If so, I need to see about getting this changed to me. He is no longer
            active on the plugin.

            If you have IRC, you should come join us on irc.freenode.net #hudson. I am
            usually on there and we can communicate more effectively if need be.

            Thanks again!

            statlor Scott Tatum added a comment - Excellent thanks! Lots of changes.. I'll review everything when I get home this evening, and see if I can't get it merged tonight. I see you created 4108 - when you did, did it default to stephenconnolly for the assignee? If so, I need to see about getting this changed to me. He is no longer active on the plugin. If you have IRC, you should come join us on irc.freenode.net #hudson. I am usually on there and we can communicate more effectively if need be. Thanks again!

            Code changed in hudson
            User: : statlor
            Path:
            trunk/hudson/plugins/accurev/src/main/java/hudson/plugins/accurev/AccurevSCM.java
            trunk/hudson/plugins/accurev/src/main/java/hudson/plugins/accurev/AccurevTransaction.java
            trunk/hudson/plugins/accurev/src/main/resources/hudson/plugins/accurev/AccurevSCM/global.jelly
            trunk/hudson/plugins/accurev/src/main/webapp/help/validTransactionTypes.html
            http://fisheye4.cenqua.com/changelog/hudson/?cs=20247
            Log:
            JENKINS-3967 Merged jafvert's patch for 3967 in with my changes for 3222.

            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in hudson User: : statlor Path: trunk/hudson/plugins/accurev/src/main/java/hudson/plugins/accurev/AccurevSCM.java trunk/hudson/plugins/accurev/src/main/java/hudson/plugins/accurev/AccurevTransaction.java trunk/hudson/plugins/accurev/src/main/resources/hudson/plugins/accurev/AccurevSCM/global.jelly trunk/hudson/plugins/accurev/src/main/webapp/help/validTransactionTypes.html http://fisheye4.cenqua.com/changelog/hudson/?cs=20247 Log: JENKINS-3967 Merged jafvert's patch for 3967 in with my changes for 3222.
            statlor Scott Tatum added a comment -

            I've merged your patch with my change for 3222 and am running this version now.
            I constantly get the spurious builds from issues so it should be a good test. If
            everything checks out, I'll release 0.6.9 with these changes.

            One thing I noticed after installing the plugin. I went to the Hudson
            configuration for Accurev, where you added the configuration of the Valid
            transaction types. There were no transaction types defined by default. From what
            I understand of the code, this means that once folks upgrade, no builds will
            trigger an update until they go in and configure some types, which are hidden
            behind the advanced tab.

            If that is the case, what I will probably do is default to all the types - this
            leaves the default functionality unchanged, and users can clean up the list as
            they see fit. Either that, or default to everything but dispatch - I doubt
            anyone will want to trigger on that.

            I'd also like to add some validation to give folks a warning if they add a type
            that isn't valid for Accurev. I'll work on that while this build runs in my
            current environment.

            Thanks for the patch!

            statlor Scott Tatum added a comment - I've merged your patch with my change for 3222 and am running this version now. I constantly get the spurious builds from issues so it should be a good test. If everything checks out, I'll release 0.6.9 with these changes. One thing I noticed after installing the plugin. I went to the Hudson configuration for Accurev, where you added the configuration of the Valid transaction types. There were no transaction types defined by default. From what I understand of the code, this means that once folks upgrade, no builds will trigger an update until they go in and configure some types, which are hidden behind the advanced tab. If that is the case, what I will probably do is default to all the types - this leaves the default functionality unchanged, and users can clean up the list as they see fit. Either that, or default to everything but dispatch - I doubt anyone will want to trigger on that. I'd also like to add some validation to give folks a warning if they add a type that isn't valid for Accurev. I'll work on that while this build runs in my current environment. Thanks for the patch!

            Code changed in hudson
            User: : statlor
            Path:
            trunk/hudson/plugins/accurev/src/main/java/hudson/plugins/accurev/AccurevSCM.java
            trunk/hudson/plugins/accurev/src/main/resources/hudson/plugins/accurev/AccurevSCM/global.jelly
            trunk/hudson/plugins/accurev/src/main/webapp/help/validTransactionTypes.html
            http://fisheye4.cenqua.com/changelog/hudson/?cs=24888
            Log:
            [FIXED JENKINS-3967] Added ability to specify which transaction types trigger a build.

            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in hudson User: : statlor Path: trunk/hudson/plugins/accurev/src/main/java/hudson/plugins/accurev/AccurevSCM.java trunk/hudson/plugins/accurev/src/main/resources/hudson/plugins/accurev/AccurevSCM/global.jelly trunk/hudson/plugins/accurev/src/main/webapp/help/validTransactionTypes.html http://fisheye4.cenqua.com/changelog/hudson/?cs=24888 Log: [FIXED JENKINS-3967] Added ability to specify which transaction types trigger a build.

            People

              statlor Scott Tatum
              jafvert jafvert
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: