Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-40080

All pages make multiple /classes requests

    XMLWordPrintable

Details

    • tethys

    Description

      Not sure why are making multiple calls to {{classes} but this needs to be fixed.

      I've attached a HAR.

      Attachments

        Activity

          tfennelly Tom FENNELLY added a comment -

          FYI, see JENKINS-40768 as something that can help make this happen.

          tfennelly Tom FENNELLY added a comment - FYI, see JENKINS-40768 as something that can help make this happen.
          tfennelly Tom FENNELLY added a comment -

          Seems strange that this JIRA has been pushed out completely and marked as "minor", while the likes of JENKINS-40487 is in and is marked "major". Both of them are essentially the same problem i.e. reducing the number of backend calls that the client-side needs to make.

          I have a tentative fix for this using localStorage, the basis of which I think can be a very useful piece of infra to help us with per domain caching of other things e.g. localization data, maybe CSS, client-side logging levels if we get to doing that right etc etc. In this specific case, it results in the calls for classes to be completely eliminated once the client has loaded and cached that info, with the cache being wiped/invalidated if there's a new Jenkins instance on the backend, or if the plugins change (installs, updates, removals).

          tfennelly Tom FENNELLY added a comment - Seems strange that this JIRA has been pushed out completely and marked as "minor", while the likes of JENKINS-40487 is in and is marked "major". Both of them are essentially the same problem i.e. reducing the number of backend calls that the client-side needs to make. I have a tentative fix for this using localStorage, the basis of which I think can be a very useful piece of infra to help us with per domain caching of other things e.g. localization data, maybe CSS, client-side logging levels if we get to doing that right etc etc. In this specific case, it results in the calls for classes to be completely eliminated once the client has loaded and cached that info, with the cache being wiped/invalidated if there's a new Jenkins instance on the backend, or if the plugins change (installs, updates, removals).
          tfennelly Tom FENNELLY added a comment -

          I pushed the changes I made to https://github.com/jenkinsci/blueocean-plugin/pull/683

          Will stop progress on this now.

          tfennelly Tom FENNELLY added a comment - I pushed the changes I made to https://github.com/jenkinsci/blueocean-plugin/pull/683 Will stop progress on this now.
          michaelneale Michael Neale added a comment - - edited

          I have moved this into review in the sprint, as it looks pretty well done, and in review. Is this related to: https://issues.jenkins-ci.org/browse/JENKINS-39747 possibly?

          michaelneale Michael Neale added a comment - - edited I have moved this into review in the sprint, as it looks pretty well done, and in review. Is this related to: https://issues.jenkins-ci.org/browse/JENKINS-39747 possibly?
          tfennelly Tom FENNELLY added a comment -

          No, I don't see how this could be related to JENKINS-39747.

          tfennelly Tom FENNELLY added a comment - No, I don't see how this could be related to JENKINS-39747 .

          People

            tfennelly Tom FENNELLY
            jamesdumay James Dumay
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: