Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-40472

Crowd2 plugin should allow blanks in parameter 'Restrict groups'

    XMLWordPrintable

    Details

    • Type: Improvement
    • Status: Closed (View Workflow)
    • Priority: Minor
    • Resolution: Fixed
    • Component/s: crowd2-plugin
    • Labels:
    • Environment:
      Crowd2.10.1, Jenkins2.19.4, Crowd2 plugin1.8
    • Similar Issues:

      Description

      The Crowd2 jenkins plugin with version 2.8 has an option 'Restrict groups', allowing multiple groups seperated by commas. But it does not work when group name has preceding or trailing blanks.

      How to reproduce:

      1. Jenkins -> Configure Global Security -> Access Control -> Crowd 2
        fill Restrict groups with
        "jenkins-users, jenkins-job-managers , jenkins-administrators"
      2. Login in Crowd console, create three groups of jenkins-users, jenkins-job-managers and jenkins-administrators, add users in the groups.
      3. Login in Jenkins, users in group jenkins-users will succeed, but not that in group jenkins-job-managers and jenkins-administrators.
      4. Change Restrict groups to 'jenkins-users,jenkins-job-managers,jenkins-administrators' and all users would login in successfully.

      Since Crowd does not allow creating groups with blanks in group name, the Crowd2 plugin may safely ignore blanks in the Restrict group parameter.

        Attachments

          Issue Links

            Activity

            Hide
            oleg_nenashev Oleg Nenashev added a comment -
            Show
            oleg_nenashev Oleg Nenashev added a comment - Removing the assignee according to https://groups.google.com/forum/#!topic/jenkinsci-dev/sFejhRvZiIM
            Hide
            pingunaut Martin Spielmann added a comment -

            Hi Zhenlei Huang

            version 2.0.0-beta1 has just been released and should be available soon in the Experimental Update Center.

            Works on my machineā„¢, but would be great if you could give it a try and check if it works as expected before the final release. Here's how to configure the Experimental Update Center https://jenkins.io/doc/developer/publishing/releasing-experimental-updates/

            Show
            pingunaut Martin Spielmann added a comment - Hi Zhenlei Huang version 2.0.0-beta1 has just been released and should be available soon in the Experimental Update Center. Works on my machineā„¢, but would be great if you could give it a try and check if it works as expected before the final release. Here's how to configure the Experimental Update Center https://jenkins.io/doc/developer/publishing/releasing-experimental-updates/
            Hide
            gmshake Zhenlei Huang added a comment - - edited

            Martin Spielmann Nice job
            I'll try and report back later.

            Show
            gmshake Zhenlei Huang added a comment - - edited Martin Spielmann Nice job I'll try and report back later.
            Hide
            gmshake Zhenlei Huang added a comment -

            Hi Martin Spielmann,

            I've tried 2.0.0-beta1. It works as version 1.8 but there're some issues with SSO and plugin dependencies. I'll open new tickets for these.

            Show
            gmshake Zhenlei Huang added a comment - Hi Martin Spielmann , I've tried 2.0.0-beta1. It works as version 1.8 but there're some issues with SSO and plugin dependencies. I'll open new tickets for these.
            Hide
            pingunaut Martin Spielmann added a comment -

            Hi Zhenlei Huang,

            based on your try, I would consider releasing 2.0.0 during the next days. Are the issues with SSO and plugin dependencies new ones or were they already existing in 1.8?

            Show
            pingunaut Martin Spielmann added a comment - Hi Zhenlei Huang , based on your try, I would consider releasing 2.0.0 during the next days. Are the issues with SSO and plugin dependencies new ones or were they already existing in 1.8?
            Hide
            gmshake Zhenlei Huang added a comment -

            Martin Spielmann Plugin dependency issue was introduced in 2.0.0-beta1. SSO ones exist in 1.8.

            Show
            gmshake Zhenlei Huang added a comment - Martin Spielmann Plugin dependency issue was introduced in 2.0.0-beta1. SSO ones exist in 1.8.
            Hide
            pingunaut Martin Spielmann added a comment -

            Alright, then I'll rather wait for your report instead of introducing a new issue with 2.0.0

            Thanks a lot for your help!

            Show
            pingunaut Martin Spielmann added a comment - Alright, then I'll rather wait for your report instead of introducing a new issue with 2.0.0 Thanks a lot for your help!
            Show
            gmshake Zhenlei Huang added a comment - Martin Spielmann PR created. https://github.com/jenkinsci/crowd2-plugin/pull/24

              People

              Assignee:
              pingunaut Martin Spielmann
              Reporter:
              gmshake Zhenlei Huang
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved: