Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-40662

Deep-linking to Run Details screen with no tab specified causes problem when closing modal

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Fixed
    • Icon: Major Major
    • blueocean-plugin
    • None
    • tethys, christmas

      Repro Steps:

      1. Deep link to a run details URL without specifying a tab, e.g. https://ci.blueocean.io/blue/organizations/jenkins/blueocean/detail/task%2FJENKINS-40256-integrate-new-form-controls/2
      2. Close the modal

      Expected behavior:

      1. Activity tab displays recent runs

      Actual behavior:

      1. Header is displayed but there is no content beneath it

      Dev notes:
      This only happens when deeplinking to the general URL for the run without specifying a tab (e.g. /pipeline , /changes , etc). The UI issues a redirect to /pipeline but after closing the modal it doesn't update the URL correctly.

      We need to make the logic a bit more robust:

      1. May want to check history length when making determination on whether to go back or navigate to fallback URL
      2. May want to use history navigation rather than relying on the "opener URL"
      3. If possible, add a new API that simply "goes back" so that individual screens don't need to manage this. Creation flow could also use this.

            cliffmeyers Cliff Meyers
            cliffmeyers Cliff Meyers
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Created:
              Updated:
              Resolved: