Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-41279

bfa graphs apear below the bottom of the left sidebard instead of the left side

    XMLWordPrintable

    Details

    • Similar Issues:

      Description

      It seems that graphs from the BFA stats page are wrapped down below the bottom margin of the left sidebar, instead of being on the right side of the bottom bar.

      This happens even when the browser (Chrome) window is maximized on a 13" MacBook (Retina 2560 x 1600 Retina) and makes you think that the graph page is completely empty. In fact the graphs are much lower on the page because they were wrapped due to incorrect CSS code.

        Attachments

          Activity

          Hide
          ssbarnea Sorin Sbarnea added a comment -

          To be exact what is causing this bug is the presence of the BR-clear-both after the headers. Removal of this full break does fix this unneeded wrapping.

          See http://take.ms/tfE0p

          Show
          ssbarnea Sorin Sbarnea added a comment - To be exact what is causing this bug is the presence of the BR-clear-both after the headers. Removal of this full break does fix this unneeded wrapping. See http://take.ms/tfE0p
          Hide
          ssbarnea Sorin Sbarnea added a comment -

          I am not sure if I should also mention that the graphs looks very primitive and they do not support retina display. One quick fix should be to double the resolution of the images but keeping their HTML size the same. A longer term solution may be to switch to use JS to render the data.

          It is quite sad that such a useful plugin lacks so much in the presentation area. I am ready to bet that at least 2/3 users that end-up on the stats screen do leave the page assuming that is broken (when in fact the graphs are just at the bottom of the page).

          Show
          ssbarnea Sorin Sbarnea added a comment - I am not sure if I should also mention that the graphs looks very primitive and they do not support retina display. One quick fix should be to double the resolution of the images but keeping their HTML size the same. A longer term solution may be to switch to use JS to render the data. It is quite sad that such a useful plugin lacks so much in the presentation area. I am ready to bet that at least 2/3 users that end-up on the stats screen do leave the page assuming that is broken (when in fact the graphs are just at the bottom of the page).
          Hide
          ssbarnea Sorin Sbarnea added a comment -
          Show
          ssbarnea Sorin Sbarnea added a comment - I made a PR for fixing this issue https://github.com/jenkinsci/build-failure-analyzer-plugin/pull/63
          Hide
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Sorin Sbarnea
          Path:
          src/main/resources/com/sonyericsson/jenkins/plugins/bfa/BfaGraphAction/detailedgraphs.groovy
          http://jenkins-ci.org/commit/build-failure-analyzer-plugin/156a200511ed853ca11f7f6cfa9fc12170fde8b6
          Log:
          JENKINS-41279: Fixed broken div wrapping

          Show
          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Sorin Sbarnea Path: src/main/resources/com/sonyericsson/jenkins/plugins/bfa/BfaGraphAction/detailedgraphs.groovy http://jenkins-ci.org/commit/build-failure-analyzer-plugin/156a200511ed853ca11f7f6cfa9fc12170fde8b6 Log: JENKINS-41279 : Fixed broken div wrapping
          Hide
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Tomas Westling
          Path:
          src/main/resources/com/sonyericsson/jenkins/plugins/bfa/BfaGraphAction/detailedgraphs.groovy
          http://jenkins-ci.org/commit/build-failure-analyzer-plugin/b9f62986b4f8136b568e971b68dd4f426d1402cf
          Log:
          Merge pull request #63 from ssbarnea/clear-both

          JENKINS-41279: Fixed broken div wrapping

          Compare: https://github.com/jenkinsci/build-failure-analyzer-plugin/compare/c31d55ad8caa...b9f62986b4f8

          Show
          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Tomas Westling Path: src/main/resources/com/sonyericsson/jenkins/plugins/bfa/BfaGraphAction/detailedgraphs.groovy http://jenkins-ci.org/commit/build-failure-analyzer-plugin/b9f62986b4f8136b568e971b68dd4f426d1402cf Log: Merge pull request #63 from ssbarnea/clear-both JENKINS-41279 : Fixed broken div wrapping Compare: https://github.com/jenkinsci/build-failure-analyzer-plugin/compare/c31d55ad8caa...b9f62986b4f8

            People

            Assignee:
            ssbarnea Sorin Sbarnea
            Reporter:
            ssbarnea Sorin Sbarnea
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved: