Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-4330

Launcher is NULL in SCM.pollChanges() method. Regression

    XMLWordPrintable

Details

    • Bug
    • Status: Closed (View Workflow)
    • Major
    • Resolution: Won't Fix
    • other
    • None
    • Platform: All, OS: All

    Description

      It seems that the Launcher argument in SCM.pollChanges() is null, which makes it
      impossible to poll as the TFS server polls through command line.

      I have a test project that is setup with TFS, and to be built on a node; and it
      will throw the below exception in the console when it is trying to poll.

      I have tested 1.321, 1.322-SNAPSHOT (28 aug 9:00 GMT) and both of them has this
      problem. If I revert to Hudson 1.317, then the issue does not occur UNLESS the
      node isnt started.

      But for 1.318+, even if the node is started and had successful builds on it, I
      still get launcher=null in the poll method.

      -----------------------------------------------------------
      INFO: Starting poll project=hudson.model.FreeStyleProject@183eae7[Polling 321],
      launcher=null, workspace=null, listener=
      hudson.util.StreamTaskListener@1a7a05
      2009-aug-28 10:21:11 hudson.triggers.SCMTrigger$Runner runPolling
      ALLVARLIG: Failed to record SCM polling
      java.lang.NullPointerException
      at hudson.plugins.tfs.TfTool.execute(TfTool.java:99)
      at hudson.plugins.tfs.model.Server.execute(Server.java:47)
      at hudson.plugins.tfs.model.Project.getDetailedHistory(Project.java:41)
      at
      hudson.plugins.tfs.TeamFoundationServerScm.pollChanges(TeamFoundationServerScm.j
      ava:188)
      at hudson.model.AbstractProject.pollSCMChanges(AbstractProject.java:975)
      at hudson.triggers.SCMTrigger$Runner.runPolling(SCMTrigger.java:312)
      at hudson.triggers.SCMTrigger$Runner.run(SCMTrigger.java:339)
      at
      hudson.util.SequentialExecutionQueue$QueueEntry.run(SequentialExecutionQueue.jav
      a:114)
      at
      java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:441)
      at java.util.concurrent.FutureTask$Sync.innerRun(FutureTask.java:303)
      at java.util.concurrent.FutureTask.run(FutureTask.java:138)
      at
      java.util.concurrent.ThreadPoolExecutor$Worker.runTask(ThreadPoolExecutor.java:8
      85)
      at
      java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:907)
      at java.lang.Thread.run(Thread.java:619)
      -----------------------------------------------------------

      Attachments

        Issue Links

          Activity

            huybrechts huybrechts added a comment -

            Your SCM has requiresWorkspaceForPolling == false.
            Hudson uses a workspace for creating a launcher and if there is no workspace
            there will be no launcher. This has been the case for a long time, but I think
            what changed recently is that Hudson won't even try to create a launcher when
            you say you don't need a workspace.

            huybrechts huybrechts added a comment - Your SCM has requiresWorkspaceForPolling == false. Hudson uses a workspace for creating a launcher and if there is no workspace there will be no launcher. This has been the case for a long time, but I think what changed recently is that Hudson won't even try to create a launcher when you say you don't need a workspace.
            redsolo redsolo added a comment -

            Oh, to me it was not a clear relationship between the workspace and a launcher.
            How come the code, for creating a launcher, was removed?

            I see now that the javadoc has been updated to state it doesnt deliver a launcher.
            Ok, i guess i have to fix the tfs plugin

            redsolo redsolo added a comment - Oh, to me it was not a clear relationship between the workspace and a launcher. How come the code, for creating a launcher, was removed? I see now that the javadoc has been updated to state it doesnt deliver a launcher. Ok, i guess i have to fix the tfs plugin
            redsolo redsolo added a comment -

            Closed as this is a needed API change.

            redsolo redsolo added a comment - Closed as this is a needed API change.

            People

              Unassigned Unassigned
              redsolo redsolo
              Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: