[JENKINS-4369] Workspace relocation check false positivities - Jenkins Jira

XML

Word

Printable

Details

Type: Bug
Status: Resolved (View Workflow)
Priority: Major
Resolution: Fixed
Component/s: accurev-plugin
Labels:
- accurev
Environment:
Platform: All, OS: All

Similar Issues:

Show

Description

In case of hostname with at least one upper case letter plugin will do workspace
relocation every build:

Relocating workspace...
Old host: somehostname
New host: SomeHostname

This creates a lot of "chws" SCM transactions in AccuRev history.

Also on Win slaves drive name shall be also ignored:

Old storage: w:\hudson_home\jobs\test\workspace
New storage: W:\hudson_home\jobs\test\workspace

Attachments

- Sort By Name
- Sort By Date
- Ascending
- Descending
- Thumbnails
- List
- Download All

hudson_accurev_ignorecase.diff
1 kB
2009-09-01 08:03

Activity

Ascending order - Click to sort in descending order

Dmitry Nezhevenko added a comment - 2009-09-01 08:03

Created an attachment (id=881)
Reference fix

Dmitry Nezhevenko added a comment - 2009-09-01 08:03 Created an attachment (id=881) Reference fix

Pete Freeman added a comment - 2012-06-04 11:32

I have seen this happen when there is a case difference on the machine name too.

Pete Freeman added a comment - 2012-06-04 11:32 I have seen this happen when there is a case difference on the machine name too.

Dmitry Nezhevenko added a comment - 2012-06-04 11:53

Hi,

I (original reporter) don't care about Hudson/Jenkins anymore, since we've switched away to another CI system.

Possible patch for this is attached. I'm not sure but it's probably still valid (maybe with some minor changes).

Dmitry Nezhevenko added a comment - 2012-06-04 11:53 Hi, I (original reporter) don't care about Hudson/Jenkins anymore, since we've switched away to another CI system. Possible patch for this is attached. I'm not sure but it's probably still valid (maybe with some minor changes).

Anton Feoktistov added a comment - 2014-01-17 12:44

Hi,

with permission of Dmitry Nezhevenko, I'll try to push this fix to the main stream

Anton Feoktistov added a comment - 2014-01-17 12:44 Hi, with permission of Dmitry Nezhevenko, I'll try to push this fix to the main stream

SCM/JIRA link daemon added a comment - 2016-08-28 14:38

Code changed in jenkins
User: Joseph
Path:
.gitignore
pom.xml
src/main/java/hudson/plugins/accurev/AccurevChangeLogSet.java
src/main/java/hudson/plugins/accurev/AccurevLauncher.java
src/main/java/hudson/plugins/accurev/AccurevMode.java
src/main/java/hudson/plugins/accurev/AccurevSCM.java
src/main/java/hudson/plugins/accurev/AccurevStream.java
src/main/java/hudson/plugins/accurev/AccurevTransaction.java
src/main/java/hudson/plugins/accurev/ByteArrayStream.java
src/main/java/hudson/plugins/accurev/CheckForChanges.java
src/main/java/hudson/plugins/accurev/DetermineRemoteHostname.java
src/main/java/hudson/plugins/accurev/FindAccurevClientExe.java
src/main/java/hudson/plugins/accurev/ParseChangeLog.java
src/main/java/hudson/plugins/accurev/PopulateStreams.java
src/main/java/hudson/plugins/accurev/PurgeWorkspaceContents.java
src/main/java/hudson/plugins/accurev/PurgeWorkspaceOverlaps.java
src/main/java/hudson/plugins/accurev/XmlConsolidateStreamChangeLog.java
src/main/java/hudson/plugins/accurev/XmlParserFactory.java
src/main/java/hudson/plugins/accurev/cmd/ChangeLogCmd.java
src/main/java/hudson/plugins/accurev/cmd/Command.java
src/main/java/hudson/plugins/accurev/cmd/History.java
src/main/java/hudson/plugins/accurev/cmd/JustAccurev.java
src/main/java/hudson/plugins/accurev/cmd/Login.java
src/main/java/hudson/plugins/accurev/cmd/PopulateCmd.java
src/main/java/hudson/plugins/accurev/cmd/SetProperty.java
src/main/java/hudson/plugins/accurev/cmd/ShowDepots.java
src/main/java/hudson/plugins/accurev/cmd/ShowStreams.java
src/main/java/hudson/plugins/accurev/cmd/Update.java
src/main/java/hudson/plugins/accurev/delegates/AbstractModeDelegate.java
src/main/java/hudson/plugins/accurev/delegates/ReftreeDelegate.java
src/main/java/hudson/plugins/accurev/delegates/Relocation.java
src/main/java/hudson/plugins/accurev/delegates/SnapshotDelegate.java
src/main/java/hudson/plugins/accurev/delegates/StreamDelegate.java
src/main/java/hudson/plugins/accurev/delegates/WorkspaceDelegate.java
src/main/java/hudson/plugins/accurev/parsers/output/ParseInfoToLoginName.java
src/main/java/hudson/plugins/accurev/parsers/output/ParseLastFewLines.java
src/main/java/hudson/plugins/accurev/parsers/output/ParseOutputToFile.java
src/main/java/hudson/plugins/accurev/parsers/output/ParsePopulate.java
src/main/java/hudson/plugins/accurev/parsers/xml/ParseGetConfig.java
src/main/java/hudson/plugins/accurev/parsers/xml/ParseHistory.java
src/main/java/hudson/plugins/accurev/parsers/xml/ParseLsRules.java
src/main/java/hudson/plugins/accurev/parsers/xml/ParseRefTreeExternalFile.java
src/main/java/hudson/plugins/accurev/parsers/xml/ParseShowReftrees.java
src/main/java/hudson/plugins/accurev/parsers/xml/ParseShowStreams.java
src/main/java/hudson/plugins/accurev/parsers/xml/ParseShowWorkspaces.java
src/main/java/hudson/plugins/accurev/parsers/xml/ParseStatOverlaps.java
src/main/java/hudson/plugins/jetty/security/Password.java
src/main/resources/hudson/plugins/accurev/AccurevChangeLogSet/digest.jelly
src/main/resources/hudson/plugins/accurev/AccurevChangeLogSet/index.jelly
src/main/resources/hudson/plugins/accurev/AccurevSCM/config.jelly
src/main/resources/hudson/plugins/accurev/AccurevSCM/global.jelly
src/main/resources/index.jelly
http://jenkins-ci.org/commit/accurev-plugin/53d62927bc9a0a07a3c2a286ab3b3d1e89a183b5
Log:
Code cleanup, Jenkins-4369 FIX, Log spamming, Javadoc (#25)

ignore intellij

fixed failing test

Test needed jelly escape by default set to true

Override not allowed on interface method

Override is not allowed when implementing interface method

~~JENKINS-4369~~ Fix - Workspace relocation check false positivities

https://github.com/jenkinsci/accurev-plugin/pull/11

Spamming log

Uncessary cast

Unused import

Redundant modifier

Unnecessary boxing

for loop instead of while.

Redundant modifier

First stab at updating to 2.7 LTS

Still need a few more deprecation warning to go away.

Fix unchecked

Try with Resource

Collapsed catch

Forgot to remove redundant cast

Diamond types

Code cleanup and unused imports

Proper comment

First fix to JavaDoc

Javadoc only

Findbugs: Garbage collection call it bad

FindBug: Method call passes null for non-null parameter

FindBugs: Reliance on default encoding

more idea ignore

All FindBugs, fixed.

Update .gitignore

Target java 1.8

FindBugs null pointer

Possible null pointer dereference due to return value of called method
Also optimise import

Some more and some less null pointer

Please pass already :smile:

FindBug dance :tada:

deprecation warnings cleared, some more code cleanup.

Tested on Jenkins 2.7

Bumping to 2.13 jenkins plugin

Last touch :tada:

Last one, installation path on macOS :apple:

MacOS default installation with the anywhere installer is now on
Applications/AccuRev.

Unused dependency?

unused import

bump plugin versions

update maintainer

prepare for 0.7.0 release

SCM/JIRA link daemon added a comment - 2016-08-28 14:38 Code changed in jenkins User: Joseph Path: .gitignore pom.xml src/main/java/hudson/plugins/accurev/AccurevChangeLogSet.java src/main/java/hudson/plugins/accurev/AccurevLauncher.java src/main/java/hudson/plugins/accurev/AccurevMode.java src/main/java/hudson/plugins/accurev/AccurevSCM.java src/main/java/hudson/plugins/accurev/AccurevStream.java src/main/java/hudson/plugins/accurev/AccurevTransaction.java src/main/java/hudson/plugins/accurev/ByteArrayStream.java src/main/java/hudson/plugins/accurev/CheckForChanges.java src/main/java/hudson/plugins/accurev/DetermineRemoteHostname.java src/main/java/hudson/plugins/accurev/FindAccurevClientExe.java src/main/java/hudson/plugins/accurev/ParseChangeLog.java src/main/java/hudson/plugins/accurev/PopulateStreams.java src/main/java/hudson/plugins/accurev/PurgeWorkspaceContents.java src/main/java/hudson/plugins/accurev/PurgeWorkspaceOverlaps.java src/main/java/hudson/plugins/accurev/XmlConsolidateStreamChangeLog.java src/main/java/hudson/plugins/accurev/XmlParserFactory.java src/main/java/hudson/plugins/accurev/cmd/ChangeLogCmd.java src/main/java/hudson/plugins/accurev/cmd/Command.java src/main/java/hudson/plugins/accurev/cmd/History.java src/main/java/hudson/plugins/accurev/cmd/JustAccurev.java src/main/java/hudson/plugins/accurev/cmd/Login.java src/main/java/hudson/plugins/accurev/cmd/PopulateCmd.java src/main/java/hudson/plugins/accurev/cmd/SetProperty.java src/main/java/hudson/plugins/accurev/cmd/ShowDepots.java src/main/java/hudson/plugins/accurev/cmd/ShowStreams.java src/main/java/hudson/plugins/accurev/cmd/Update.java src/main/java/hudson/plugins/accurev/delegates/AbstractModeDelegate.java src/main/java/hudson/plugins/accurev/delegates/ReftreeDelegate.java src/main/java/hudson/plugins/accurev/delegates/Relocation.java src/main/java/hudson/plugins/accurev/delegates/SnapshotDelegate.java src/main/java/hudson/plugins/accurev/delegates/StreamDelegate.java src/main/java/hudson/plugins/accurev/delegates/WorkspaceDelegate.java src/main/java/hudson/plugins/accurev/parsers/output/ParseInfoToLoginName.java src/main/java/hudson/plugins/accurev/parsers/output/ParseLastFewLines.java src/main/java/hudson/plugins/accurev/parsers/output/ParseOutputToFile.java src/main/java/hudson/plugins/accurev/parsers/output/ParsePopulate.java src/main/java/hudson/plugins/accurev/parsers/xml/ParseGetConfig.java src/main/java/hudson/plugins/accurev/parsers/xml/ParseHistory.java src/main/java/hudson/plugins/accurev/parsers/xml/ParseLsRules.java src/main/java/hudson/plugins/accurev/parsers/xml/ParseRefTreeExternalFile.java src/main/java/hudson/plugins/accurev/parsers/xml/ParseShowReftrees.java src/main/java/hudson/plugins/accurev/parsers/xml/ParseShowStreams.java src/main/java/hudson/plugins/accurev/parsers/xml/ParseShowWorkspaces.java src/main/java/hudson/plugins/accurev/parsers/xml/ParseStatOverlaps.java src/main/java/hudson/plugins/jetty/security/Password.java src/main/resources/hudson/plugins/accurev/AccurevChangeLogSet/digest.jelly src/main/resources/hudson/plugins/accurev/AccurevChangeLogSet/index.jelly src/main/resources/hudson/plugins/accurev/AccurevSCM/config.jelly src/main/resources/hudson/plugins/accurev/AccurevSCM/global.jelly src/main/resources/index.jelly http://jenkins-ci.org/commit/accurev-plugin/53d62927bc9a0a07a3c2a286ab3b3d1e89a183b5 Log: Code cleanup, Jenkins-4369 FIX, Log spamming, Javadoc (#25) ignore intellij fixed failing test Test needed jelly escape by default set to true Override not allowed on interface method Override is not allowed when implementing interface method JENKINS-4369 Fix - Workspace relocation check false positivities https://github.com/jenkinsci/accurev-plugin/pull/11 Spamming log Uncessary cast Unused import Redundant modifier Unnecessary boxing for loop instead of while. Redundant modifier First stab at updating to 2.7 LTS Still need a few more deprecation warning to go away. Fix unchecked Try with Resource Collapsed catch Forgot to remove redundant cast Diamond types Code cleanup and unused imports Proper comment First fix to JavaDoc Javadoc only Findbugs: Garbage collection call it bad FindBug: Method call passes null for non-null parameter FindBugs: Reliance on default encoding more idea ignore All FindBugs, fixed. Update .gitignore Target java 1.8 FindBugs null pointer Possible null pointer dereference due to return value of called method Also optimise import Some more and some less null pointer Please pass already :smile: FindBug dance :tada: deprecation warnings cleared, some more code cleanup. Tested on Jenkins 2.7 Bumping to 2.13 jenkins plugin Last touch :tada: Last one, installation path on macOS :apple: MacOS default installation with the anywhere installer is now on Applications/AccuRev. Unused dependency? unused import bump plugin versions update maintainer prepare for 0.7.0 release

SCM/JIRA link daemon added a comment - 2016-08-28 15:09

Code changed in jenkins
User: Joseph 'Casz' Petersen
Path:
src/main/java/hudson/plugins/accurev/delegates/ReftreeDelegate.java
src/main/java/hudson/plugins/accurev/delegates/WorkspaceDelegate.java
http://jenkins-ci.org/commit/accurev-plugin/c825f7c2d4ca68630ae9e6e6517f080e7729031d
Log:
~~JENKINS-4369~~ Fix - Workspace relocation check false positivities

https://github.com/jenkinsci/accurev-plugin/pull/11

SCM/JIRA link daemon added a comment - 2016-08-28 15:09 Code changed in jenkins User: Joseph 'Casz' Petersen Path: src/main/java/hudson/plugins/accurev/delegates/ReftreeDelegate.java src/main/java/hudson/plugins/accurev/delegates/WorkspaceDelegate.java http://jenkins-ci.org/commit/accurev-plugin/c825f7c2d4ca68630ae9e6e6517f080e7729031d Log: JENKINS-4369 Fix - Workspace relocation check false positivities https://github.com/jenkinsci/accurev-plugin/pull/11

Joseph Petersen (old) added a comment - 2016-08-29 13:14

This should be resolved 0.7.0.

Joseph Petersen (old) added a comment - 2016-08-29 13:14 This should be resolved 0.7.0.

People

Assignee:: Joseph Petersen

Reporter:: Dmitry Nezhevenko

Votes:: 1 Vote for this issue

Watchers:: 4 Start watching this issue

Dates

Created:: 2009-09-01 08:02

Updated:: 2020-03-07 06:06

Resolved:: 2016-08-29 13:14