-
Bug
-
Resolution: Fixed
-
Minor
-
None
The documentation for SecretBytes talks about using Base64, however it is not tolerant of valid Base64 input (RFC 2048)
The RFC says that lines should be a maximum of 76 characters and separated by \r\n
however when given an input with \r\n the jcifs base64 decoder blows up.
The class should be tollerant of varying different forms of Base64.
- ones without line wrapping
- ones with valid line wrapping
- ones with line wrapping but using \n (invalid but produced by xstream)
infact the use of base64 in this plugin is just crazy - 3 different libraries are in use for base64
- com.trilead.ssh2.crypto.Base64 (CertificateCredentialsImpl.java)
- hudson.remoting.Base64 (SecretBytesTest.java)
- jcifs.util.Base64 (SecretBytes.java
- links to