Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-45456

Reduce Java warnings in plugin source-code

    XMLWordPrintable

Details

    Description

      Currently the plugin shows some Java warnings in the source code of the plugin. It would be nice to have those removed or at least reduced.

      Background: I was patching the source code of the plugin to add an feature. Therefore I also reduced (one is still missing) the Java warnings in the source code.

      Those are of the type: Unused imports, unused variable, deprecated Hudson.getInstance(), missing UUID, missing option in switch.

      As I wanted to share the work I will add an pull-request for this issue.

      Attachments

        Activity

          Code changed in jenkins
          User: Michael Musenbrock
          Path:
          src/main/java/hudson/plugins/android_emulator/AndroidEmulator.java
          src/main/java/hudson/plugins/android_emulator/TaskDispatcher.java
          src/main/java/hudson/plugins/android_emulator/builder/AbstractBuilder.java
          src/main/java/hudson/plugins/android_emulator/builder/UpdateProjectBuilder.java
          src/main/java/hudson/plugins/android_emulator/monkey/MonkeyRecorder.java
          src/main/java/hudson/plugins/android_emulator/snapshot/SnapshotLoadBuilder.java
          src/main/java/hudson/plugins/android_emulator/snapshot/SnapshotSaveBuilder.java
          src/main/java/hudson/plugins/android_emulator/util/Utils.java
          src/main/java/hudson/plugins/android_emulator/util/ValidationResult.java
          http://jenkins-ci.org/commit/android-emulator-plugin/8224c8a6d8cc35062c3b9889c5c3262c8995fdfa
          Log:
          [FIXED JENKINS-45456] Reduce Java warnings of the plugin and remove use of deprecated Hudson.getInstance()

          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Michael Musenbrock Path: src/main/java/hudson/plugins/android_emulator/AndroidEmulator.java src/main/java/hudson/plugins/android_emulator/TaskDispatcher.java src/main/java/hudson/plugins/android_emulator/builder/AbstractBuilder.java src/main/java/hudson/plugins/android_emulator/builder/UpdateProjectBuilder.java src/main/java/hudson/plugins/android_emulator/monkey/MonkeyRecorder.java src/main/java/hudson/plugins/android_emulator/snapshot/SnapshotLoadBuilder.java src/main/java/hudson/plugins/android_emulator/snapshot/SnapshotSaveBuilder.java src/main/java/hudson/plugins/android_emulator/util/Utils.java src/main/java/hudson/plugins/android_emulator/util/ValidationResult.java http://jenkins-ci.org/commit/android-emulator-plugin/8224c8a6d8cc35062c3b9889c5c3262c8995fdfa Log: [FIXED JENKINS-45456] Reduce Java warnings of the plugin and remove use of deprecated Hudson.getInstance()

          Code changed in jenkins
          User: Christopher Orr
          Path:
          src/main/java/hudson/plugins/android_emulator/AndroidEmulator.java
          src/main/java/hudson/plugins/android_emulator/TaskDispatcher.java
          src/main/java/hudson/plugins/android_emulator/builder/AbstractBuilder.java
          src/main/java/hudson/plugins/android_emulator/builder/UpdateProjectBuilder.java
          src/main/java/hudson/plugins/android_emulator/monkey/MonkeyRecorder.java
          src/main/java/hudson/plugins/android_emulator/snapshot/SnapshotLoadBuilder.java
          src/main/java/hudson/plugins/android_emulator/snapshot/SnapshotSaveBuilder.java
          src/main/java/hudson/plugins/android_emulator/util/Utils.java
          src/main/java/hudson/plugins/android_emulator/util/ValidationResult.java
          http://jenkins-ci.org/commit/android-emulator-plugin/779118b40a4753e6d1963c47b1a3d6349e4932e0
          Log:
          Merge pull request #67 from redeamer/reduce-java-warnings

          [FIXED JENKINS-45456] Reduce Java warnings of the plugin and remove u…

          Compare: https://github.com/jenkinsci/android-emulator-plugin/compare/2c5a6464c746...779118b40a47

          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Christopher Orr Path: src/main/java/hudson/plugins/android_emulator/AndroidEmulator.java src/main/java/hudson/plugins/android_emulator/TaskDispatcher.java src/main/java/hudson/plugins/android_emulator/builder/AbstractBuilder.java src/main/java/hudson/plugins/android_emulator/builder/UpdateProjectBuilder.java src/main/java/hudson/plugins/android_emulator/monkey/MonkeyRecorder.java src/main/java/hudson/plugins/android_emulator/snapshot/SnapshotLoadBuilder.java src/main/java/hudson/plugins/android_emulator/snapshot/SnapshotSaveBuilder.java src/main/java/hudson/plugins/android_emulator/util/Utils.java src/main/java/hudson/plugins/android_emulator/util/ValidationResult.java http://jenkins-ci.org/commit/android-emulator-plugin/779118b40a4753e6d1963c47b1a3d6349e4932e0 Log: Merge pull request #67 from redeamer/reduce-java-warnings [FIXED JENKINS-45456] Reduce Java warnings of the plugin and remove u… Compare: https://github.com/jenkinsci/android-emulator-plugin/compare/2c5a6464c746...779118b40a47

          Released in 3.0.

          orrc Christopher Orr added a comment - Released in 3.0.

          People

            orrc Christopher Orr
            redeamer Michael Musenbrock
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: