Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-50318

Refusing to marshal com.google.common.util.concurrent.SettableFuture

    XMLWordPrintable

    Details

    • Similar Issues:

      Description

      To reproduce:
      1. Open /computer/(master)/configure
      2. Hit "Save"

      Possibly as a prerequisite, `EC2FleetCloud#plannedNodes` may need to have some entries (so that `SettableFuture`s exist), e.g. by setting up a cloud, and filling the build queue, so that some nodes start to become provisioned.

      Mar 21, 2018 1:07:23 PM WARNING jenkins.security.ClassFilterImpl lambda$isBlacklisted$1
      com.google.common.util.concurrent.SettableFuture in file:/var/jenkins_home/war/WEB-INF/lib/guava-11.0.1.jar might be dangerous, so rejecting; see https://jenkins.io/redirect/class-filter/
      Mar 21, 2018 1:07:24 PM WARNING org.eclipse.jetty.server.handler.ContextHandler$Context log
      Error while serving https://ci.example.com/computer/(master)/configSubmit
      java.lang.UnsupportedOperationException: Refusing to marshal com.google.common.util.concurrent.SettableFuture for security reasons; see https://jenkins.io/redirect/class-filter/
      	at hudson.util.XStream2$BlacklistedTypesConverter.marshal(XStream2.java:543)
      	at com.thoughtworks.xstream.core.AbstractReferenceMarshaller.convert(AbstractReferenceMarshaller.java:69)
      	at com.thoughtworks.xstream.core.TreeMarshaller.convertAnother(TreeMarshaller.java:58)
      	at com.thoughtworks.xstream.core.AbstractReferenceMarshaller$1.convertAnother(AbstractReferenceMarshaller.java:84)
      	at hudson.util.RobustReflectionConverter.marshallField(RobustReflectionConverter.java:265)
      	at hudson.util.RobustReflectionConverter$2.writeField(RobustReflectionConverter.java:252)
      Caused: java.lang.RuntimeException: Failed to serialize hudson.slaves.NodeProvisioner$PlannedNode#future for class hudson.slaves.NodeProvisioner$PlannedNode
      	at hudson.util.RobustReflectionConverter$2.writeField(RobustReflectionConverter.java:256)
      	at hudson.util.RobustReflectionConverter$2.visit(RobustReflectionConverter.java:224)
      	at com.thoughtworks.xstream.converters.reflection.PureJavaReflectionProvider.visitSerializableFields(PureJavaReflectionProvider.java:138)
      	at hudson.util.RobustReflectionConverter.doMarshal(RobustReflectionConverter.java:209)
      	at hudson.util.RobustReflectionConverter.marshal(RobustReflectionConverter.java:150)
      	at com.thoughtworks.xstream.core.AbstractReferenceMarshaller.convert(AbstractReferenceMarshaller.java:69)
      	at com.thoughtworks.xstream.core.TreeMarshaller.convertAnother(TreeMarshaller.java:58)
      	at com.thoughtworks.xstream.core.TreeMarshaller.convertAnother(TreeMarshaller.java:43)
      	at com.thoughtworks.xstream.core.AbstractReferenceMarshaller$1.convertAnother(AbstractReferenceMarshaller.java:88)
      	at com.thoughtworks.xstream.converters.collections.AbstractCollectionConverter.writeItem(AbstractCollectionConverter.java:64)
      	at com.thoughtworks.xstream.converters.collections.CollectionConverter.marshal(CollectionConverter.java:74)
      	at com.thoughtworks.xstream.core.AbstractReferenceMarshaller.convert(AbstractReferenceMarshaller.java:69)
      	at com.thoughtworks.xstream.core.TreeMarshaller.convertAnother(TreeMarshaller.java:58)
      	at com.thoughtworks.xstream.core.AbstractReferenceMarshaller$1.convertAnother(AbstractReferenceMarshaller.java:84)
      	at hudson.util.RobustReflectionConverter.marshallField(RobustReflectionConverter.java:265)
      	at hudson.util.RobustReflectionConverter$2.writeField(RobustReflectionConverter.java:252)
      Caused: java.lang.RuntimeException: Failed to serialize com.amazon.jenkins.ec2fleet.EC2FleetCloud#plannedNodes for class com.amazon.jenkins.ec2fleet.EC2FleetCloud
      	at hudson.util.RobustReflectionConverter$2.writeField(RobustReflectionConverter.java:256)
      	at hudson.util.RobustReflectionConverter$2.visit(RobustReflectionConverter.java:224)
      	at com.thoughtworks.xstream.converters.reflection.PureJavaReflectionProvider.visitSerializableFields(PureJavaReflectionProvider.java:138)
      	at hudson.util.RobustReflectionConverter.doMarshal(RobustReflectionConverter.java:209)
      	at hudson.util.RobustReflectionConverter.marshal(RobustReflectionConverter.java:150)
        …
      

        Attachments

          Activity

          Hide
          oleg_nenashev Oleg Nenashev added a comment -

          I doubt there is a real need to persist SettableFuture objects on the disk. Will investigate

          Show
          oleg_nenashev Oleg Nenashev added a comment - I doubt there is a real need to persist SettableFuture objects on the disk. Will investigate
          Hide
          oleg_nenashev Oleg Nenashev added a comment -

          I have created https://github.com/jenkinsci/ec2-fleet-plugin/pull/24 , but it is totally untested. Any feedback will be appreciated

          Show
          oleg_nenashev Oleg Nenashev added a comment - I have created https://github.com/jenkinsci/ec2-fleet-plugin/pull/24 , but it is totally untested. Any feedback will be appreciated
          Hide
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Oleg Nenashev
          Path:
          src/main/java/com/amazon/jenkins/ec2fleet/EC2FleetCloud.java
          http://jenkins-ci.org/commit/ec2-fleet-plugin/fd4ffbf5ceac115ae4f064c07f404574344a9c86
          Log:
          JENKINS-50318 - Stop randomly persisting cache objects on the disk

          Show
          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Oleg Nenashev Path: src/main/java/com/amazon/jenkins/ec2fleet/EC2FleetCloud.java http://jenkins-ci.org/commit/ec2-fleet-plugin/fd4ffbf5ceac115ae4f064c07f404574344a9c86 Log: JENKINS-50318 - Stop randomly persisting cache objects on the disk
          Hide
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Chad Schmutzer
          Path:
          Jenkinsfile
          pom.xml
          src/main/java/com/amazon/jenkins/ec2fleet/EC2FleetCloud.java
          http://jenkins-ci.org/commit/ec2-fleet-plugin/08347b9fd2518d8b2f207118e222d35dc48deaef
          Log:
          Merge pull request #24 from oleg-nenashev/JENKINS-50318

          JENKINS-50318 - Stop caching cache objects on the disk

          Compare: https://github.com/jenkinsci/ec2-fleet-plugin/compare/9ac8cc3a55b0...08347b9fd251
          *NOTE:* This service been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/

          Functionality will be removed from GitHub.com on January 31st, 2019.

          Show
          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Chad Schmutzer Path: Jenkinsfile pom.xml src/main/java/com/amazon/jenkins/ec2fleet/EC2FleetCloud.java http://jenkins-ci.org/commit/ec2-fleet-plugin/08347b9fd2518d8b2f207118e222d35dc48deaef Log: Merge pull request #24 from oleg-nenashev/ JENKINS-50318 JENKINS-50318 - Stop caching cache objects on the disk Compare: https://github.com/jenkinsci/ec2-fleet-plugin/compare/9ac8cc3a55b0...08347b9fd251 * NOTE: * This service been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/ Functionality will be removed from GitHub.com on January 31st, 2019.
          Hide
          oleg_nenashev Oleg Nenashev added a comment -

          EC2 Fleet 1.1.6 has been released

          Show
          oleg_nenashev Oleg Nenashev added a comment - EC2 Fleet 1.1.6 has been released

            People

            Assignee:
            oleg_nenashev Oleg Nenashev
            Reporter:
            orrc Christopher Orr
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved: