Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-51934

client should be able to handle failures gracefully when downloading updates

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Resolved (View Workflow)
    • Priority: Minor
    • Resolution: Fixed
    • Component/s: evergreen
    • Labels:
      None
    • Similar Issues:
    • Sprint:
      Evergreen - Milestone 1

      Description

      (node:44) UnhandledPromiseRejectionWarning: Unhandled promise rejection (rejection id: 2): FetchError: request to http://updates.jenkins-ci.org/download/plugins/pipeline-model-api/1.2.9/pipeline-model-api.hpi failed, reason: getaddrinfo EAI_AGAIN updates.jenkins-ci.org:80
      (node:44) [DEP0018] DeprecationWarning: Unhandled promise rejections are deprecated. In the future, promise rejections that are not handled will terminate the Node.js process with a non-zero exit code.
      info: Update already in process..
      
      

      If any of the updates fail to download for any reason, the whole Promise.all fails to execute and the update process fails.

        Attachments

          Issue Links

            Activity

            Hide
            rtyler R. Tyler Croy added a comment -

            I'm going to bounce this to you Baptiste Mathus, I don't care whether you or Mandie Smith tackles this, but I think it's probably going to be fairly important.

            I was researching whether the client's HTTP library should be switched from node-fetch to request-promise for which I was looking at this library to add some retry logic: https://github.com/FGRibreau/node-request-retry

            Show
            rtyler R. Tyler Croy added a comment - I'm going to bounce this to you Baptiste Mathus , I don't care whether you or Mandie Smith tackles this, but I think it's probably going to be fairly important. I was researching whether the client's HTTP library should be switched from node-fetch to request-promise for which I was looking at this library to add some retry logic: https://github.com/FGRibreau/node-request-retry
            Hide
            batmat Baptiste Mathus added a comment -

            Absolutely agree this one is critical. Obviously for end users, but even more currently for us developers as I'm seeing this on my machine pretty often when testing, or in CI, and as of now that means one just has to restart the whole test, which is we know very time consuming.

            Show
            batmat Baptiste Mathus added a comment - Absolutely agree this one is critical. Obviously for end users, but even more currently for us developers as I'm seeing this on my machine pretty often when testing, or in CI, and as of now that means one just has to restart the whole test, which is we know very time consuming.

              People

              Assignee:
              batmat Baptiste Mathus
              Reporter:
              rtyler R. Tyler Croy
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved: