Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-56528

Gerrit trigger 2.29.0 does not trigger jobs

    XMLWordPrintable

Details

    • Bug
    • Status: In Review (View Workflow)
    • Major
    • Resolution: Unresolved
    • gerrit-trigger-plugin
    • None
    • Linux, openjdk 8, Jenkins 2.150.3, gerrit-trigger 2.29.0, gerrit server runs 2.13.7, lots of other plugins.

    Description

      After upgrading yesterday, triggering stopped working today. There is some evidence that triggering did work for a time, but not conclusive.

      I tried restarting Jenkins, then Gerrit. Nothing helped.

      Saw logs of

      Jul 18, 2018 5:07:57 PM com.sonymobile.tools.gerrit.gerritevents.GerritHandler checkQueueSize
      WARNING: The Gerrit incoming events queue contains 28095 items! Something might be stuck, or your system can't process the commands fast enough. Try to increase the number of receiving worker threads. Current thread-pool size: 30 

      (similar to JENKINS-52636), but the whole setup felt more like JENKINS-53738.

      What finally helped was downgrading to 2.28.0 of the plugin. Then triggering started again. I never tried re-saving a job; we have a few too many of those that I want to do that for all of them.

      Attachments

        Issue Links

          Activity

            neonman Max P added a comment -

            Same issue for me,  I think its caused by PR#350. I don't reproduce it on another jenkins instance with same versions of system and plugins. But I was able to collect trace logs from gerrit-plugin for 2.28.0 and incorrect installation of 2.29.0.

            neonman Max P added a comment - Same issue for me,  I think its caused by PR#350. I don't reproduce it on another jenkins instance with same versions of system and plugins. But I was able to collect trace logs from gerrit-plugin for 2.28.0 and incorrect installation of 2.29.0.

            PR#350 is about handling dynamic configuration, and we certainly have that for most of our jobs, so there is that.

            I have no data whether our few statically configured jobs would trigger or not; they run much more rarely than the others.

            pharman Torben Thellefsen added a comment - PR#350 is about handling dynamic configuration, and we certainly have that for most of our jobs, so there is that. I have no data whether our few statically configured jobs would trigger or not; they run much more rarely than the others.
            amdokamal S. Panchenko added a comment -

            Confirmed on Jenkins ver. 2.164.1, Gerrit Trigger 2.29.0. We use groovy-pipeline and dynamicTriggerConfiguration:

            pipelineTriggers([gerrit(customUrl: '', dynamicTriggerConfiguration: true, gerritProjects: [[branches: [[compareType: 'PLAIN', pattern: '']], compareType: 'PLAIN', disableStrictForbiddenFileVerification: false, pattern: '']], serverName: 'some_server.com', triggerConfigURL: 'http://some_server.com/triggers.txt', triggerOnEvents: [patchsetCreated(excludeDrafts: false, excludeNoCodeChange: false, excludeTrivialRebase: false)])]) 

            Re-trigger via +Query and Trigger Gerrit Patche+s doesn't help.

            Workaround: downgrading to Gerrit Trigge 2.28.0.

            amdokamal S. Panchenko added a comment - Confirmed on Jenkins ver. 2.164.1, Gerrit Trigger 2.29.0. We use groovy-pipeline and dynamicTriggerConfiguration: pipelineTriggers([gerrit(customUrl: '', dynamicTriggerConfiguration: true , gerritProjects: [[branches: [[compareType: ' PLAIN ', pattern: ' ']], compareType: ' PLAIN ', disableStrictForbiddenFileVerification: false , pattern: ' ']], serverName: ' some_server.com ', triggerConfigURL: ' http: //some_server.com/triggers.txt', triggerOnEvents: [patchsetCreated(excludeDrafts: false , excludeNoCodeChange: false , excludeTrivialRebase: false )])]) Re-trigger via +Query and Trigger Gerrit Patche+s doesn't help. Workaround : downgrading to Gerrit Trigge 2.28.0.
            georgbremer Georg Bremer added a comment -

            I don't know if it's supposed to work like that, but since I have the rights I assigned the ticket to me because I have a PR with a fix: https://github.com/jenkinsci/gerrit-trigger-plugin/pull/403

            georgbremer Georg Bremer added a comment - I don't know if it's supposed to work like that, but since I have the rights I assigned the ticket to me because I have a PR with a fix:  https://github.com/jenkinsci/gerrit-trigger-plugin/pull/403

            Hi, is there any progress on this?

            Thanks

            ferulee46 Ferruccio Bongianni added a comment - Hi, is there any progress on this? Thanks

            georgbremer version 2.30.0 now contains your fix but there's a very similar issue opened on version 2.30.5: https://issues.jenkins-ci.org/browse/JENKINS-63000. Matching symptoms but apparently more severe, as the only solution is to restart the affected jenkins master node.

            gcimpoies George Cimpoies added a comment - georgbremer version 2.30.0 now contains your fix but there's a very similar issue opened on version 2.30.5:  https://issues.jenkins-ci.org/browse/JENKINS-63000 . Matching symptoms but apparently more severe, as the only solution is to restart the affected jenkins master node.

            People

              georgbremer Georg Bremer
              pharman Torben Thellefsen
              Votes:
              6 Vote for this issue
              Watchers:
              11 Start watching this issue

              Dates

                Created:
                Updated: