Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-6334

Support for displaying changesets in submodule updates

    XMLWordPrintable

Details

    • New Feature
    • Status: Open (View Workflow)
    • Critical
    • Resolution: Unresolved
    • git-plugin
    • None

    Description

      The git plugin should have the option to recursively display all commits made in submodules due to updates. This will show the actual files changed and provides more useful information during a build failure.

      This can be done by using 'git diff-tree' on submodule updates to determine the range of commits in a submodule update.

      NOTE: I have a patch for this will provide this feature, but cannot apply it until issue 6258 is resolved. Please contact me (bvakili@oanda.com) if you'd like me to upload it.

      Attachments

        Issue Links

          Activity

            markewaite Mark Waite added a comment -

            The recent submodule additions were done with specific attention to test automation. I'm still deeply attached to test automation to allow the plugin to be safely released to the 250 000 installations of Jenkins. For me, a pull request to allow inclusion of submodule changes in the changeset would need to:

            • Include tests that confirm the current behavior of not including submodule changes in the changeset (or confirm that there are already tests which verify that)
            • Include tests that confirm the default behavior is to not include submodule changes in the changeset
            • Include tests that enable inclusion of submodule changes in the changeset, including tests for:
              • Repository with no submodules
              • Repository with 1 submodule
              • Repository with more than 1 submodule
              • Repository with 1 submodule which includes another submodule (recursive)
            markewaite Mark Waite added a comment - The recent submodule additions were done with specific attention to test automation. I'm still deeply attached to test automation to allow the plugin to be safely released to the 250 000 installations of Jenkins. For me, a pull request to allow inclusion of submodule changes in the changeset would need to: Include tests that confirm the current behavior of not including submodule changes in the changeset (or confirm that there are already tests which verify that) Include tests that confirm the default behavior is to not include submodule changes in the changeset Include tests that enable inclusion of submodule changes in the changeset, including tests for: Repository with no submodules Repository with 1 submodule Repository with more than 1 submodule Repository with 1 submodule which includes another submodule (recursive)
            timblaktu Tim Black added a comment -

            Thanks for your attention, markewaite. I am not a Java developer, but I've got the experience to make a positive contribution here, at least from the test and integration angle. 

            I looked through the [Beginners Guide To Contributing|https://wiki.jenkins.io/display/JENKINS/Beginners+Guide+to+Contributing], but I'm having trouble finding information on best practices for authoring such tests and for what resources to use for running the tests. The best lead I could find there was mention of [the jenkins-infra project|https://github.com/jenkins-infra/jenkins-infra], which contains configuration management tools that I'm guessing is how tests are expected to be run.

            Am I on the right track? Can you point me to any better docs, or your personal suggestions?

             

            timblaktu Tim Black added a comment - Thanks for your attention, markewaite . I am not a Java developer, but I've got the experience to make a positive contribution here, at least from the test and integration angle.  I looked through the [Beginners Guide To Contributing| https://wiki.jenkins.io/display/JENKINS/Beginners+Guide+to+Contributing ], but I'm having trouble finding information on best practices for authoring such tests and for what resources to use for running the tests. The best lead I could find there was mention of [the jenkins-infra project| https://github.com/jenkins-infra/jenkins-infra ], which contains configuration management tools that I'm guessing is how tests are expected to be run. Am I on the right track? Can you point me to any better docs, or your personal suggestions?  
            markewaite Mark Waite added a comment -

            Usually the best way for me to create tests is to open the source code in the Netbeans integrated development environment, select the class or classes that need tests, then select "Tools" and "Create / Update Tests". It will generate JUnit stubs to test the specific class. The IDE also provides a way to run individual tests and to run all the tests in a specific class.

            markewaite Mark Waite added a comment - Usually the best way for me to create tests is to open the source code in the Netbeans integrated development environment, select the class or classes that need tests, then select "Tools" and "Create / Update Tests". It will generate JUnit stubs to test the specific class. The IDE also provides a way to run individual tests and to run all the tests in a specific class.
            liyatikal liyatikal added a comment - - edited

            timblaktu

            bvakili

            is there any updates on this?

            liyatikal liyatikal added a comment - - edited timblaktu bvakili is there any updates on this?
            timblaktu Tim Black added a comment -

            I ended up generating my own sub-module aware change logs using git command line and diff2html, and posting these as artifacts.

            timblaktu Tim Black added a comment - I ended up generating my own sub-module aware change logs using git command line and diff2html, and posting these as artifacts.

            People

              Unassigned Unassigned
              bvakili bvakili
              Votes:
              30 Vote for this issue
              Watchers:
              32 Start watching this issue

              Dates

                Created:
                Updated: