Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-72335

p4publish step fails when using 'paths' argument with multiple paths and there are no changes.

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Unresolved
    • Icon: Major Major
    • p4-plugin
    • P4 Plugin Version1.13.3

      When using p4publish with multiple paths listed in the `paths` argument, and the workspace doesn't contain any changes compared to the depot, publish will fail with

      Unable to publish workspace: hudson.AbortException: P4JAVA: Error(s):
      No file(s) to reconcile.

      This seems to be a result of a check in ClientHelper.java

      getValidate().check(status, "- no file(s) to reconcile", "instead of", "empty, assuming text", "also opened by");

      which apparently should ignore the p4java status "- no file(s) to reconcile" but when reconciling with multiple paths, the message is "No file(s) to reconcile." - this can be easily tested from the command line:

      > p4 rec foo/...
      foo/... - no file(s) to reconcile.
      > p4 rec foo/... bar/...
      No file(s) to reconcile.

       

      The attached patch changes the ignore string so that it's recognized in both cases, as the check uses StringUtils.containsIgnoreCase(msg, istring) to compare the message with it.

            Unassigned Unassigned
            abannerth Akos
            Votes:
            2 Vote for this issue
            Watchers:
            3 Start watching this issue

              Created:
              Updated: