Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-7659

Git plugin keeps .gitmodules open

    XMLWordPrintable

Details

    • Bug
    • Status: Closed (View Workflow)
    • Critical
    • Resolution: Fixed
    • git-plugin
    • None

    Description

      In GitSCM.getSubmoduleRepository, the Git plugin opens .gitmodules through a BufferedReader, but never closes the BufferedReader.

      In Windows a file can't be modified by anything else while it's open, which means checkouts fail when .gitmodules changes between the old commit and the new commit. Hudson must be restarted to be able to change .gitmodules again.

      The fix seems pretty straight forward.

      Attachments

        Activity

          dogfood dogfood added a comment -

          Integrated in plugins_hudson-git-plugin #29
          JENKINS-7659 Closing .gitmodules BufferedReader now

          Andrew Bayer :
          Files :

          • src/main/java/hudson/plugins/git/GitSCM.java
          dogfood dogfood added a comment - Integrated in plugins_hudson-git-plugin #29 JENKINS-7659 Closing .gitmodules BufferedReader now Andrew Bayer : Files : src/main/java/hudson/plugins/git/GitSCM.java
          abayer Andrew Bayer added a comment -

          Resolved in upcoming release.

          abayer Andrew Bayer added a comment - Resolved in upcoming release.

          People

            abayer Andrew Bayer
            edsrzf edsrzf
            Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: