Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-9954

Messages are mistakenly ignored by jabber-plugin

    XMLWordPrintable

Details

    • Bug
    • Status: Resolved (View Workflow)
    • Major
    • Resolution: Fixed
    • jabber-plugin
    • None
    • Jenkins ver. 1.414
      Jenkins instant-messaging plugin 1.17
      Jenkins Jabber notifier plugin 1.17
      Tkabber 0.11.1

    Description

      Seems that non-xhtml mesages from clients ready to receive events relating to the delivery, display, and composition of messages are erroneously ignored by jabber plugin.

      According to http://xmpp.org/extensions/xep-0022.html (Section 3.1) if message has body and any (or all) of isOffline(), isDelivered(), isComposing(), isDisplayed() flags set to `true', that means that the sender wants to be notified if the message is stored offline (by the server), notified when the message is delivered (to the client), notified if the recipient begins replying to the message and notified when the message is displayed to recipient.

      In case of presence of body element these flags are absolutely unrelated to current state of given message. Additional checks should not be performed.

      Steps to reproduce:
      1. Configure jabber-plugin to use jabber.org server;
      2. Fill in your jid in your jenkins user profile;
      3. Connect to jabber.org using tkabber or gajim jabber client;
      4. Add bot into roster;
      6. Send '!s' to bot in private chat (group chats are not affected by bug in question);
      6. Nothing is received in response.

      Here is raw xml-log of tkabber client:

      ==================
      <message to='jid@jabber.org/Jenkins'
      id='3'
      type='chat'
      xml:lang='en'>
      <x xmlns='jabber:x:event'>
      <offline/>
      <delivered/>
      <displayed/>
      <composing/>
      </x>
      <body>!s</body>
      </message>

      <!-- no xml is received in response to this message -->
      ===================

      Here is output of hudson.plugins.jabber.im logger:

      ===================

      Jun 11, 2011 1:14:00 PM hudson.plugins.jabber.im.transport.JabberConnectionDebugger
      FINE: SENT:

      Jun 11, 2011 1:13:30 PM hudson.plugins.jabber.im.transport.JabberConnectionDebugger
      FINE: SENT:

      Jun 11, 2011 1:13:00 PM hudson.plugins.jabber.im.transport.JabberConnectionDebugger
      FINE: SENT:

      Jun 11, 2011 1:12:30 PM hudson.plugins.jabber.im.transport.JabberConnectionDebugger
      FINE: SENT:

      Jun 11, 2011 1:12:28 PM hudson.plugins.jabber.im.transport.JabberConnectionDebugger
      FINEST: RCV PKT: <message xml:lang="en" id="3" to="jid@jabber.org/Jenkins" from="appr@jabber.org/Home/tkabber" type="chat"><body>!s</body><x xmlns="jabber:x:event"><offline/><delivered/><displayed/><composing/></x></message>

      Jun 11, 2011 1:12:28 PM hudson.plugins.jabber.im.transport.JabberConnectionDebugger
      FINE: RECV: <message from='appr@jabber.org/Home/tkabber' to='jid@jabber.org/Jenkins' type='chat' id='3' xml:lang='en'><x xmlns='jabber:x:event'><offline/><delivered/><displayed/><composing/></x><body>!s</body></message>

      ===================

      Attachments

        Activity

          kutzi kutzi added a comment -

          Thanks, very detailed report!

          I'll look at in when I'm back from holiday.

          kutzi kutzi added a comment - Thanks, very detailed report! I'll look at in when I'm back from holiday.
          kutzi kutzi added a comment -

          Fixed in 1.18.
          Thanks for the fix!

          kutzi kutzi added a comment - Fixed in 1.18. Thanks for the fix!

          People

            kutzi kutzi
            appr appr
            Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: