Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-10585

Radiator View does show builds with test-failure as red rather than yellow on Webkit and Firefox

    XMLWordPrintable

Details

    • Bug
    • Status: Resolved (View Workflow)
    • Major
    • Resolution: Fixed
    • radiatorviewplugin-plugin
    • None
    • * WebKit Browsers (like Chrome), Firefox; Internet Explorer not affected
      * Radiator View Plugin 1.13

    Description

      With Version 1.13 of the Radiator View Plugin Builds with Test Failures are not shown as yellow anylonger but are red. This is true for all WebKit browsers and Firefox browsers because of this CSS entry:

      .failing {
  background-image: -webkit-gradient(...red...);
  background-image: -moz-linear-gradient(...red...);
}

      and the HTML source for reading:

      <div style="background-color:red;" class="job failing normal">Failed Build</div>
<div style="background-color:yellow;" class="job failing normal">Failed Tests</div>

      Thus the gradient overrides the background-color and both jobs are shown as being red.

      Attachments

        Activity

          Ascending order - Click to sort in descending order
          thragor Mark Michaelis created issue -
          thragor Mark Michaelis added a comment -

          Update summary... mixed the order of colors

          thragor Mark Michaelis added a comment - Update summary... mixed the order of colors
          thragor Mark Michaelis made changes -
          Field Original Value New Value
          Summary Radiator View does show builds with test-failure as yellow rather than red on Webkit and Firefox Radiator View does show builds with test-failure as red rather than yellow on Webkit and Firefox
          thragor Mark Michaelis added a comment -

          This patch workarounds the problem by setting the background-image to none as soon as a background-color gets set.

          This might not be the wanted result, but at least the colors are back.

          thragor Mark Michaelis added a comment - This patch workarounds the problem by setting the background-image to none as soon as a background-color gets set. This might not be the wanted result, but at least the colors are back.
          thragor Mark Michaelis made changes -
          Attachment BGColorTestFailures-JENKINS-10585.svn.diff [ 20697 ]
          ryczypisk Michał Chojaczyk added a comment -

          Hi,
          what about change it with this way:
          http://www.red-team-design.com/css3-webkit-gradient-support-updated
          how to check-in the corrected code? I've log/pass accepted by svn server but while committing there is problem. Can someone to test access?
          BR
          Michał

          ryczypisk Michał Chojaczyk added a comment - Hi, what about change it with this way: http://www.red-team-design.com/css3-webkit-gradient-support-updated how to check-in the corrected code? I've log/pass accepted by svn server but while committing there is problem. Can someone to test access? BR Michał
          david_resnick David Resnick made changes -
          Assignee howama [ howama ] David Resnick [ david_resnick ]
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: David Resnick
          Path:
          src/main/java/hudson/model/JobViewEntry.java
          src/main/java/hudson/model/ProjectViewEntry.java
          src/main/resources/hudson/model/RadiatorView/job.jelly
          src/main/resources/hudson/model/RadiatorView/main.jelly
          http://jenkins-ci.org/commit/radiatorview-plugin/394f78e14c85cbf955ad858ffc4390427c137047
          Log:
          Show unstable builds as yellow.

          This is based on pull requests 2 & 7.

          Unstable builds both with and without failing tests appear as yellow.

          One issue with the current implementation is that builds that are unstable
          due to being marked that way (with no failing tests) aren't enlarged as
          broken jobs are.

          [FIXED JENKINS-9772]
          [FIXED JENKINS-10585]
          [FIXED JENKINS-10614]
          [FIXED JENKINS-10846]

          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: David Resnick Path: src/main/java/hudson/model/JobViewEntry.java src/main/java/hudson/model/ProjectViewEntry.java src/main/resources/hudson/model/RadiatorView/job.jelly src/main/resources/hudson/model/RadiatorView/main.jelly http://jenkins-ci.org/commit/radiatorview-plugin/394f78e14c85cbf955ad858ffc4390427c137047 Log: Show unstable builds as yellow. This is based on pull requests 2 & 7. Unstable builds both with and without failing tests appear as yellow. One issue with the current implementation is that builds that are unstable due to being marked that way (with no failing tests) aren't enlarged as broken jobs are. [FIXED JENKINS-9772] [FIXED JENKINS-10585] [FIXED JENKINS-10614] [FIXED JENKINS-10846]
          david_resnick David Resnick made changes -
          Resolution Fixed [ 1 ]
          Status Open [ 1 ] Resolved [ 5 ]
          rtyler R. Tyler Croy made changes -
          Workflow JNJira [ 140779 ] JNJira + In-Review [ 189254 ]

          People

            david_resnick David Resnick
            thragor Mark Michaelis
            Votes:
            2 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: