Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-23683

Jenkins needs to check whether the war's directory is writeable before offering to upgrade

    • Icon: Bug Bug
    • Resolution: Fixed
    • Icon: Major Major
    • core

      Lifecycle#canRewriteHudsonWar assumes in-place replacement of the war, while UpdateCenter#download actually writes to a temporary file first to prevent breaking the file if an error occurs. This can lead to the following exception:

      hudson.util.IOException2: Failed to download from http://updates.jenkins-ci.org/download/war/1.570/jenkins.war (redirected to: http://jenkins.mirror.isppower.de/war/1.570/jenkins.war)
      	at hudson.model.UpdateCenter$UpdateCenterConfiguration.download(UpdateCenter.java:791)
      	at hudson.model.UpdateCenter$DownloadJob._run(UpdateCenter.java:1138)
      	at hudson.model.UpdateCenter$DownloadJob.run(UpdateCenter.java:1116)
      	at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:471)
      	at java.util.concurrent.FutureTask.run(FutureTask.java:262)
      	at hudson.remoting.AtmostOneThreadExecutor$Worker.run(AtmostOneThreadExecutor.java:104)
      	at java.lang.Thread.run(Thread.java:744)
      Caused by: java.io.FileNotFoundException: /usr/lib/jenkins/jenkins.war.tmp (Permission denied)
      	at java.io.FileOutputStream.open(Native Method)
      	at java.io.FileOutputStream.<init>(FileOutputStream.java:221)
      	at java.io.FileOutputStream.<init>(FileOutputStream.java:171)
      	at hudson.model.UpdateCenter$UpdateCenterConfiguration.download(UpdateCenter.java:762)
      	... 6 more

          [JENKINS-23683] Jenkins needs to check whether the war's directory is writeable before offering to upgrade

          Daniel Beck created issue -
          Daniel Beck made changes -
          Status Original: Open [ 1 ] New: In Progress [ 3 ]
          Daniel Beck made changes -
          Remote Link New: This issue links to "PR 1311 (Web Link)" [ 11105 ]
          SCM/JIRA link daemon made changes -
          Resolution New: Fixed [ 1 ]
          Status Original: In Progress [ 3 ] New: Resolved [ 5 ]
          Daniel Beck made changes -
          Labels New: lts-candidate
          Oliver Gondža made changes -
          Labels Original: lts-candidate New: 1.565.2-fixed
          R. Tyler Croy made changes -
          Workflow Original: JNJira [ 156468 ] New: JNJira + In-Review [ 195426 ]

            danielbeck Daniel Beck
            danielbeck Daniel Beck
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Created:
              Updated:
              Resolved: