Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-26186

Last Build Trigger Column does not print author name

      Last Build Trigger Column does not print author name in the trigger column as shown in the plugin webpage. Attached screenshot.

          [JENKINS-26186] Last Build Trigger Column does not print author name

          J John created issue -

          J John added a comment -

          Any update?

          J John added a comment - Any update?

          Hi, just had a look. If you put your mouse over the icon, the title is there.
          Indeed, the text seems to be not there anymore (I didn't see since I don't personally use that very feature).

          Could you tell us a plugin version where it was working, and one when it didn't work anymore? That'd help investigate.

          Even better, file a Pull Request, I promise I'll have look.

          HTH

          Baptiste Mathus added a comment - Hi, just had a look. If you put your mouse over the icon, the title is there. Indeed, the text seems to be not there anymore (I didn't see since I don't personally use that very feature). Could you tell us a plugin version where it was working, and one when it didn't work anymore? That'd help investigate. Even better, file a Pull Request, I promise I'll have look. HTH
          Baptiste Mathus made changes -
          Status Original: Open [ 1 ] New: In Progress [ 3 ]

          Issue reproduced with current version & Jenkins 1.509.4.
          Wondering since when it doesn't work.

          Baptiste Mathus added a comment - Issue reproduced with current version & Jenkins 1.509.4. Wondering since when it doesn't work.

          J John added a comment -

          Can we have the name appear in the trend column as well. Personally, I like seeing the name vs user icon. For rest, icon looks good.

          J John added a comment - Can we have the name appear in the trend column as well. Personally, I like seeing the name vs user icon. For rest, icon looks good.

          Just did a git bisect, and indeed the UI was showing the text at some point :

          $ git bisect log
          git bisect start

          1. bad: [8d31cf754fa4cee0aa905bf9d76315dcd354cafe] [maven-release-plugin] prepare for next development iteration
            git bisect bad 8d31cf754fa4cee0aa905bf9d76315dcd354cafe
          2. good: [4c7adb587fd0d0393d9725844ba258ac7c52bed0] Add column showing icon for last build cause
            git bisect good 4c7adb587fd0d0393d9725844ba258ac7c52bed0
          3. good: [4c7adb587fd0d0393d9725844ba258ac7c52bed0] Add column showing icon for last build cause
            git bisect good 4c7adb587fd0d0393d9725844ba258ac7c52bed0
          4. bad: [4efe343c3a1ef22263022bfa117f6444daa6eb10] Merge pull request #9 from imod/githookcause
            git bisect bad 4efe343c3a1ef22263022bfa117f6444daa6eb10
          5. bad: [4efe343c3a1ef22263022bfa117f6444daa6eb10] Merge pull request #9 from imod/githookcause
            git bisect bad 4efe343c3a1ef22263022bfa117f6444daa6eb10
          6. good: [4f33890d86689641edcb02b4099bf3d04039cbfa] Merge pull request #5 from damienfinck/master
            git bisect good 4f33890d86689641edcb02b4099bf3d04039cbfa
          7. bad: [8b0424d0875c70537cdcf9ea5bd7143928a72faf] Fixing JENKINS-22557
            git bisect bad 8b0424d0875c70537cdcf9ea5bd7143928a72faf
          8. good: [7d35c0f4ab624da60100e8c8b831b019b57b2837] Create README.md
            git bisect good 7d35c0f4ab624da60100e8c8b831b019b57b2837
          9. good: [f46db8784a07efca2da971c5c14028d50a8def4c] Merge pull request #7 from bigcplus/master
            git bisect good f46db8784a07efca2da971c5c14028d50a8def4c
          10. first bad commit: [8b0424d0875c70537cdcf9ea5bd7143928a72faf] Fixing JENKINS-22557

          Baptiste Mathus added a comment - Just did a git bisect, and indeed the UI was showing the text at some point : $ git bisect log git bisect start bad: [8d31cf754fa4cee0aa905bf9d76315dcd354cafe] [maven-release-plugin] prepare for next development iteration git bisect bad 8d31cf754fa4cee0aa905bf9d76315dcd354cafe good: [4c7adb587fd0d0393d9725844ba258ac7c52bed0] Add column showing icon for last build cause git bisect good 4c7adb587fd0d0393d9725844ba258ac7c52bed0 good: [4c7adb587fd0d0393d9725844ba258ac7c52bed0] Add column showing icon for last build cause git bisect good 4c7adb587fd0d0393d9725844ba258ac7c52bed0 bad: [4efe343c3a1ef22263022bfa117f6444daa6eb10] Merge pull request #9 from imod/githookcause git bisect bad 4efe343c3a1ef22263022bfa117f6444daa6eb10 bad: [4efe343c3a1ef22263022bfa117f6444daa6eb10] Merge pull request #9 from imod/githookcause git bisect bad 4efe343c3a1ef22263022bfa117f6444daa6eb10 good: [4f33890d86689641edcb02b4099bf3d04039cbfa] Merge pull request #5 from damienfinck/master git bisect good 4f33890d86689641edcb02b4099bf3d04039cbfa bad: [8b0424d0875c70537cdcf9ea5bd7143928a72faf] Fixing JENKINS-22557 git bisect bad 8b0424d0875c70537cdcf9ea5bd7143928a72faf good: [7d35c0f4ab624da60100e8c8b831b019b57b2837] Create README.md git bisect good 7d35c0f4ab624da60100e8c8b831b019b57b2837 good: [f46db8784a07efca2da971c5c14028d50a8def4c] Merge pull request #7 from bigcplus/master git bisect good f46db8784a07efca2da971c5c14028d50a8def4c first bad commit: [8b0424d0875c70537cdcf9ea5bd7143928a72faf] Fixing JENKINS-22557
          Baptiste Mathus made changes -
          Link New: This issue is related to JENKINS-22557 [ JENKINS-22557 ]

          OK, so the commit is https://github.com/jenkinsci/buildtriggerbadge-plugin/commit/8b0424d0875c70537cdcf9ea5bd7143928a72faf and has indeed been there for almost a year.

          I added the link to the associated JIRA. Actually, the text was somehow moved into the image title instead of added. I've asked my comaintainer to check what we wanted to do at that time to decide what to do next.

          Cheers

          Baptiste Mathus added a comment - OK, so the commit is https://github.com/jenkinsci/buildtriggerbadge-plugin/commit/8b0424d0875c70537cdcf9ea5bd7143928a72faf and has indeed been there for almost a year. I added the link to the associated JIRA. Actually, the text was somehow moved into the image title instead of added. I've asked my comaintainer to check what we wanted to do at that time to decide what to do next. Cheers

          OK, the intent was indeed actually to only show the icon (like elsewhere). So that makes the current issue no more a bug, but an improvement request.
          For me, it's two fold (from a "product" management perspective): either we just close this bug as wontfix because we want to keep the complexity low, or we add a new column variant named for example 'last build trigger - long version' and reintroduce a column with the old behaviour.

          If we were on a big product, I'd say the first solution may be better. In our case, I suppose the second case is feasible since the codebase is still pretty small. Though we sure want to reuse as much code as possible if we introduce that second column being a 'long' variant of the current one.

          Baptiste Mathus added a comment - OK, the intent was indeed actually to only show the icon (like elsewhere). So that makes the current issue no more a bug, but an improvement request. For me, it's two fold (from a "product" management perspective): either we just close this bug as wontfix because we want to keep the complexity low, or we add a new column variant named for example 'last build trigger - long version' and reintroduce a column with the old behaviour. If we were on a big product, I'd say the first solution may be better. In our case, I suppose the second case is feasible since the codebase is still pretty small. Though we sure want to reuse as much code as possible if we introduce that second column being a 'long' variant of the current one.

            ljader Łukasz Jąder
            jijohn J John
            Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

              Created:
              Updated:
              Resolved: