Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-26312

Save/Apply buttons overlapped by footer, with SCM Sync Config Plugin, buttons are hidden

      In 1.596 there is no save button on the job configuration page. Cannot modify any jobs. Reverting to 1.594 got the button back.

        1. full_size.JPG
          full_size.JPG
          201 kB
        2. small_size.JPG
          small_size.JPG
          212 kB
        3. scrollbar obscured.PNG
          scrollbar obscured.PNG
          10 kB
        4. JenkinsNoButton.png
          JenkinsNoButton.png
          145 kB

          [JENKINS-26312] Save/Apply buttons overlapped by footer, with SCM Sync Config Plugin, buttons are hidden

          Daniel Beck added a comment -

          Is the Simple Theme Plugin installed? If so, disable it, or remove the custom CSS/JS assignments from global configuration.

          Disable Greasemonkey or any similar browser-specific custom JS/CSS insertions.

          Please provide a screen shot showing the full browser window including scroll bar.

          Does this only occur on long job configuration pages that exceed the window height (i.e. where scrolling is needed)?

          Daniel Beck added a comment - Is the Simple Theme Plugin installed? If so, disable it, or remove the custom CSS/JS assignments from global configuration. Disable Greasemonkey or any similar browser-specific custom JS/CSS insertions. Please provide a screen shot showing the full browser window including scroll bar. Does this only occur on long job configuration pages that exceed the window height (i.e. where scrolling is needed)?

          Igor Koyfman added a comment - - edited

          I uninstalled the Simple Theme Plugin, and I'm using Chrome. I don't have any jobs that fit on one screen.
          Also, I checked in IE and there is no Save or Apply button there either. I don't have Firefox.

          Igor Koyfman added a comment - - edited I uninstalled the Simple Theme Plugin, and I'm using Chrome. I don't have any jobs that fit on one screen. Also, I checked in IE and there is no Save or Apply button there either. I don't have Firefox.

          Igor Koyfman added a comment - - edited

          I zoomed out the browser until it got so small the job did fit on one screen, and the buttons did show up then. So I guess that's a workaround.
          P.S. Even better, if I scroll to the bottom of the page and zoom in and then zoom out, then the buttons show up even if the scroll bars are still there.

          Igor Koyfman added a comment - - edited I zoomed out the browser until it got so small the job did fit on one screen, and the buttons did show up then. So I guess that's a workaround. P.S. Even better, if I scroll to the bottom of the page and zoom in and then zoom out, then the buttons show up even if the scroll bars are still there.

          Daniel Beck added a comment -

          Confirmed. For me, Save/Apply buttons are only partially hidden by the footer bar, but that's because I don't have SCM Sync Config Plugin installed.

          Caused by https://github.com/jenkinsci/jenkins/commit/3e9cdcbc8527d6ee2be143aad3365df8fcd02c74

          Daniel Beck added a comment - Confirmed. For me, Save/Apply buttons are only partially hidden by the footer bar, but that's because I don't have SCM Sync Config Plugin installed. Caused by https://github.com/jenkinsci/jenkins/commit/3e9cdcbc8527d6ee2be143aad3365df8fcd02c74

          Daniel Beck added a comment -

          Workaround would probably be to define

          #footer-container { position: fixed !important; }

          using Simple Theme Plugin (untested). Alternatively, remove (display:none) a bunch of crap from the footer to reduce its height.

          Due to presence of workaround, reducing issue priority. Rewrote issue title to reflect findings.

          Assigning tentatively to tfennelly, who appears to have introduced this issue.

          Daniel Beck added a comment - Workaround would probably be to define #footer-container { position: fixed !important; } using Simple Theme Plugin (untested). Alternatively, remove ( display:none ) a bunch of crap from the footer to reduce its height. Due to presence of workaround, reducing issue priority. Rewrote issue title to reflect findings. Assigning tentatively to tfennelly, who appears to have introduced this issue.

          Igor Koyfman added a comment -

          This also happens on other pages with buttons at the bottom, e.g. the system configuration page, the plugin installation page, etc. The zoom in/zoom out workaround works for all. The CSS workaround with the Simple Theme Plugin mentioned above didn't work.

          Igor Koyfman added a comment - This also happens on other pages with buttons at the bottom, e.g. the system configuration page, the plugin installation page, etc. The zoom in/zoom out workaround works for all. The CSS workaround with the Simple Theme Plugin mentioned above didn't work.

          What is the point in having footer fixed-positioned, btw? This makes sense for breadcrumbs that contain often used navigation links which is not the case for footer.

          Oliver Gondža added a comment - What is the point in having footer fixed-positioned, btw? This makes sense for breadcrumbs that contain often used navigation links which is not the case for footer.

          Tom FENNELLY added a comment -

          Sorry guys. My bad. Looking into it.

          Tom FENNELLY added a comment - Sorry guys. My bad. Looking into it.

          We are also running into the issue. Having a work-around is one thing, but really, not being able to save any change to a job (and many other things, e.g. any long enough plugin list like 'available' has the same problem) unless you happen to find this issue log and read halfway through the comments to discover the workaround... that's not a minor issue to me at all!
          After fiddling around, I found that scrolling all the way down then doing something that causes the page layout to be recalculated (I think) will make the buttons show up, e.g. resizing the browser window most of the time, esp when I make the window bigger.
          However, at that point the white bar they seem to be on obscures the last part of my scrollbar. I'll try to add a screenshot if what I mean.

          Arnt Witteveen added a comment - We are also running into the issue. Having a work-around is one thing, but really, not being able to save any change to a job (and many other things, e.g. any long enough plugin list like 'available' has the same problem) unless you happen to find this issue log and read halfway through the comments to discover the workaround... that's not a minor issue to me at all! After fiddling around, I found that scrolling all the way down then doing something that causes the page layout to be recalculated (I think) will make the buttons show up, e.g. resizing the browser window most of the time, esp when I make the window bigger. However, at that point the white bar they seem to be on obscures the last part of my scrollbar. I'll try to add a screenshot if what I mean.

          Arnt Witteveen added a comment - - edited

          Screenshot: On the right side, you can see the part of the scrollbar that indicates where you are is almost completely hidden by the white background bar of the save button. (firefox 34.0.5)

          Arnt Witteveen added a comment - - edited Screenshot: On the right side, you can see the part of the scrollbar that indicates where you are is almost completely hidden by the white background bar of the save button. (firefox 34.0.5)

          I encountered this issue right after upgrading to 1.596.
          This is NOT a minor issue, I'm unable to save/apply any changes only if I change the magnification size of the page.
          2 screen shots are attached to show that in normal view in chrome the buttons are not visible.

          Lilach Eisenberg added a comment - I encountered this issue right after upgrading to 1.596. This is NOT a minor issue, I'm unable to save/apply any changes only if I change the magnification size of the page. 2 screen shots are attached to show that in normal view in chrome the buttons are not visible.

          Etienne BAALI added a comment -

          Hello,
          Same thing here.
          If you don't want to downgrade version, you can show up the button if you go to bottom and set full screen (F11).

          Etienne BAALI added a comment - Hello, Same thing here. If you don't want to downgrade version, you can show up the button if you go to bottom and set full screen (F11).

          Daniel Beck added a comment -
          #footer-container {
          	display: none;
          }

          This Simple Theme plugin CSS works for me as workaround, without SCM Sync Plugin.

          If you don't want to remove the footer entirely (e.g. to keep SCM Sync info), something like the following removes all the crap and reduces vertical space used:

          #footer .page_generated {
          	display: none;
          }
          #footer .rest_api {
          	display: none;
          }
          #footer .jenkins_ver {
          	display: none;
          }
          #footer .page_generated {
          	display: none;
          }
          #footer #l10n-footer { // Localization Plugin
          	display: none !important;
          }
          #footer-container {
          	padding: 0px;
          }

          that's not a minor issue to me at all!

          This is NOT a minor issue, I'm unable to save/apply any changes only if I change the magnification size of the page.

          Feel free to bring this up in the next Governance Meeting of the Jenkins project. I'm just applying the priority as defined in Jira. And it's really not difficult to find the workaround, or apply it. Writing the above rules took maybe five minutes.

          Daniel Beck added a comment - #footer-container { display: none; } This Simple Theme plugin CSS works for me as workaround, without SCM Sync Plugin. If you don't want to remove the footer entirely (e.g. to keep SCM Sync info), something like the following removes all the crap and reduces vertical space used: #footer .page_generated { display: none; } #footer .rest_api { display: none; } #footer .jenkins_ver { display: none; } #footer .page_generated { display: none; } #footer #l10n-footer { // Localization Plugin display: none !important; } #footer-container { padding: 0px; } that's not a minor issue to me at all! This is NOT a minor issue, I'm unable to save/apply any changes only if I change the magnification size of the page. Feel free to bring this up in the next Governance Meeting of the Jenkins project. I'm just applying the priority as defined in Jira. And it's really not difficult to find the workaround, or apply it. Writing the above rules took maybe five minutes.

          Tom FENNELLY added a comment -

          Please take https://github.com/jenkinsci/jenkins/pull/1520 for a test drive (once CI builds it).

          Tom FENNELLY added a comment - Please take https://github.com/jenkinsci/jenkins/pull/1520 for a test drive (once CI builds it).

          Igor Koyfman added a comment -

          Tom, I see the buttons now. Thank you for the fix.

          Igor Koyfman added a comment - Tom, I see the buttons now. Thank you for the fix.

          Adding this to the end of style.css worked for me. It't not pretty but it works.

           
          #footer {
            display: none;
            padding: 3px 0px;
          }
          #footer-container:hover > #footer, #footer td{
            display: inherit;
            padding: 10px 0px;
          }
          

          Rickard Lebbin added a comment - Adding this to the end of style.css worked for me. It't not pretty but it works. #footer { display: none; padding: 3px 0px; } #footer-container:hover > #footer, #footer td{ display: inherit; padding: 10px 0px; }

          Code changed in jenkins
          User: tfennelly
          Path:
          core/src/main/resources/lib/layout/layout.jelly
          war/src/main/webapp/css/style.css
          war/src/main/webapp/scripts/hudson-behavior.js
          http://jenkins-ci.org/commit/jenkins/e2ec9eb3c23a6b4f63c338e634d647486a136f7b
          Log:
          [FIX JENKINS-26312] reimpl of layout changes 3e9cdcb

          Attempt to do it in pure CSS ala 3e9cdcb failed so using CSS and JS combo.

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: tfennelly Path: core/src/main/resources/lib/layout/layout.jelly war/src/main/webapp/css/style.css war/src/main/webapp/scripts/hudson-behavior.js http://jenkins-ci.org/commit/jenkins/e2ec9eb3c23a6b4f63c338e634d647486a136f7b Log: [FIX JENKINS-26312] reimpl of layout changes 3e9cdcb Attempt to do it in pure CSS ala 3e9cdcb failed so using CSS and JS combo.

          Code changed in jenkins
          User: tfennelly
          Path:
          changelog.html
          http://jenkins-ci.org/commit/jenkins/9309cd39ad44836fba983ae6385e7ab567cd5e3b
          Log:
          Noting 1520

          Fixed JENKINS-26312, JENKINS-26298 and JENKINS-26306

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: tfennelly Path: changelog.html http://jenkins-ci.org/commit/jenkins/9309cd39ad44836fba983ae6385e7ab567cd5e3b Log: Noting 1520 Fixed JENKINS-26312 , JENKINS-26298 and JENKINS-26306

          Tom FENNELLY added a comment -

          Fix merged upstream.

          Tom FENNELLY added a comment - Fix merged upstream.

          Simon Strauch added a comment - - edited

          (Sorry, danielbeck. Sorry, tfennelly)

          Simon Strauch added a comment - - edited ( Sorry, danielbeck . Sorry, tfennelly )

          Daniel Beck added a comment -

          12delta:

          It puts the "save" Button at the bottom of the page. To click the buttons, you have to scroll down to the bottom of the page.

          IIRC we had this, long ago. It was horrible to use on long config forms (that Jenkins' forms are too long is a different issue, we need to deal with what we have though).

          That said, just file a new issue and/or a PR with your change, then it can be discussed properly.

          Daniel Beck added a comment - 12delta : It puts the "save" Button at the bottom of the page. To click the buttons, you have to scroll down to the bottom of the page. IIRC we had this, long ago. It was horrible to use on long config forms (that Jenkins' forms are too long is a different issue, we need to deal with what we have though). That said, just file a new issue and/or a PR with your change, then it can be discussed properly.

          dogfood added a comment -

          Integrated in jenkins_main_trunk #3926
          [FIX JENKINS-26312] reimpl of layout changes 3e9cdcb (Revision e2ec9eb3c23a6b4f63c338e634d647486a136f7b)

          Result = SUCCESS
          tom.fennelly : e2ec9eb3c23a6b4f63c338e634d647486a136f7b
          Files :

          • war/src/main/webapp/css/style.css
          • war/src/main/webapp/scripts/hudson-behavior.js
          • core/src/main/resources/lib/layout/layout.jelly

          dogfood added a comment - Integrated in jenkins_main_trunk #3926 [FIX JENKINS-26312] reimpl of layout changes 3e9cdcb (Revision e2ec9eb3c23a6b4f63c338e634d647486a136f7b) Result = SUCCESS tom.fennelly : e2ec9eb3c23a6b4f63c338e634d647486a136f7b Files : war/src/main/webapp/css/style.css war/src/main/webapp/scripts/hudson-behavior.js core/src/main/resources/lib/layout/layout.jelly

          Another workaround, Just go to fullscreen mode in your browser (F11), You can see the Save / Apply buttons.

          Bakkiaraj Murugesan added a comment - Another workaround, Just go to fullscreen mode in your browser (F11), You can see the Save / Apply buttons.

          Tom FENNELLY added a comment -

          Guys, please create a separate JIRA for the suggestions around button positioning. It's a separate issue.

          Tom FENNELLY added a comment - Guys, please create a separate JIRA for the suggestions around button positioning. It's a separate issue.

          Michael Bleidistel added a comment - - edited

          This is still an issue in 1.597 for me. Which build is this supposed to be fixed in?
          Also, I don't think I have the Sync Config Plugin installed... it may be a general issue. This started, I believe, with 1.596 or 1.5.955

          Michael Bleidistel added a comment - - edited This is still an issue in 1.597 for me. Which build is this supposed to be fixed in? Also, I don't think I have the Sync Config Plugin installed... it may be a general issue. This started, I believe, with 1.596 or 1.5.955

          Daniel Beck added a comment -

          The fix is in 1.598. (Jenkins project has this weird release cycle where a fix takes 1-2 weeks to be released.)

          The basic issue occurs in every instance, with buttons partially overlapping, but if you have a plugin that increases footer height, the buttons disappear altogether behind it.

          Daniel Beck added a comment - The fix is in 1.598. (Jenkins project has this weird release cycle where a fix takes 1-2 weeks to be released.) The basic issue occurs in every instance, with buttons partially overlapping, but if you have a plugin that increases footer height, the buttons disappear altogether behind it.

          Simon Strauch added a comment - - edited

          Works for me in 1.598, thank you. (I hope this comment is appreciated.)

          Simon Strauch added a comment - - edited Works for me in 1.598, thank you. (I hope this comment is appreciated.)

          Tom FENNELLY added a comment -

          @Simon Hi Simon. I find many people are usually only ever heard from when they want to be critical (in a negative way), so it's nice and well appreciated when someone lets us know that they are happy about something. Thanks a lot.

          Tom FENNELLY added a comment - @Simon Hi Simon. I find many people are usually only ever heard from when they want to be critical (in a negative way), so it's nice and well appreciated when someone lets us know that they are happy about something. Thanks a lot.

          Eric Nadler added a comment -

          Also very happy to have this working in 1.598 for me also. Thank you!

          Eric Nadler added a comment - Also very happy to have this working in 1.598 for me also. Thank you!

          Brian Carr added a comment -

          Thanks for the explanation that the fix is in 1.598. We have the problem on 1.597 and eagerly await 1.598. Also, thanks for the workaround of disabling the footer. That worked very nicely for us.

          Brian Carr added a comment - Thanks for the explanation that the fix is in 1.598. We have the problem on 1.597 and eagerly await 1.598. Also, thanks for the workaround of disabling the footer. That worked very nicely for us.

          Code changed in jenkins
          User: tfennelly
          Path:
          core/src/main/resources/lib/layout/layout.jelly
          war/src/main/webapp/css/style.css
          war/src/main/webapp/scripts/hudson-behavior.js
          http://jenkins-ci.org/commit/jenkins/f98947f6e426eb3e922e0836c279084caa296547
          Log:
          [FIX JENKINS-26312] reimpl of layout changes 3e9cdcb

          Attempt to do it in pure CSS ala 3e9cdcb failed so using CSS and JS combo.

          (cherry picked from commit e2ec9eb3c23a6b4f63c338e634d647486a136f7b)

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: tfennelly Path: core/src/main/resources/lib/layout/layout.jelly war/src/main/webapp/css/style.css war/src/main/webapp/scripts/hudson-behavior.js http://jenkins-ci.org/commit/jenkins/f98947f6e426eb3e922e0836c279084caa296547 Log: [FIX JENKINS-26312] reimpl of layout changes 3e9cdcb Attempt to do it in pure CSS ala 3e9cdcb failed so using CSS and JS combo. (cherry picked from commit e2ec9eb3c23a6b4f63c338e634d647486a136f7b)

          dogfood added a comment -

          Integrated in jenkins_main_trunk #4292
          [FIX JENKINS-26312] reimpl of layout changes 3e9cdcb (Revision f98947f6e426eb3e922e0836c279084caa296547)

          Result = UNSTABLE
          ogondza : f98947f6e426eb3e922e0836c279084caa296547
          Files :

          • core/src/main/resources/lib/layout/layout.jelly
          • war/src/main/webapp/css/style.css
          • war/src/main/webapp/scripts/hudson-behavior.js

          dogfood added a comment - Integrated in jenkins_main_trunk #4292 [FIX JENKINS-26312] reimpl of layout changes 3e9cdcb (Revision f98947f6e426eb3e922e0836c279084caa296547) Result = UNSTABLE ogondza : f98947f6e426eb3e922e0836c279084caa296547 Files : core/src/main/resources/lib/layout/layout.jelly war/src/main/webapp/css/style.css war/src/main/webapp/scripts/hudson-behavior.js

          Phil Johnson added a comment -

          Is this issue "really" fixed? We are experiencing the same exact issue (the footer overlaps the page buttons at the bottom if the SCM Sync Plugin is installed and checked the "Display Sync Status" checkbox for that plugin).

          Jenkins Version: Jenkins 1.642
          SCM Sync (configuration) Plugin: 0.0.9

          The issue seems to be that whenever there is a sync error the footer "grows". Any insight from those who have experienced this would be greatly appreciated.
          Cheers.

          Phil Johnson added a comment - Is this issue " really " fixed? We are experiencing the same exact issue (the footer overlaps the page buttons at the bottom if the SCM Sync Plugin is installed and checked the "Display Sync Status" checkbox for that plugin). Jenkins Version: Jenkins 1.642 SCM Sync (configuration) Plugin: 0.0.9 The issue seems to be that whenever there is a sync error the footer "grows". Any insight from those who have experienced this would be greatly appreciated. Cheers.

          Mark Hudson added a comment -

          Go into Configure system, and scroll down to the SCM Sync configuration section, then uncheck the "Display SCM Sync Status" checkbox.

          Mark Hudson added a comment - Go into Configure system, and scroll down to the SCM Sync configuration section, then uncheck the "Display SCM Sync Status" checkbox.

          Rashid Amiri added a comment - - edited

          There's a workaround for this, while you are in configure page, click back button on your browser and then click the forward button to redirect you back to the configure page and you will see the save and apply buttons. 

          Rashid Amiri added a comment - - edited There's a workaround for this, while you are in configure page, click back button on your browser and then click the forward button to redirect you back to the configure page and you will see the save and apply buttons. 

            tfennelly Tom FENNELLY
            igorama Igor Koyfman
            Votes:
            1 Vote for this issue
            Watchers:
            24 Start watching this issue

              Created:
              Updated:
              Resolved: