Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-3107

"Advanced" section should be expanded if it is customized

    • Icon: Bug Bug
    • Resolution: Fixed
    • Icon: Major Major
    • core
    • None
    • Platform: All, OS: All

      If you have configured something using an "Advanced" section, and later you or
      someone else goes back to the configuration screen, that section will be
      collapsed - even though it contains nondefault, and possibly critical,
      configuration information.

      Assuming there is some way to distinguish default from customized settings, the
      Advanced section should be displayed as initially expanded in the latter case.

          [JENKINS-3107] "Advanced" section should be expanded if it is customized

          Jesse Glick created issue -
          Alan Harder made changes -
          Link New: This issue is duplicated by JENKINS-6622 [ JENKINS-6622 ]
          Jesse Glick made changes -
          Link New: This issue is duplicated by JENKINS-14402 [ JENKINS-14402 ]

          Jesse Glick added a comment -

          Jesse Glick added a comment - https://github.com/jenkinsci/ant-plugin/pull/5 for example.
          Jesse Glick made changes -
          Jesse Glick made changes -
          Assignee New: Jesse Glick [ jglick ]
          Jesse Glick made changes -
          Status Original: Open [ 1 ] New: In Progress [ 3 ]

          I don't think this is a good idea...
          If we really want this, then i think the logical consequence would be to expand and remove the advanced buttons at all.
          But i think the advanced section is perfect to not have to over fill the UI.
          I think it would be much better to give the user an option to expand all advanced sections.
          In fact i fink the advanced sections should even be colapsable.

          Dominik Bartholdi added a comment - I don't think this is a good idea... If we really want this, then i think the logical consequence would be to expand and remove the advanced buttons at all. But i think the advanced section is perfect to not have to over fill the UI. I think it would be much better to give the user an option to expand all advanced sections. In fact i fink the advanced sections should even be colapsable.

          Jesse Glick added a comment -

          The advanced sections are useful to not overload the UI with options you are never use.

          The problem is when you do use those options—or rather, someone on your team used those options without telling you and now you are trying to figure out why the build is behaving weirdly. Without this patch, there is no visual indication that anything in the advanced section has been touched. And even if you know/remember that there is something customized in a given advanced section, if you made that customization it is quite likely you are going to make changes to it in the future and want to always see it.

          Remember that the patch only expands those advanced sections with customizations. Others in the same form are left collapsed. So for example if you have a job with an Ant build step that defines some properties, that section will be shown in full, but there will still be a collapsed section at the top for display name and custom workspace.

          I would not argue against making advanced sections recollapsible, but that is an orthogonal RFE.

          Jesse Glick added a comment - The advanced sections are useful to not overload the UI with options you are never use. The problem is when you do use those options—or rather, someone on your team used those options without telling you and now you are trying to figure out why the build is behaving weirdly. Without this patch, there is no visual indication that anything in the advanced section has been touched. And even if you know/remember that there is something customized in a given advanced section, if you made that customization it is quite likely you are going to make changes to it in the future and want to always see it. Remember that the patch only expands those advanced sections with customizations. Others in the same form are left collapsed. So for example if you have a job with an Ant build step that defines some properties, that section will be shown in full, but there will still be a collapsed section at the top for display name and custom workspace. I would not argue against making advanced sections recollapsible, but that is an orthogonal RFE.

          I do understand your points, but I just don't think this is a good solution.
          Some advanced sections are quite big e.g. for maven and now, just because I change a checkbox (like disable auto archiving) the whole section gets expanded.

          Dominik Bartholdi added a comment - I do understand your points, but I just don't think this is a good solution. Some advanced sections are quite big e.g. for maven and now, just because I change a checkbox (like disable auto archiving) the whole section gets expanded.

            jglick Jesse Glick
            jglick Jesse Glick
            Votes:
            1 Vote for this issue
            Watchers:
            7 Start watching this issue

              Created:
              Updated:
              Resolved: