• Icon: Bug Bug
    • Resolution: Fixed
    • Icon: Minor Minor
    • core
    • None

      Recently, some JSHint errors were introduced:

      [INFO] src/main/js/pluginSetupWizardGui.js: line 528, col 53, Expected '===' and instead saw '=='.
      [INFO] src/main/js/pluginSetupWizardGui.js: line 430, col 40, 'state' is defined but never used.
      [INFO] src/main/js/pluginSetupWizardGui.js: line 798, col 42, Expected '===' and instead saw '=='.
      [INFO] src/main/js/pluginSetupWizardGui.js: line 953, col 23, Expected '!==' and instead saw '!='.
      [INFO] src/main/js/pluginSetupWizardGui.js: line 954, col 16, 'setupWizardExtensions' is not defined.
      [INFO] 
      [INFO] 5 errors
      [INFO] src/main/js/upgradeWizard.js: line 2, col 9, '$' is defined but never used.
      [INFO] src/main/js/upgradeWizard.js: line 1, col 1, 'onSetupWizardInitialized' is not defined.
      [INFO] 
      [INFO] 2 errors
      [INFO] src/main/js/util/jenkins.js: line 201, col 49, 'receiver' is defined but never used.
      [INFO] src/main/js/util/jenkins.js: line 200, col 32, 'Proxy' is not defined.
      [INFO] 
      [INFO] 2 errors
      

      It seems this JENKINS-34438 is not working very well.

          [JENKINS-35020] Fix JSHint errors

          Manuel Recena Soto created issue -
          Manuel Recena Soto made changes -
          Remote Link New: This issue links to "PR (Web Link)" [ 14334 ]
          Manuel Recena Soto made changes -
          Status Original: Open [ 1 ] New: In Progress [ 3 ]
          Manuel Recena Soto made changes -
          Priority Original: Major [ 3 ] New: Minor [ 4 ]

          Code changed in jenkins
          User: Manuel Recena
          Path:
          war/src/main/js/pluginSetupWizardGui.js
          war/src/main/js/upgradeWizard.js
          war/src/main/js/util/jenkins.js
          http://jenkins-ci.org/commit/jenkins/1fe92556c20feee48022ed0c586a4ec479ae232d
          Log:
          JENKINS-35020 Fixed some JSHint errors (#2368)

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Manuel Recena Path: war/src/main/js/pluginSetupWizardGui.js war/src/main/js/upgradeWizard.js war/src/main/js/util/jenkins.js http://jenkins-ci.org/commit/jenkins/1fe92556c20feee48022ed0c586a4ec479ae232d Log: JENKINS-35020 Fixed some JSHint errors (#2368) JENKINS-35020 Fixed some JSHint errors JENKINS-35020 @kzantow's comment was addressed JENKINS-35020 @kzantow's comment was addressed
          Manuel Recena Soto made changes -
          Resolution New: Fixed [ 1 ]
          Status Original: In Progress [ 3 ] New: Resolved [ 5 ]

          Oleg Nenashev added a comment -

          Oleg Nenashev added a comment - If we backport it, it also requires https://github.com/jenkinsci/jenkins/commit/a2e7661f212c4564fffa57ddc9b9ab92f2f2dc5b

          Oleg Nenashev added a comment - - edited

          Released as Jenkins-2.7

          Oleg Nenashev added a comment - - edited Released as Jenkins-2.7
          R. Tyler Croy made changes -
          Workflow Original: JNJira [ 171229 ] New: JNJira + In-Review [ 199058 ]

            recena Manuel Recena Soto
            recena Manuel Recena Soto
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

              Created:
              Updated:
              Resolved: