Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-35316

Nuget plugin publication succeeds when nupkg doesn't exist

    XMLWordPrintable

Details

    • Bug
    • Status: Resolved (View Workflow)
    • Minor
    • Resolution: Fixed
    • nuget-plugin
    • None
    • Jenkins 1.651.2
      NuGet 0.5

    Description

      I have specified the package to publish to my NuGet feed with no wildcards, i.e.

      agsimsetup.$BUILD_ID.nupkg

      This works fine:

      Starting agdev publication
      [agsimsetup-dev] $ nuget push agsimsetup.2.2.1.0-build-69.nupkg ******** -Source https://api.bintray.com/nuget/aboutgolf/agdev -NonInteractive
      Pushing agsimsetup.2.2.1.0-build-69.nupkg to 'https://api.bintray.com/nuget/aboutgolf/agdev'...
      PUT https://api.bintray.com/nuget/aboutgolf/agdev/
      Created https://api.bintray.com/nuget/aboutgolf/agdev/ 2021ms
      Your package was pushed.
      Ended agdev publication
      Finished: SUCCESS

      If, however, I specify a non-existing package no error is generated. For example, if the change the package to publish to:

      agsimbadsetup.$BUILD_ID.nupkg

      Then the publish still succeeds (though of course nothing is published):

      Starting agdev publication
      Ended agdev publication
      Finished: SUCCESS

      In this case I expect it to fail.

      Attachments

        Issue Links

          mentioned in

          Page Loading...

          Activity

            Ascending order - Click to sort in descending order
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Arnaud
            Path:
            src/main/java/org/jenkinsci/plugins/nuget/publishers/NugetPromotionPublisher.java
            src/main/java/org/jenkinsci/plugins/nuget/publishers/NugetPublisher.java
            src/main/java/org/jenkinsci/plugins/nuget/publishers/NugetPublisherCallable.java
            src/main/resources/org/jenkinsci/plugins/nuget/publishers/NugetPublisher/config.jelly
            http://jenkins-ci.org/commit/nuget-plugin/a5d359d1da661a06d457254ec783f7e19bb9ed0a
            Log:
            [FIXED JENKINS-35316] Nuget plugin publication succeeds when nupkg doesn't exist

            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Arnaud Path: src/main/java/org/jenkinsci/plugins/nuget/publishers/NugetPromotionPublisher.java src/main/java/org/jenkinsci/plugins/nuget/publishers/NugetPublisher.java src/main/java/org/jenkinsci/plugins/nuget/publishers/NugetPublisherCallable.java src/main/resources/org/jenkinsci/plugins/nuget/publishers/NugetPublisher/config.jelly http://jenkins-ci.org/commit/nuget-plugin/a5d359d1da661a06d457254ec783f7e19bb9ed0a Log: [FIXED JENKINS-35316] Nuget plugin publication succeeds when nupkg doesn't exist
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Arnaud TAMAILLON
            Path:
            src/main/java/org/jenkinsci/plugins/nuget/publishers/NugetPromotionPublisher.java
            src/main/java/org/jenkinsci/plugins/nuget/publishers/NugetPublisher.java
            src/main/java/org/jenkinsci/plugins/nuget/publishers/NugetPublisherCallable.java
            src/main/resources/org/jenkinsci/plugins/nuget/Messages.properties
            src/main/resources/org/jenkinsci/plugins/nuget/Messages_fr.properties
            src/main/resources/org/jenkinsci/plugins/nuget/publishers/NugetPublisher/config.jelly
            src/main/resources/org/jenkinsci/plugins/nuget/publishers/NugetPublisher/config.properties
            src/main/resources/org/jenkinsci/plugins/nuget/publishers/NugetPublisher/config_fr.properties
            http://jenkins-ci.org/commit/nuget-plugin/d4c02c734c5707dfc797d8184dda55635153d66d
            Log:
            Merge pull request #7 from Greybird/JENKINS-35316

            JENKINS-35316 : Nuget plugin publication succeeds when nupkg doesn't exist

            Compare: https://github.com/jenkinsci/nuget-plugin/compare/0f364f112bd0...d4c02c734c57

            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Arnaud TAMAILLON Path: src/main/java/org/jenkinsci/plugins/nuget/publishers/NugetPromotionPublisher.java src/main/java/org/jenkinsci/plugins/nuget/publishers/NugetPublisher.java src/main/java/org/jenkinsci/plugins/nuget/publishers/NugetPublisherCallable.java src/main/resources/org/jenkinsci/plugins/nuget/Messages.properties src/main/resources/org/jenkinsci/plugins/nuget/Messages_fr.properties src/main/resources/org/jenkinsci/plugins/nuget/publishers/NugetPublisher/config.jelly src/main/resources/org/jenkinsci/plugins/nuget/publishers/NugetPublisher/config.properties src/main/resources/org/jenkinsci/plugins/nuget/publishers/NugetPublisher/config_fr.properties http://jenkins-ci.org/commit/nuget-plugin/d4c02c734c5707dfc797d8184dda55635153d66d Log: Merge pull request #7 from Greybird/ JENKINS-35316 JENKINS-35316 : Nuget plugin publication succeeds when nupkg doesn't exist Compare: https://github.com/jenkinsci/nuget-plugin/compare/0f364f112bd0...d4c02c734c57

            People

              greybird Arnaud TAMAILLON
              apteryx Russell Mora
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: